From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B7699A04FF; Wed, 27 Apr 2022 12:54:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 64E8540E78; Wed, 27 Apr 2022 12:54:26 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 0423840691 for ; Wed, 27 Apr 2022 12:54:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651056864; x=1682592864; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=1c5LfneeAlrTqwlnEQLco01fppe16HeNSUjYgeCrxRk=; b=ADm8/qGNPm9pQadikBA0MmJWTf2XKSLghmXIVzyyuXx9iZYJRmr4mdXw i6rVvfMBp1y0giDqFLsiz1t0ofdkqrsgk0+kr18kvhoKmx5PfXwpPq/NX vQeeSUyjmRBvLp0Srm23qIu9I+Wfm8bd7agiZHeNJC1oPZoyuYZKHGs2w 3GYjXzBxYWKG4ReLH4KNqSFpBw0PJMDH7Fw5DfhPsOGOS/j+Xj8g0nPzv ogfO7oH9zt8YLypcXTdqEM2JjQ3N2aAb1sRgE+JR1AUTlsFOHAEsvkhy7 UY5qtr6/3Zy5byfIPx7iW88RVvkvKGr1H2Je81bmLt5OdDbaG6IiXrUtr w==; X-IronPort-AV: E=McAfee;i="6400,9594,10329"; a="246454166" X-IronPort-AV: E=Sophos;i="5.90,292,1643702400"; d="scan'208";a="246454166" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2022 03:54:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,292,1643702400"; d="scan'208";a="580529936" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga008.jf.intel.com with ESMTP; 27 Apr 2022 03:54:22 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 27 Apr 2022 03:54:22 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 27 Apr 2022 03:54:21 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 27 Apr 2022 03:54:21 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.104) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 27 Apr 2022 03:54:21 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KiGEL7uDyq8ZIi3NwUsLRNSsros61WRkNjf7hRCrSNRG5LEFdJuFBe7lxA8NjHoBhqWuTYijYvyni9qxi9AHxB8mw46IMdsOJQgy05VQXsYv/f3/Euqp4x4VxhRHIQq4E0BbZDIyobiaKithgRQLYHBY3DH+j9LjIDIdKnNBTwKnL5Y6Gi0ItLgJni1Hk1qCW/Qejbhgqv8E0HOpiCRYVN4iHkbZLQEREjyE6RVqzSBDklsMtSVY5JlGg6oyJa1vipEQPTgJR28nRO3MAK1b+sU/S9+Mh3UxEWv4IjQOPbgMjPACY/aQt5Et+QzSU5KF3T1Vavc/JXXPjPzQtopJAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J/pr1dEgAbjOeq+2NPQnKhhKgaXRx0cw/5rQp8qX3Sk=; b=XHmYl6jChmCcF4f4jyj5qy/MDZNX5kpD6aZWYp0AqBZXxOb8bu6DcYfHmYLfZBoohGFdn5CKShgyl/uTMh70JDvoMeSxg88DlfRgzZShEO48bZCtC5XNufIq7kOJyL/LRWsZnnMB/U8HSKTGu2MFTYWqy1RpSPiZtDaJu9l3RTvb9ii9PD7Qjd3j0TxcDA9coHDumCnJ1xCcRWXJf6rHlJlAGjlfvOaUZ9ct5BVvnix+1r6HIx2juw5a+h27mfHgscTYDf9FoxaMCZkGg8h01HkUIw/lVD6lUf37jRvE7QcIhN0B+f9J8TnNBj+9v2ChXJxcScjcNs5q8d0LLSWl2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) by MN2PR11MB4447.namprd11.prod.outlook.com (2603:10b6:208:194::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Wed, 27 Apr 2022 10:54:19 +0000 Received: from MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::d55d:28c1:bfab:3dd]) by MW4PR11MB5872.namprd11.prod.outlook.com ([fe80::d55d:28c1:bfab:3dd%5]) with mapi id 15.20.5186.021; Wed, 27 Apr 2022 10:54:19 +0000 Message-ID: Date: Wed, 27 Apr 2022 11:54:13 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v3 2/3] examples/dma: fix Tx drop statistic is not collected To: Chengwen Feng , , , CC: References: <20220411025634.33032-1-fengchengwen@huawei.com> <20220424060741.33214-1-fengchengwen@huawei.com> <20220424060741.33214-3-fengchengwen@huawei.com> From: Kevin Laatz In-Reply-To: <20220424060741.33214-3-fengchengwen@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0249.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a7::20) To MW4PR11MB5872.namprd11.prod.outlook.com (2603:10b6:303:169::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9e181ca4-153c-43ea-8046-08da283c4796 X-MS-TrafficTypeDiagnostic: MN2PR11MB4447:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: d5XBfqpiawaVmPw8JjtL2um4pgh8xD3uNKI1Csn+9z4gT+SJEKpijq4JF5mxqrY9VKRS6DnnCAcXNMgBj80hCqEyp8yzDC6iGdpzp2qlpBu/ci2V/bg/3azxwynx9/0lEsSygXsnKNze0lj2CRObc3S6FM2LxObeo/odP1qUvgys8GTDW/hYni4BqncHOCYjomxjODH8jPpzL0STZUu1ResTnvgaBXZvxHTEsvtpwWRZfWRe/vPTHioAu2iTagXCHd/ZgxL0LYHJgZPBrkV/h8RVg1ehr0oZdY43kq9ZBwwgFt91cEyE4soCcTTrL1c+em2N1xWAc3RG38VZXc3wHSQJ4LBBWlY364Zirk48BiF23RBHExjhLGg8h9afCv47heW8ICsRKEiHY4ZFCDCxU9ds/Oh3E6eMdexJ6CCzGkKZw0iFDWIUvqWW3XSd1ZukL0Zo5UwPGXlayglLJHbD6Qs2N/pZE+62EkmaUKdQ7y4v2+4HjZRyfer3piNknlF4NJp0W8hLBMN1J4sOF6OpzhXv1OqchOv0XiDDyPSSpufewJWxsg85Q2bXT1QDhyENJX3a/8Pi2VGNSDLDlakCWH5EZIl810iVD1XSjmMYMkkjg9OgWYHl+fCrILnUASg0lW151/kS7cQhuK2NA5bsr6ReXlPeKq1EU9C7fxQExCx8x5IvDRY/HXlHgBYtq/ECqCcr1XOQtI21oLzB3K3PRw1o98p4p1B3zOBOe7U31eE= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW4PR11MB5872.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(66476007)(316002)(5660300002)(36756003)(186003)(4744005)(66946007)(66556008)(2906002)(44832011)(4326008)(8676002)(6636002)(83380400001)(8936002)(31686004)(2616005)(31696002)(86362001)(6486002)(508600001)(38100700002)(82960400001)(6666004)(26005)(6512007)(53546011)(6506007)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K1NLY09BMzdMTWNPNHA0akFhL0RTb2l0ZlhkSUlnTWpJOFlTVFdzNEtLUndZ?= =?utf-8?B?R0pwcituRERZZUFoTDhObGhlNUhldnVRb05HN3lJbXBZVWlmRlU1NUhjYk4x?= =?utf-8?B?bkd6bTQ2b2Rqa0x3bHlETlRiUFkvaTByS0ZjeXBHam81VVFvQzZIVWMxRzhI?= =?utf-8?B?VEFEWGFJYjA2UEZRbDJGVFVzMGN5UlFPb2VUZGRUK0VqUmlScUtFbU1xbXRu?= =?utf-8?B?YS95RjFOUytlRCtUd0NqQWtsNURGSTdUeXJ4d1JwWEVpWGZMdmFKZ2xpTTBI?= =?utf-8?B?VHh4Q2MvVTFERVo0WU51TlBpUjVMZy9LR0pBNm1XVkN3bk55cDFOeWFveEtJ?= =?utf-8?B?SWZkc1BuZ1poWlZrN1lmQ1RRdkFBdFY5QUZjZXprTFk1VVVEUEwrSlUxWkZq?= =?utf-8?B?blJyVlBIR0libnRnNWxXNHFBeFkwWkRoWm1BeE5vTnIvUjNoclhDQUgxdWs2?= =?utf-8?B?WnJnc0xLK1lCZHpxWVhBaCtXb01yS3M5UUpnK1Q2amJDOG41NDdiejhZa3ZJ?= =?utf-8?B?RXd0WktWSzUyS0tTbW1rK1ZaOGc2RmFpY2dCUFRxZGRlN0NFMDUxRXlIMUNT?= =?utf-8?B?UnR3cnV6UE1XTE9NWVhHNkt3UGRENTRmVWlsSnFZYy9YNHhIN0tsSk1qQ21L?= =?utf-8?B?SC9IVElkSjdJR05pMFZ0Y3pndERRZitERWhRRzRIYStuME9UZW1ubEpzRXVC?= =?utf-8?B?elh5RDJuZnVFRm1kOERud3c0VzNGWXhrMU5LZHBwQnViMEszZjRiNm5sbXdI?= =?utf-8?B?emp5dWU0OXNSMEVBVXJZL2JnNWw3Zlh2SXlBOFB0c1Rrc09xcGs0WkhHRW9U?= =?utf-8?B?OWZxUWduc1YyTDRZOWVIb2VVN0ZwbWdBdElTcW5obWJXWkJ3M25yM2dxcDBl?= =?utf-8?B?dE5rRlhWRkk5OFZVbDRNeWRtUzZ2WmFnZlJHNjBIL1dzSGZaK2ZWQld3OVow?= =?utf-8?B?M01pY2Vubi9waFY0ZmVmUXpmc2dpVkdFQXhvK09NZHN4MzE3Yk9Rckdpc3lV?= =?utf-8?B?b2RSM09QZTRqVzFpR0s0YWhacmI4QTFLcGtLN2F5endjdzg5dGJpQk43VEFY?= =?utf-8?B?UW1GTWVYcUE1OHBoRmlwRWZSejMraUxISWNTaEIzdXJlZHJzT0FHMTZOUEl3?= =?utf-8?B?bXBWbGZWZXZtQXpQdlkycTNhSWlMeEF0N1YreDFSVTE3VVZnZFNXNzQxYXVu?= =?utf-8?B?NkdCZ2QyS2lGTjhaaXRtMlRIZVVnc015bG52Tzc0cHdwYXV3d0xmV0tCSm5v?= =?utf-8?B?RWgyb2NHdmtDYkZ2dHZpZFphWWhwSC9BUmNtbVFyNmZPT2gvNnpmTjBzbzdP?= =?utf-8?B?M0JqblkvVU9HMzExM1hFRzliOHlXK3Ftak1QN2NRZ1FFN3AzZlRYTHlzS1I5?= =?utf-8?B?RlBWTlVXbDc4ZFRTeUZ6UnhEOXhGeENFOFRHMTBjZVdnQTdHeXgzTmM3VTA0?= =?utf-8?B?MU0rWTR5aXdMYmduYnEzd3dac3hBSVEzNDIzaGkvZ3JseGQ4aXVpMlQwVUFX?= =?utf-8?B?cEdneXExR1ZJYkx5WXUxSURLR3BtWnNmemZuRUlFTlBTNy81WUxNSnlYVWlE?= =?utf-8?B?TkJyekcvemF4K3BRQ3RnUlFXcm5iR09NNTBqWjZ3WkY5RkRVWHppbWFpTDkw?= =?utf-8?B?ekVHazB4SWxsU1NYNUhnQnh0blpOTTVLdFZEZlVhZnpIT3RlNUphNldLL3Ew?= =?utf-8?B?M04rcWIvRjFqZ2w1NUJLbERVUldjc3RIZitxZktRQzVpdzdoTkFHc0pWT1Ar?= =?utf-8?B?aWJkTmE1bTFBS1g3akdjMkhDeDNCbTN1UUhNZlA5QmZqUmxkTjRjTUhtbHhJ?= =?utf-8?B?WlBJL1ZZeTRtK2ExNmhaOXh6c3o2VEhXL3Q0NHJkZUxKc0dCRXFQdGg3bE1y?= =?utf-8?B?RXJBOW1hbUhZbFZJWHNhbHBySFpxbUdwNnh6TE9TaS9yUWxPNFZadHNTTFVY?= =?utf-8?B?MHdwZmJ6dUJGc053Ylk4U0V5ai9idlNqWFdwVjkxMzRZeGhZUWEyaExBMENi?= =?utf-8?B?WWs0SXJjckFpbkp0OVYrKy9HVW1JQTJnS2t3VW5TSmZlT1hESUc1WVZnRng1?= =?utf-8?B?R3orV1U2Q3NIMGppbkpOZSs4ZElmZlBxQUdzN2lYRm9sczVDOGlWWXBOazRW?= =?utf-8?B?UDB4QjJ4QUt1UjcrYmJ4dWw3eVVadS9ZTkQ5b3o4NkJSeDRuSnduaDFqdzBx?= =?utf-8?B?TFZJbk9kTVcwV2NTSmI5OHo0aFByS09ER0dkMTJJSHMxYjdhbElFTDdHaTRH?= =?utf-8?B?Y2NhaHpCbUFUNkVxRmxCVVo4Q0t4OHNsR2lmNlNIWjIwNzBEemozSm5LQWxV?= =?utf-8?B?bVhUcHN5WU54dVo4Yk1RK2s1QUp1clBmRjU4YnRjelBjUlZHaS9yS3JvRXBG?= =?utf-8?Q?DGEcbYvxHZGxPH+w=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 9e181ca4-153c-43ea-8046-08da283c4796 X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5872.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 10:54:19.3040 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: B3MuWxa+2iyuVu4iDtPbl+FxYyhXo9N1fraD9lqhyxMxGWvE8/34jyoK+MeB5BKlApzKDU7TQoI1iTUvgWLVzQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4447 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 24/04/2022 07:07, Chengwen Feng wrote: > The Tx drop statistic was designed to collected by > rte_eth_dev_tx_buffer mechanism, but the application uses > rte_eth_tx_burst to send packets and this lead the Tx drop statistic > was not collected. > > This patch removes rte_eth_dev_tx_buffer mechanism to fix the problem. > > Fixes: 632bcd9b5d4f ("examples/ioat: print statistics") > Cc: stable@dpdk.org > > Signed-off-by: Chengwen Feng > Acked-by: Bruce Richardson > --- > examples/dma/dmafwd.c | 27 +++++---------------------- > 1 file changed, 5 insertions(+), 22 deletions(-) > Acked-by: Kevin Laatz