From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0040.outbound.protection.outlook.com [104.47.2.40]) by dpdk.org (Postfix) with ESMTP id 884991BB2A; Thu, 21 Jun 2018 09:59:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=retZ/Zszi/NN3+RjVhharws2k7g1LaxmizkwNTEWrXY=; b=MdQdVLD1t+/7XTRNtA7Whe8C+LVbiFV/ok243ZqJx+63ZGoS+2UBkjLjkTrgC8umi2aoNpJZ4NkQBTaF5YWFAKr91a6BjrTruy+fYQWfJVJVr8mJunG/9afxrsu9rvZraWN4JLmPmfzz2NFD6ERVakGprFZYlNDKizrSAB+kRN0= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; Received: from [10.232.14.39] (14.142.187.166) by VI1PR0402MB2783.eurprd04.prod.outlook.com (2603:10a6:800:ad::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.884.20; Thu, 21 Jun 2018 07:59:14 +0000 To: Thomas Monjalon Cc: dev@dpdk.org, stable@dpdk.org, geoff.thorpe@nxp.com, hemant.agrawal@nxp.com, shreyansh.jain@nxp.com, Jerin Jacob References: <20180620140930.31002-1-thomas@monjalon.net> From: Shreyansh Jain Message-ID: Date: Thu, 21 Jun 2018 13:28:54 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180620140930.31002-1-thomas@monjalon.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: BM1PR0101CA0058.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:19::20) To VI1PR0402MB2783.eurprd04.prod.outlook.com (2603:10a6:800:ad::13) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 210dc105-aad7-4c07-af17-08d5d74ce296 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(5600026)(711020)(48565401081)(2017052603328)(7153060)(7193020); SRVR:VI1PR0402MB2783; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0402MB2783; 3:Hgtz9LTObFik3ECJwnJE9ebVtO9CJr0et27PxMRMQN+Q60UYH8xNR/WFwZwSEiblm6MAQZXo9YtB8yKkg0rYmwvyVRZEbIAAabL+LriR21bmPK0BsCB2TllGEOdd/K0J7oNVWTkro/SAUwqGA1RF9CO0L1u+H1yrjjGLpe5jaH7KAthKuHDBIXZeXiqmH1YEM6RY1zLtlPHYqAsFrpEznDUk0vbwNnVn8MQgo1aiSfK1fdCtY1I7ONUwuAkoExKh; 25:nKwQlxHOPuR0AoopM5zxcKkprS0yWSn++/68K0z07Y8EyTWQfP2oJY7W6xhQTyFqt9TjudnohQqiA8FsoQNRSTXodT+s4Kh/CTNojUi04Nrq1p7Ks1nlkgaTnpW3igKimP3Dqwc021/jjz9m3CjIUW33jr4REUKrHoWBOqr7VYT0sR01W+KgsUIWVDQuXTuTQjO8qaWuGBcnQyDH7zoPZKuHvDkdUiqsbLnIkxpnwAmfa4iyRn9n8NN5qiPx1uwBNdjG/FQ/w3ex7fLuCb2ir0yT2YKmrxmucMDgTVKOi2B53KxGksuBXfSdeBqbLR+LcEyJdwy6ofAKN4RxN22+jQ==; 31:W6kMOZ03G26ARA5ZTEpWmQblWRmDw8Q0xCIOyrugGOa+YC5KLaGm8ad7+ddzx4gAwvWa5W0v1wq8BNL1u3KaBz+mNhXEBOiVs+H6zMe5h68x5eKtj9oi6kWlh9QVlK/iGU9kSLg5T7HeeTbvd4LF8cj/bSKB2Kkb4tlxc0qw6xKAojvl8K8Kxb+g8gXMoK4i4wWH0AG+LIK+YiRcjFZ3Jbj9+rLiV3PE8ZBXw98pr0M= X-MS-TrafficTypeDiagnostic: VI1PR0402MB2783: X-Microsoft-Exchange-Diagnostics: 1; VI1PR0402MB2783; 20:vRPrNfMe1oRNKuiMJtY2bkLhV4IpKAOW4MDSSFnEPtgVKv6pMZmNR6zQ7Wh95Law8s++rHF+B+1p0GqPIAERO17aY5GUyDNk4PLdKl5RUGpUY6PUMGPMkXyigpkHV1h1c51Fwb0qPWp/xIt3wRUfdjrvbgPz/np85SgYd0b9ZQ3ZjQ0W3XWZOB4pr/vOLwkL5UXrdWgze/GY/P/EL7D759k/8+7/Hg0A2VU4rGZUsev64bSn+4VZV7NvB9yLy/VpPBW5QtwwZ4tPB2rKkhoEooNVNpyff9pH+73v02P+KRSN+STI94rdmS42+lUJpShhr2OQYlTzBx/jDR4DaYq72DI0i/cXgHWx/bunZ+p/HPKEOSTYBr3F+2KLp17zKGWGvkcqo1VCuBwSYnyNTmeMTElK67vWuZ3rcBlei5XoIZxykYRteEhevl3lFKN4aIC/atSBFAKIbGHXJYWuOwGw6+XXAXiun6brm3JF/qhwCtR4Y+HoSnpF0zguZYD0XZmV; 4:eweszgviwVkWtUDzK1n4MP7DonH13WtHkZbmCuA/BGQFuTOusgjyCkZFZ6hvHFsztkUtxOw+9u/X0PZp9eSN1RnRzvazIe9/+5+ACTrT4AFqg7lnA4VGP9NY6wwicd94DE0TR0NO/scJz5fKJoEBz+gPWPkYtkHLznuJdNntOhHrqYLJzUmsNhohPWUouReykrFHTg6iMnT5VIg4FW7HElUx/KH10IBEQdwbmRmNl2onbpnZsOjDN/xH2ybr8BJvaLfUkqysEDeCcCkSRfeUhEBgXjQ01xJ0B3ytj4uZw6Vh174yr/0XxgaTm10+FmcY X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231254)(944501410)(52105095)(3002001)(10201501046)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123558120)(20161123564045)(6072148)(201708071742011)(7699016); SRVR:VI1PR0402MB2783; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0402MB2783; X-Forefront-PRVS: 07106EF9B9 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(396003)(39860400002)(39380400002)(376002)(346002)(366004)(199004)(189003)(16576012)(64126003)(31696002)(3846002)(230700001)(6116002)(966005)(36756003)(50466002)(5009440100003)(305945005)(58126008)(67846002)(7736002)(25786009)(4326008)(68736007)(2906002)(8936002)(81156014)(81166006)(8676002)(65806001)(316002)(47776003)(66066001)(65956001)(6246003)(53936002)(478600001)(106356001)(105586002)(31686004)(6916009)(97736004)(6666003)(229853002)(386003)(16526019)(186003)(65826007)(446003)(26005)(44832011)(23676004)(2616005)(55236004)(77096007)(476003)(52146003)(76176011)(2486003)(52116002)(5660300001)(86362001)(956004)(486006)(11346002)(6486002)(6306002)(110426005); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0402MB2783; H:[10.232.14.39]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtWSTFQUjA0MDJNQjI3ODM7MjM6cHpud2hCWjJkcjJxdWRpbVdDUXhtcmJG?= =?utf-8?B?UktxeU83S3A1akZrWEl2ZjhDcFJhVlVaQnU0eDc5YnpubkQ3T05CdU5xaUFi?= =?utf-8?B?NkpVM3p1bG9FVEtZL3RxdHk3ZGcrL0M0SXJQaWR6czNJZit2UkVxOUFYYlRs?= =?utf-8?B?QzRhbFErTEVudDJvNytKb2RuUlVyRVVJVkxrWW0xd2dwVkRHRHUzRFNwWFQz?= =?utf-8?B?ZnVoUXpnVG56TnpaUXFGeGphaHIrNWQ1cjhNMU9UcERDcUxlY0FkUUFvMGJ5?= =?utf-8?B?L3FBZEIyTThaS1M2WW03Q2thd0czUENUcXIzZEFTQ3dtZDlLWkhKOXNBMEVm?= =?utf-8?B?R1FBNURaL1A1VXJGcmVuY0xPcURmQk9CNUI4S1c0cEFKRlBSQy91L2NaU0JM?= =?utf-8?B?Nkx1QTdzaHZJMXFwdWRKcVZ6U2ZvdlgxdTRJQzRUcitEb2lXL1FBeHF5bXl6?= =?utf-8?B?bTVFbzg3Uk8yamJOTVhhbjJoVHlSVkQ4NTNJT3NIdVQwMStkSGRQMzNTVlhH?= =?utf-8?B?TnFqR1AyMDZjRit1ZmFWVmNPN1FndG4wbEoyazRFdHlUYlY5N0NNUEwxWlM3?= =?utf-8?B?bUVOTmhhME53QWhXUTRZMXI5VzVYWVNEWHlGNG9heWJJQUR6L0V0Qm0xaDhE?= =?utf-8?B?Nmh3R3RndjhIaThSRXVFblE0bWlUSW4xVzErN25zVW5seUpmRUlFbjE1T2lQ?= =?utf-8?B?VmpJaTVyWGdDNHJlR1c5eWFaYzBCRml5QmVwUnhuMittRkJnaGlGSnF2VWlZ?= =?utf-8?B?U2pYSXBFT2FiVlZCRXJZMnM0dHd0NytDVWlMT0lESGJDWCthRlcwSHlCVmxY?= =?utf-8?B?bHVOQkZJM05TSWN6Qnp2YVRuMHdZZVozRmthZWltV2JwWHRRUGx2RTNMYlpk?= =?utf-8?B?czQ2cmw2UkZvV3lCS1Y1SVVqT0ZUdkpuUHFRZzM1VVc3VWlQWjdDNExBRXlY?= =?utf-8?B?WWUxcXdrMnNRSmVURWxCMkptWUpQRHhrWGRnRFlKUnhXempOVFRncnVYZ1Jz?= =?utf-8?B?MlloejhNOEVNazdMd1BKRHJ3UmdSWUl0d1gwcGxPa2tjNVVtV2VzNVlLVTlS?= =?utf-8?B?YlNNS09hc2h2THlxK2wwZmwxK0pvd1AvYklvQ1BJaHdPTkZtZGFBT3VVSndT?= =?utf-8?B?NGpRS0p6amU0ZUdjeEV2SHprLzdLdkREbjFaLzh4b3NJZUhiejNKSFZ1Q2F5?= =?utf-8?B?QldCVXZxbGRTK3FjU3NFZkpqb1dya21tK0Jmc0duUmFicUtmNWNRT0xydWo1?= =?utf-8?B?SGZTWmNac0Y3cU9JZDdFdW1CODEvOVZnRFJPeUhwWGhHYkFyUjlDRHdqVGR0?= =?utf-8?B?U1B4c3JoZHNKU2FUV0NSblZsZDNJOUN2MHFIMlM0WmdhVEY1OXk5ZDVvY3RQ?= =?utf-8?B?VGJjYkNlWkcwUjNXTFlJV3FaZjYvVGFabkRlYTJlV2crL0JoSUlWdVE1NW5u?= =?utf-8?B?NW91TmtCTUlXZmU0bWdZY05xZnFKKzV0V0pacFk0eFBNbzNPMXJEVyt3cFRX?= =?utf-8?B?eXprM0VoQlEvZS9JOHJySFlmOXNRbzY1bExnNDZUeGoyNVp2MzZWc0pxTEZ5?= =?utf-8?B?OUdEaGt0dWp0UTJxN1J6bzZTMnhEdUFQVTBWTTgvdnFDd3gvM2huQSt0dWhm?= =?utf-8?B?eTkzd3ZIVEN2c0JhZ1FxL0RDVVBMaW5ZRnpaNG5QSG1sbW1JMHhIKytpU1Zt?= =?utf-8?B?YjJKdFpwN1gzeWJtNXJtYWs5Nkl1Uk9hY21JSnF1ZU9pWHRkTm12d2k1WEIw?= =?utf-8?B?NURYdllNYUluOERDTmRmQTdxMTh2L2Z1L2lvM2dWT3pVTVZXRlkvU1l2WDkx?= =?utf-8?B?cHFkSldJS1VBK1RwWG1lV3JKSFNPSmxtSlRiQktJRHE2NW93bmxpQU1HbldV?= =?utf-8?B?YlUxQmV5WVZKNkFZUHZ4TXNkVldyTDJZZ2N3elFBOTN6eGp5S2RPQnVMM1JO?= =?utf-8?B?T3BkRnBzeXVBQ29SK1pnaDRtUXcya2JIclNIYkJrR3l3VTVSUSt5aDF2STFV?= =?utf-8?B?ZDNJZEtRdVVwc1dJM205bU9MSGVVWW03SXd3bll0dU12aUtHU096SUdLc0Mz?= =?utf-8?B?Y3ExVXZPc05RWVRRZmV4S2MwNDRWcDc0ZTF0YlNQYmpYNlBwdnp3WUhCUERL?= =?utf-8?B?dStnUT09?= X-Microsoft-Antispam-Message-Info: f2wEh3P7A+4nrel45eBRI8L9y7k4RCGapO5qQq/axGVG+1BXp55Sv+dfyhPHO6Yg7jNh9ssS+HWoLCBwAG2f8TMuGwgYpKXMVF27kOa0hUUYXKHgJa2wWniaBKkna27L8zM75vaz/5sISe2uU5UF3v63uw/Cjf78aseo3uybnrWI58J2hxj1Y2KwvOKSleGiaV4ERjVMWpIqmBDLBorKENcrUzqxBVIqAvNWByh1OVBTZeCUnfTLDkj8LheE6chqtGQvJ63j154wqjV/Tfyi+VarXGZyU9807j7cnfruE2MEIZwXEwZZij9qHCqeyilpL5upII+mUcc1FVlbfR782Q== X-Microsoft-Exchange-Diagnostics: 1; VI1PR0402MB2783; 6:0uiMXOFPbtK4YyN0ARlAWg/PSimEdbQyiCvwq+EOReec3ZxSdXrXdNGYFqPtXg9KUdW0ChYgRAT+0ThrrRQidWATm9geOEsuVF2nBQYZR9/it7G30pJzgA4MFbUTm1a+vrohfH9bFVcEPfgcHNQPMiUE2+03Dj570D21toH0W7x0MomwW8sTilFY5reknYL2RPozqijBksvG1EsXEepmKOdCbKMxFTimXfPpLJFt42eYzI7r2XMZBO/i+w/cLudidnpKEXeASktqgk6edHuwu8e6OeKM1KqrEVKPMhgRj1rFxoAH12ZUeZ3jYWKY1VsiaiijqFmAKR0BplR3ILyK4GOKS2bIgG81b/uD9vOiLd26KsKmdyVHXBtWb3e6NWg6QnPGgnFIF4buEa6SXuETsTBHjbs9xxBmNS+5kYKFgTpcRRdI2bh4dmhuD8+CfS63+0pBl3QpNq2/b91uIqDlsQ==; 5:2eKXDrPK4H6T9dYLq9xTfQoWTNkk9/zKQ2L3lptssgj3OER5S18QgYYFW8K7lZNIPjcI5jFRyHpqdRZR/NXOveeQZ7bn4tGMklrzmoBboPCRXhzzD0BaMPz+royjiRBVSMNkG8sWqppljeyZXCU7lmaTq3lo4y3zK6OmFTnVXKE=; 24:frpjUcYclK/RO7YLMcYJNlRNFSZMC51DULs263FDZaXwf+dvf8d+xlacURGwV7q+4TDQ9a5YQ4YDt1fWOflF9DOCWmgP5cMFIgrilHbBFzI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; VI1PR0402MB2783; 7:FC18e44qGrq9JUwt6rZfE0BCg3LHi6HecYUb/qZeXpzom2WQBBRve1LUH+2S48Ip1xQz5wMYe43+0VzcRIZnL3bOUrEWJQYczIYfSkVaFTB2hdbq3Z+0Fd73EFFlDzkQSdA7rBWUdTjBwdy1oIMgN4qjG+/mSNz0+3BnwBlxDj1wV6rEDd9g1T5tiKWZM0/yiXBkrbClbn1fIVdV4rgYyuYRbkU9JuVk1dbH55mspEUIIFDktDLMNdTd9FZAIfIP X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2018 07:59:14.7923 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 210dc105-aad7-4c07-af17-08d5d74ce296 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2783 Subject: Re: [dpdk-dev] [PATCH] bus/dpaa: fix build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jun 2018 07:59:17 -0000 On Wednesday 20 June 2018 07:39 PM, Thomas Monjalon wrote: > The DPAA bus driver is defining some macros without prefix. > So it can conflict with other libraries like libbsd: > > drivers/bus/dpaa/include/compat.h:53: > error: "__packed" redefined > /usr/include/bsd/sys/cdefs.h:120: > note: this is the location of the previous definition > > Fixes: 39f373cf015a ("bus/dpaa: add compatibility and helper macros") > Cc: stable@dpdk.org > Cc: geoff.thorpe@nxp.com > Cc: hemant.agrawal@nxp.com > Cc: shreyansh.jain@nxp.com > > Signed-off-by: Thomas Monjalon > --- > drivers/bus/dpaa/include/compat.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/bus/dpaa/include/compat.h b/drivers/bus/dpaa/include/compat.h > index e4b570214..92241d231 100644 > --- a/drivers/bus/dpaa/include/compat.h > +++ b/drivers/bus/dpaa/include/compat.h > @@ -48,9 +48,15 @@ > */ > > /* Required compiler attributes */ > +#ifndef __maybe_unused > #define __maybe_unused __rte_unused > +#endif > +#ifndef __always_unused > #define __always_unused __rte_unused > +#endif > +#ifndef __packed > #define __packed __rte_packed > +#endif > #define noinline __attribute__((noinline)) > > #define L1_CACHE_BYTES 64 > A similar patch was also issued by Jerin a few weeks back: http://patches.dpdk.org/patch/40597/ There may be conflict while merging. Whether you take that, or this (preferred): Acked-by: Shreyansh Jain