From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
Francesco Mancino <francesco.mancino@tutus.se>
Cc: dev@dpdk.org
Subject: Re: [PATCH v7] net/tap: Allow jumbo frames
Date: Thu, 19 Jan 2023 14:50:33 +0000 [thread overview]
Message-ID: <c8cf2559-a5e1-6d68-076f-5f202abe5ee2@amd.com> (raw)
In-Reply-To: <20220808080323.53f303fe@hermes.local>
On 8/8/2022 4:03 PM, Stephen Hemminger wrote:
> On Mon, 8 Aug 2022 16:49:44 +0200
> Francesco Mancino <francesco.mancino@tutus.se> wrote:
>
>> eth_dev_validate_mtu, introduced in 990912e676e, validates configured
>> MTU plus overhead against max_rx_pktlen.
>> Since TAP is a virtual device, it should support as big MTU as possible.
>>
>> Signed-off-by: Francesco Mancino <francesco.mancino@tutus.se>
> dev_info->min_rx_bufsize = 0;
>
>
> Thanks for your patience.
>
> Since tap is built on top of an existing kernel network device a more
> complete solution would be to query the kernel device to find out what
> its MTU is.
>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
+1 to get as it is for now, but if you have a chance, please send
'IFLA_MAX_MTU' implementation to replace current one, thanks.
Applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2023-01-19 14:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-08 9:31 [PATCH] " Francesco Mancino
2022-08-08 14:41 ` Stephen Hemminger
2022-08-08 14:49 ` [PATCH v7] " Francesco Mancino
2022-08-08 15:03 ` Stephen Hemminger
2022-08-08 15:38 ` Francesco Mancino
2022-08-08 16:42 ` Stephen Hemminger
2022-08-09 7:57 ` Francesco Mancino
2023-01-19 14:50 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8cf2559-a5e1-6d68-076f-5f202abe5ee2@amd.com \
--to=ferruh.yigit@amd.com \
--cc=dev@dpdk.org \
--cc=francesco.mancino@tutus.se \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).