From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Matan Azrad <matan@mellanox.com>,
Slava Ovsiienko <viacheslavo@mellanox.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Raslan Darawsheh <rasland@mellanox.com>,
Thomas Monjalon <thomas@monjalon.net>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix last completed built descriptor
Date: Fri, 21 Feb 2020 09:42:16 +0000 [thread overview]
Message-ID: <c8e3d557-fc93-f147-675f-999da48b67fe@intel.com> (raw)
In-Reply-To: <AM0PR0502MB40190EE6BD0D5869B127B51AD2120@AM0PR0502MB4019.eurprd05.prod.outlook.com>
On 2/21/2020 8:25 AM, Matan Azrad wrote:
> From: Viacheslav Ovsiienko
>> Sent: Thursday, February 20, 2020 11:18 PM
>> To: dev@dpdk.org
>> Cc: Matan Azrad <matan@mellanox.com>; Raslan Darawsheh
>> <rasland@mellanox.com>; Thomas Monjalon <thomas@monjalon.net>;
>> ferruh.yigit@intel.com; stable@dpdk.org
>> Subject: [PATCH] net/mlx5: fix last completed built descriptor
>>
>> The routine sending packets with Multi-Packet Write method assigns the
>> wqe_last variable with transmit descriptor (WQE - work queue entry) being
>> built. If send queue is close to full state, the WQE has no data yet (trying to
>> put the first packet) and there is no enough space in descriptor for the next
>> packet the WQE is discarded and the stored wqe_last value becomes invalid -
>> points to the discarded WQE.
>>
>> The mlx5_tx_burst_request_completion() routine might set the completion
>> request flags in the WQE pointed by wqe_last, it is safe, but the next
>> mlx5_tx_burst call uses the WQE as the first free one and request
>> completion flags might be overwritten and completion request will be lost
>> causing the transmit datapath malfunction.
>>
>> Fixes: 8b581c690a54 ("net/mlx5: move Tx complete request routine")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> Acked-by: Matan Azrad <matan@mellanox.com>
>
Applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2020-02-21 9:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 21:17 Viacheslav Ovsiienko
2020-02-21 8:25 ` Matan Azrad
2020-02-21 9:42 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8e3d557-fc93-f147-675f-999da48b67fe@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=rasland@mellanox.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=viacheslavo@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).