From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0210742643; Tue, 26 Sep 2023 15:09:17 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E47F6402F2; Tue, 26 Sep 2023 15:09:16 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2050.outbound.protection.outlook.com [40.107.237.50]) by mails.dpdk.org (Postfix) with ESMTP id C963440279 for ; Tue, 26 Sep 2023 15:09:15 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EztjmiHICsLOrw3m3zWZJJiYb4wnhLEsmoczCalXhDcVst8QPjStyFv522wsNk4PxDU0GveiMkHPQoOwwN8MddD58+yPtLKwXEnDZLRDDBWK6gg3kVIiZksPLhF+y9zQkZf3SAO4aeHmVFdBFMUHvcsMnxcvR+IZyPSIpx0BHAxvDdlu++5ExG0XrDsgTj5wSXJ5rsTi79TpxNr5t6Z70jRNwHw7GJnM3fL7iwR/8dY9RVzk+criLOvwMNxUzTHLStAUsqEBoODzW6UVHQgHBM85bSZjd1y/wPxJ/dWDaHPlGbhMMDMewzGtCEXEAz7Mv7Xls2NPAWEaRtqUnzkrpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tTEcXOPlczDdXusP9ibzMntYfnXzjja23Ly9tfwQyQo=; b=JcSVIciO1ndE30VkNEn9qzbiM7KQd/LyDL4UCY9FoTwjtDepBh490RpNrUcOHls/ZVq3uOaSIBJUBdILWnfVRGzqCZ+obKSwyNglFwc4s1/gLYgU4crwwhZxQQnYfVCXZsrK61E+69fTr3QxKGE8i50NEzkexG9hyH1qcnuVibr0zEUB4RioGNq9lQJJcB2GqBV7zX8vo4RgAjo9UMzZMIaHuzfatEhXB58liFPsRAULY98g41nLyySdAWsF98hRck1unjJ18TFqBVsyncenndfeIUraPkBKzNqdrwiLm2XqLtzDbKLq6dyNK1NyIVuB1/w0nbz6OXUqu6rT+7y4IA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tTEcXOPlczDdXusP9ibzMntYfnXzjja23Ly9tfwQyQo=; b=JolozWdojVmWRyHx26DcC7HlXmr9wDWIg70qmSIqJoLHUhrINxx84mShRTImPBkWqEiEVbuE5AKWIMHvmCP0Mj9lk4q2+dwVIHiR34C3QOWeIyHUKXFwlhqnYJBW2Zf9vwfXnSOFEJv8+fhNeP2sJj9nAjP8BeQIdVydXDMVwUg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DS0PR12MB7680.namprd12.prod.outlook.com (2603:10b6:8:11c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.28; Tue, 26 Sep 2023 13:09:14 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8%4]) with mapi id 15.20.6813.027; Tue, 26 Sep 2023 13:09:14 +0000 Message-ID: Date: Tue, 26 Sep 2023 14:09:13 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 19/32] net/sssnic: support dev start and stop Content-Language: en-US To: wanry@3snic.com, dev@dpdk.org Cc: Steven Song References: <20230904045658.238185-1-wanry@3snic.com> <20230904045658.238185-20-wanry@3snic.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJjb9DJBQkC+3/YAAoJEFRTPtCK Km/6d94P/irGq3mPa7LamXMIioQ8i6ppMSjpr8g+SxH9RnzbmoUjUY6hVzCpXYxEejiJHubg 7lwD+bOocYpiU8Pe0UncVBhIPNk/dIWQAyH0IWK1nd+hOnjxHv3AQpP80Be2o1mUn3oq/b+B QYiyvvre2gIugYq0hzLcG7z4zREeT+Nl0DMDfnLx+Tj2FAOHrOfudUqjdr/VjF5PoTK0bxnb Brqulp0I0ft7hNsufhzf+TlqaB5l0eQO4gDo5xGTP97TT1cGYsXVMsyDhHqW6P3cuj8kkLkO Ch4oq8OLL8GElgRy5y5svU6CJu3f8hT9aiqIoaRpfNv6N8iEk6g4/HNN+uydb9YCA+1pbwBx skmDhtxQrmXpI+Fmfq0aX2NmqHcy6JR8Ekm/nfwLAW/aDpwoMImVN5pPXtOBSjYi4pj7hiJk UA0ZFi8HCW+fic85p8MXn1GPDmbO82Mm3JVJ1uJNAzGsBbW5SP1ol6+XTeaSxcmzFlrDs8vL XQJMRTpcG6Pti7GbbsOtldvmxRQpq9PmCgQg9IrPXpMoaKE3WwtiSiCALs0kYj4F+hhgAfjI RsOuaAJTnKYW31pC/QdroMNAEqIpLveql03jj+xD9ntJIVAsXiCitsLIXzKP0L5tcHkoVLC3 NAjVYq6XkAEssPF4mMRLoEwpvxOytHe1BCJoRl0YA0aQzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmNv0PAFCQL7f/8ACgkQVFM+0Ioqb/oU9hAAisAJJ09j/kiEeA1HGKUg3DyFnYW22zRL z1IHYmcHQanMx4+FAwsb1bonVldQMIYNJ9z69UNIU16zIqLZt3D5QK7Je5F5q4NZgfP2jtjX rc3jyu0PuDerFZQyxNcYhhmlF9JO9NV976WYbBAM3AAr0TDohUk+YicYTKab+ZHYOABXbqHX qi+bzDCH1vKBDfpJviprthhK1tIABUK5lsp9aFwFU2jfu2J3XX3pwQhPMjtn2C4v37XUnOqM SJPr2HLU27IW5I3BBpJn7dZE/BkmDmnceHF8E4tRlXCQ/cf81+eErL832sfhVJo1MpubKh3B j89ZLmw0cDXZP2hqlC9vdXnoWWHI8PDPkiw9z11yLrT9Wd4cTJTjFV49Z9G96rgnOtWDcZ1J xHBAnXYQ7V2k9abY+ZqY1PtAPr/smqzQfPHXyTAhRVZp2f3yQmj7UqB07FJuLQjJ4CGk97Qx ///qeSg7D8x/sGEA8Yp2jgIj6u7tspuz+RgBYrWpfI0VIHhWED0jNXzqztrVX18CzA6r0ReY SG+CSyycKkco6UI9ZeUrXFwnoUJqIJY9wTJo5gD9EgGIbItv3qWTq29dihLYpzd6dqB708k7 4RBz9051oLaFVGkguFw/tXmA17nx+c2uR5jx8wb4j68umG2X++0dSta5eHAVhmtXvrqPW6Ku 3FQ= In-Reply-To: <20230904045658.238185-20-wanry@3snic.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0489.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13a::14) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DS0PR12MB7680:EE_ X-MS-Office365-Filtering-Correlation-Id: 0c8497dd-1e8f-47aa-5b68-08dbbe91c80b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: leICxWD4Noeirrpj5n0IRW0EBPoUa+wV1ZAHrZlx6n2rs1BD8bB2nsTTRMM0xXTPSFRQcEa7Ipsd+okUNgG/mrfq9PBn+HLXvDmpNyfxZEOkX+VqnJwJfE0/K5qazXvmRfXVxS6vXxJQdKliWMcMO8CSNZGcz7Zarx516VUi1qULKOIGBpzCPIE8qetN/YTIB7v+rXoGXJhhrxsSEVnL+8zsUgam2Jx7tbHdVs7dhM1+UItoncTtfpdl2sj1/ybXY101mgf52p8chDoeXg3Yi2JeFQfZisF+1OeTia0vf02QhV+esJIWqmOxRa6f2Th468k3xePcrVO6sb7MwPBGHFGiNbxMTmUe4DZBai7YesP6MQaYJif3roi4FFOX22rlkU7xHl2617q3+N/dBnSHpBZnI7o47u+rm0i0QSz6IFl/s4w3KIHvrrHbgbZ4NKlfh4thE09tYDv4hSD7tK6pzjgHgtNLi3uEPgDXyX+D1Ozl6LIRE6/MDsuw8pVgx1AIGGinzmE2sNaZ6nIt/wj+3ycDXzeIZXDZxHd9V/rl8RpefF2FrvL0lGds7UfB4aFERvHpAN3xcIlg81jYeWzh8xxDlpCSFNT9a/7J/y9UwZaLdgsmOULjuYFQ430vlbMFC1ldQzgciD2a+TNLt0hrww== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(376002)(39860400002)(396003)(366004)(346002)(230922051799003)(1800799009)(186009)(451199024)(2906002)(53546011)(6512007)(6506007)(6486002)(2616005)(38100700002)(66556008)(66476007)(31696002)(86362001)(478600001)(26005)(4744005)(36756003)(44832011)(5660300002)(41300700001)(316002)(8676002)(4326008)(8936002)(66946007)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QWF5ZmpMVGRJK3NYTjVldzByRXdPdm1oeHRZZ0tNd0dxZzhncnY0WHhPODBZ?= =?utf-8?B?YTNrUy9QSE9nZHNNODJWdjFKNWR4a2pCRzZYeU1ubnpVRDZ3dkNrQzBXU0My?= =?utf-8?B?VStYRFhVNnpXeSt2cjFDZTZqYU5SY1JjWlIxRXp3UlpPZTljUE83OUVFVDZw?= =?utf-8?B?ZmEvZlZoZEZ2OXlubktvK3MwelVWTVpoZ2pKWTI4THE5U1IxWmkrb0l3K1hi?= =?utf-8?B?c21OSWJzeC96dFJYaGUrQUdrd0RqdmVDVmNEanRSSGU0TkpCYjdWZ1pZekZy?= =?utf-8?B?V05pZCtKNHc5V1VHTHJwQWF3WG1LZldqNm1PZVZLWit2NEJ5V2U0Y09PWXJt?= =?utf-8?B?RnhiUHpLNmhmclAzb01nL2ZSNjZ3RzBPU1hJd3JqdFFYS0ZTYk42T050d0hm?= =?utf-8?B?WkZBQzR5TmRjMjhpL0Q1eXVNSzZwRWpEYmZ2WmxqTTYwdytFbXd3d0pFMDZS?= =?utf-8?B?bm15MUZUNWt4aGdVVjJqWnMzNkxwWURrUVJ2Qy9rSFRaZlY5dXh4UTBvL0Uw?= =?utf-8?B?SnBwcERlMzBpMTlGTEFmWTlxU2xBcHV2WGZKZDJwNnVHV1NoVE5MeE9oRWQr?= =?utf-8?B?WDJibTBuaDRhK1BucDFOSUExOG1VVFNTeVJtTk03cVFZM0VldWljbEpEdzc5?= =?utf-8?B?NW9iTFZnRG8rYXAzN3JRL0ZTM3FMUnlYMTUrRDhlR0NUVkVnTUswUUlhTjU2?= =?utf-8?B?aXg5aU8yQ0xMejF5cFlVVldrSkNncmVKUzBWczFLYldZTDNJdk1aT0xKY0RT?= =?utf-8?B?MjY5RXA4dUMxVGZvdG1lTkNoMFFWNkhqMlRGVjA1ZFVoZ2dsWndhdUlWRFd5?= =?utf-8?B?Sm9uMjVGVnFIZHI2a3dzTUtISlJkT2F6SzlhYnVmalZTUFYwZnZtMXBjeVUz?= =?utf-8?B?MUJQYlVMNzVDbEowaHJ1eGpjazNqZTU1enhzaG9NU0hKYTFSL0E2dWJpcDY0?= =?utf-8?B?c0dXeUJtemlLb2lHMGtoZ0E0QmV3TVN5bk5CZUFNdGhpaVF5M1F3dHNWMXIr?= =?utf-8?B?eDluZ2hYZ2ppaHZLSnBZS3FzTElVSnd6dnA1ZTJOMkNPVCtHRUk2U0MxRTJW?= =?utf-8?B?NkJ0VlBWSUVwVG5oUy9FT0EwUVZGaHJDYWkyWUkzbVZhSDdLRDBCTEZjTWor?= =?utf-8?B?Zm93cHUra3J0T3RsTEpscVB6czN0OWNWK2d4WlVXT3FsN1NabTdRMVU3cUJs?= =?utf-8?B?MTRvQkVIYzB2cGp5TUhvUjZScFlrMFp4R2NIcmlQOEtJYVM3R1VXSW15TU54?= =?utf-8?B?anExcTRLVENrZ1dMQjh5MzdITk5NbFdZTnc2TmdGS0pPZHB2Vm1peXJiZk1W?= =?utf-8?B?Z2ljNlRidWtnQXBOSHQwd2h4WjVNYXAxVFpZT1JZbEFLY3o0WDc2cVpKNDFn?= =?utf-8?B?WW1zaG5CbGxRZUEyalEzUkZCZ3BRdUxNdE12TGliekY4NzRnajN0TXhYRjMy?= =?utf-8?B?dmFpclN6RkZGc29taTAxemhqQ3FoTFdzSGZGTzRqUFozU1BnUFdLVjFxUUJn?= =?utf-8?B?KzF4NDRwd3RkR2VCS1lMNitQRnQ4SjYzOGFTUys4eG9YSDBpWGdNdFhSRFBa?= =?utf-8?B?aGZURC9ldGp5NGs1cTFYdVN4dnFVV3RtSlpTSDNSTTFRaUF3M05JcnpCaVFN?= =?utf-8?B?UkM3RnRWK1YydCsrSFVoenZWN2ZBS0RTV3pxdDlCYlRDbzBXMzZNMGZ5NGZJ?= =?utf-8?B?eWRsZUdMdyt6N0hQL2RGcjR2Y1BlZ1BDcXRkRTZLL2loWXdJTkNPSmhVZU15?= =?utf-8?B?WUFweVp1eE9ueXJjSmgxRC9VRVVvVHIvbzFXTmFmc3pUUzQ1bW5ZZmF4bElW?= =?utf-8?B?NktKRUd6Z21NVSticzhWZFRkTXVSVjhjZWw1akdqaUFxTnh3eW1qZ1lWSFZS?= =?utf-8?B?azFGQ0J3QTlRcEt0RW14QnZGUEwxd1FOMlBpTUJack8rdGs3SXVobjQ4NGpt?= =?utf-8?B?TlFLSjE0dHNMbzFTQ1JOVjRZNlRiRUNMeDJ2M0IvSExVL1ludFNzU0dJZG5H?= =?utf-8?B?N2pocTJraXJwQTdBSjE0b3A2UWJNbG9mVTJ6Qit1RGhsWVlkb3NROHJZZ3Vt?= =?utf-8?B?Vi9Hb1c0WUNESnJjakhtbWZNd2t6NThUV0k1V0dsSjBjbVY4VjJwZDRRbTFK?= =?utf-8?Q?APRsOI/T/GieuyScqVi4Tk99p?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0c8497dd-1e8f-47aa-5b68-08dbbe91c80b X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2023 13:09:14.0769 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NlEHcdGXwQgfxWAdLC4F+oaSE/vdPw1zGZEeSYkgrjGKknc0BT16gPAqhjPVpxhn X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7680 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/4/2023 5:56 AM, wanry@3snic.com wrote: > From: Renyong Wan > > Signed-off-by: Steven Song > Signed-off-by: Renyong Wan > <...> > diff --git a/drivers/net/sssnic/sssnic_ethdev_rx.c b/drivers/net/sssnic/sssnic_ethdev_rx.c > index 9c1b2f20d1..fd4975dfd5 100644 > --- a/drivers/net/sssnic/sssnic_ethdev_rx.c > +++ b/drivers/net/sssnic/sssnic_ethdev_rx.c > @@ -185,7 +185,7 @@ sssnic_ethdev_rxq_doorbell_ring(struct sssnic_ethdev_rxq *rxq, uint16_t pi) > db.qid = rxq->qid; > db.pi_hi = (hw_pi >> 8) & 0xff; > > - db_addr = (uint64_t *)(rxq->doorbell + (hw_pi & 0xff)); > + db_addr = ((uint64_t *)rxq->doorbell) + (hw_pi & 0xff); > Can you please fix this where it is introduced at first place?