From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1A69CA00C5; Mon, 31 Oct 2022 14:43:09 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AD45340223; Mon, 31 Oct 2022 14:43:08 +0100 (CET) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 93FFE40151; Mon, 31 Oct 2022 14:43:07 +0100 (CET) Received: by shelob.oktetlabs.ru (Postfix, from userid 115) id 205C662; Mon, 31 Oct 2022 16:43:07 +0300 (MSK) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mail1.oktetlabs.ru X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=ALL_TRUSTED, DKIM_ADSP_DISCARD, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 Received: from bree.oktetlabs.ru (bree.oktetlabs.ru [192.168.34.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPS id 741825A; Mon, 31 Oct 2022 16:43:06 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 741825A Authentication-Results: shelob.oktetlabs.ru/741825A; dkim=none; dkim-atps=neutral Date: Mon, 31 Oct 2022 16:43:06 +0300 (MSK) From: Ivan Malov To: "Li, WeiyuanX" cc: "dev@dpdk.org" , "stable@dpdk.org" , Andrew Rybchenko , Chas Williams , "Min Hu (Connor)" , Hari Kumar Vemula Subject: Re: meson test link bonding failed//RE: [PATCH] net/bonding: fix descriptor limit reporting In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, Please see https://patches.dpdk.org/project/dpdk/patch/20221031131744.2340150-1-ivan.malov@oktetlabs.ru/ . Thank you. On Mon, 31 Oct 2022, Li, WeiyuanX wrote: > Hi Ivan, > > This patch is merged into dpdk22.11.0rc1 we execute meson test case link_bonding_autotest, link_bonding_rssconf_autotest and link_bonding_mode4_autotest test failed. > Could you please have a look at it, also submitted a Bugzilla ticket: https://bugs.dpdk.org/show_bug.cgi?id=1118 > > Regards, > Li, Weiyuan > >> -----Original Message----- >> From: Ivan Malov >> Sent: Sunday, September 11, 2022 8:19 PM >> To: dev@dpdk.org >> Cc: stable@dpdk.org; Andrew Rybchenko >> ; Chas Williams ; Min >> Hu (Connor) ; Hari Kumar Vemula >> >> Subject: [PATCH] net/bonding: fix descriptor limit reporting >> >> Commit 5be3b40fea60 ("net/bonding: fix values of descriptor limits") breaks >> reporting of "nb_min" and "nb_align" values obtained from back-end >> devices' descriptor limits. This means that work done by >> eth_bond_slave_inherit_desc_lim_first() as well as >> eth_bond_slave_inherit_desc_lim_next() gets dismissed. >> >> Revert the offending commit and use proper workaround for the test case >> mentioned in the said commit. >> >> Meanwhile, the test case itself might be poorly constructed. >> It tries to run a bond with no back-end devices attached, but, according to [1] >> ("Requirements / Limitations"), at least one back-end device must be >> attached. >> >> [1] doc/guides/prog_guide/link_bonding_poll_mode_drv_lib.rst >> >> Fixes: 5be3b40fea60 ("net/bonding: fix values of descriptor limits") >> Cc: stable@dpdk.org >> >> Signed-off-by: Ivan Malov >> Reviewed-by: Andrew Rybchenko >> --- >