DPDK patches and discussions
 help / color / mirror / Atom feed
From: Juraj Linkeš <juraj.linkes@pantheon.tech>
To: Thierry Herbelot <thierry.herbelot@6wind.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: Thomas Monjalon <thomas@monjalon.net>,
	Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,
	Ruifeng Wang <ruifeng.wang@arm.com>
Subject: Re: [dpdk-dev] [PATCH-V2] config/arm: restore support for Qualcomm servers
Date: Thu, 29 Apr 2021 09:16:26 +0000
Message-ID: <c94747bbec624f4d832551ba5b17dc67@pantheon.tech> (raw)
In-Reply-To: <20210429080644.11423-1-thierry.herbelot@6wind.com>



> -----Original Message-----
> From: Thierry Herbelot <thierry.herbelot@6wind.com>
> Sent: Thursday, April 29, 2021 10:07 AM
> To: dev@dpdk.org
> Cc: Thierry Herbelot <thierry.herbelot@6wind.com>; Thomas Monjalon
> <thomas@monjalon.net>; Juraj Linkeš <juraj.linkes@pantheon.tech>; Honnappa
> Nagarahalli <honnappa.nagarahalli@arm.com>; Ruifeng Wang
> <ruifeng.wang@arm.com>
> Subject: [PATCH-V2] config/arm: restore support for Qualcomm servers
> 
> From the documentation:
> "The SoC configuration is a combination of implementer and CPU part number
> configuration and SoC-specific configuration."
> 
> Align Qualcomm SoC configuration with the configuration of other server SoCs
> (eMAG, Kunpeng 9x0): add a soc configuration to the existing implementer
> configuration.
> 
> Fixes: f2340c858046 ("config/arm: add platform config option")
> 

Since this is just adding new soc configuration, I don't think it's actually fixing anything.

> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> --
> V2:
> - use the right original commit in Fixes
> ---
>  config/arm/meson.build | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/config/arm/meson.build b/config/arm/meson.build index
> 22cd81319c06..4518b7e877b3 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -298,6 +298,13 @@ soc_octeontx2 = {
>      'numa': false
>  }
> 
> +soc_qualcomm = {
> +    'description': 'Qualcomm Centriq 2400',
> +    'implementer': '0x51',
> +    'part_number': '0xc00',
> +    'numa': false
> +}
> +
>  soc_stingray = {
>      'description': 'Broadcom Stingray',
>      'implementer': '0x41',
> @@ -334,6 +341,7 @@ socs = {
>      'n1sdp': soc_n1sdp,
>      'n2': soc_n2,
>      'octeontx2': soc_octeontx2,
> +    'qualcomm': soc_qualcomm,

Now that I'm looking at this change, I see that you've added the qualcomm soc here and it's not added to the docs in this patch, but rather the patch which fixes the docs. I think you should move the qualcomm doc addition to this patch (and the other patch would just have the fixes).

>      'stingray': soc_stingray,
>      'thunderx2': soc_thunderx2,
>      'thunderxt88': soc_thunderxt88
> --
> 2.29.2
> 




  reply	other threads:[~2021-04-29  9:16 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-28 16:08 [dpdk-dev] [PATCH] " Thierry Herbelot
2021-04-28 17:47 ` Thomas Monjalon
2021-04-28 18:21   ` Honnappa Nagarahalli
2021-04-28 18:26     ` Thierry Herbelot
2021-04-29  7:09 ` David Marchand
2021-04-29  8:06 ` [dpdk-dev] [PATCH-V2] " Thierry Herbelot
2021-04-29  9:16   ` Juraj Linkeš [this message]
2021-04-29  9:23   ` [dpdk-dev] [PATCH-V3] " Thierry Herbelot
2021-04-29 10:00     ` Juraj Linkeš
2021-04-29 10:07     ` [dpdk-dev] [PATCH-V4] " Thierry Herbelot
2021-04-29 15:03       ` Ruifeng Wang
2021-04-29 15:16       ` [dpdk-dev] [PATCH-V5] " Thierry Herbelot
2021-04-30  6:07         ` Juraj Linkeš
2021-05-06  9:25         ` [dpdk-dev] [PATCH-V6] " Thierry Herbelot
2021-05-07  7:22           ` Ruifeng Wang
2021-05-07  7:43             ` Juraj Linkeš
2021-05-07  8:48           ` [dpdk-dev] [PATCH-V7] config/arm: add Qualcomm Centriq 2400 SoC config Thierry Herbelot
2021-05-13  9:35             ` Ruifeng Wang
2021-05-19 10:09               ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c94747bbec624f4d832551ba5b17dc67@pantheon.tech \
    --to=juraj.linkes@pantheon.tech \
    --cc=dev@dpdk.org \
    --cc=honnappa.nagarahalli@arm.com \
    --cc=ruifeng.wang@arm.com \
    --cc=thierry.herbelot@6wind.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git