From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 251B5A0C53;
	Wed,  3 Nov 2021 14:13:17 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 014F441134;
	Wed,  3 Nov 2021 14:13:17 +0100 (CET)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id E4DFC40E5A
 for <dev@dpdk.org>; Wed,  3 Nov 2021 14:13:15 +0100 (CET)
Received: from [192.168.1.71] (unknown [188.170.78.205])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 483A17F52E;
 Wed,  3 Nov 2021 16:13:15 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 483A17F52E
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1635945195;
 bh=Psxea4eYNjM8+5dILARrfcipDOPBFgQkywcf+JG87yg=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=YCFIUKjyz7jagx+XRGawAxH8oQKrVeO4cHWHwUQfvbj+6I1bFmczSxGv+xMP3J/kO
 4XfGjI7KePwYzhB30iUxvfzKLkkf1E/LFZySl9Sv7boqm56N+6quraP5UqSPS9EWR8
 hl4rzAwz3Lz+AdND4ehdg4iSj4MeSyLWpf2ZIjGU=
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, Ferruh Yigit <ferruh.yigit@intel.com>,
 Viacheslav Galaktionov <viacheslav.galaktionov@oktetlabs.ru>,
 Andy Moreton <amoreton@xilinx.com>
References: <20211021070355.3547582-1-andrew.rybchenko@oktetlabs.ru>
 <20211103124021.251256-1-andrew.rybchenko@oktetlabs.ru>
 <CAJFAV8x0DOhQpEgACyTu_FkNyis571dEqd73CrwL+W0tftOrDQ@mail.gmail.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Message-ID: <c94840be-e0d8-c55c-e5cd-a030cd6982fb@oktetlabs.ru>
Date: Wed, 3 Nov 2021 16:13:09 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <CAJFAV8x0DOhQpEgACyTu_FkNyis571dEqd73CrwL+W0tftOrDQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2] net/sfc: allow control threads for
 counter queue polling
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 11/3/21 4:00 PM, David Marchand wrote:
> On Wed, Nov 3, 2021 at 1:40 PM Andrew Rybchenko
> <andrew.rybchenko@oktetlabs.ru> wrote:
>>
>> From: Viacheslav Galaktionov <viacheslav.galaktionov@oktetlabs.ru>
>>
>> MAE counters can be polled from a control thread if no service core is
>> allocated for this.
>>
>> Signed-off-by: Viacheslav Galaktionov <viacheslav.galaktionov@oktetlabs.ru>
>> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>> Reviewed-by: Andy Moreton <amoreton@xilinx.com>
> 
> 
>> ---
>> The problem to require service cores for HW offload was raised by
>> David on review in 21.08 release cycle.
>>
>> v2:
>>      - add sleep in the case of empty queue to avoid CPU burn
>>      - pair release/acquire for thread run/stop condition
> 
> The release notes update was dropped. Not sure it was intentional.
> Otherwise, patch lgtm, thanks.
> 
> Reviewed-by: David Marchand <david.marchand@redhat.com>


David, many thanks. I'll send v3 shortly with release notes
update restored.