From: Ferruh Yigit <ferruh.yigit@intel.com>
To: David Marchand <david.marchand@redhat.com>, <dev@dpdk.org>
Cc: David Christensen <drc@linux.vnet.ibm.com>,
Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH] config/ppc: fix build with GCC >= 10
Date: Wed, 15 Sep 2021 09:14:34 +0100 [thread overview]
Message-ID: <c96414e7-6398-6ce4-214a-2847184a77ae@intel.com> (raw)
In-Reply-To: <20210915050812.12798-1-david.marchand@redhat.com>
On 9/15/2021 6:08 AM, David Marchand wrote:
> Like for python, multiline statements in meson must either use a
> backslash character (explicit continuation) or be enclosed in ()
> (implicit continuation).
>
> python PEP8 recommends the latter [1], and it looks like meson had
> an issue with backslash before 0.50 [2].
>
> 1: https://www.python.org/dev/peps/pep-0008/#multiline-if-statements
> 2: https://github.com/mesonbuild/meson/commit/90c9b868b20b
>
> Fixes: 394407f50c90 ("config/ppc: ignore GCC 11 psabi warnings")
>
> Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> config/ppc/meson.build | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/config/ppc/meson.build b/config/ppc/meson.build
> index 0b1948fc7c..aa1327a595 100644
> --- a/config/ppc/meson.build
> +++ b/config/ppc/meson.build
> @@ -20,8 +20,8 @@ endif
>
> # Suppress the gcc warning "note: the layout of aggregates containing
> # vectors with 4-byte alignment has changed in GCC 5".
> -if cc.get_id() == 'gcc' and cc.version().version_compare('>=10.0') and
> - cc.version().version_compare('<12.0') and cc.has_argument('-Wno-psabi')
> +if (cc.get_id() == 'gcc' and cc.version().version_compare('>=10.0') and
> + cc.version().version_compare('<12.0') and cc.has_argument('-Wno-psabi'))
> add_project_arguments('-Wno-psabi', language: 'c')
> endif
>
>
Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>
next prev parent reply other threads:[~2021-09-15 8:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 5:08 David Marchand
2021-09-15 8:14 ` Ferruh Yigit [this message]
2021-09-15 9:08 ` Bruce Richardson
2021-09-15 15:10 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c96414e7-6398-6ce4-214a-2847184a77ae@intel.com \
--to=ferruh.yigit@intel.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).