From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CC869A0C41; Thu, 16 Sep 2021 13:34:39 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 512E94069E; Thu, 16 Sep 2021 13:34:39 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id D22104069E for ; Thu, 16 Sep 2021 13:34:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631792077; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C9wRJoK3o7i+u7D+lWATWCRmeAFhOZfX5dlX49UOJEg=; b=bEopDnW+D7RA5lI3TSYBp/KpKWqSPSfQdqsbjkVWieim6wEhICBye23d2kxX6bD6EYn1m0 AjyMr/42gfIg5uhBtxl53FwA5sV1jMRNIOuY9ofkV7+NZi3dMLLsaybpvlpMv2PPIiohAq ekRJHywxPRIIfyY17SZmFQubCpUavYo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-216-MItNrgA3NV-VKWd8wneVKQ-1; Thu, 16 Sep 2021 07:34:36 -0400 X-MC-Unique: MItNrgA3NV-VKWd8wneVKQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F2795100C66E; Thu, 16 Sep 2021 11:34:34 +0000 (UTC) Received: from [10.39.208.33] (unknown [10.39.208.33]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 557A060FDD; Thu, 16 Sep 2021 11:34:25 +0000 (UTC) Message-ID: Date: Thu, 16 Sep 2021 13:34:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 To: Ferruh Yigit , Jiayu Hu , dev@dpdk.org Cc: chenbo.xia@intel.com, david.marchand@redhat.com, Cheng Jiang References: <1629463466-450012-1-git-send-email-jiayu.hu@intel.com> <2bdcfe6a-b3eb-701a-ba5d-ea83cebd6422@intel.com> From: Maxime Coquelin In-Reply-To: <2bdcfe6a-b3eb-701a-ba5d-ea83cebd6422@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] vhost: remove copy threshold for async vhost X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ferruh, On 9/16/21 13:15, Ferruh Yigit wrote: > On 8/20/2021 1:44 PM, Jiayu Hu wrote: >> Copy threshold is introduced in async vhost data path to select >> the appropriate copy engine to do copies for higher efficiency. >> However, it may cause packets out-of-order, and it also causes >> data path performance unpredictable. >> > > Just checking, if the patch is fixing data performance issue, should it be > backported? This is experimental code that is not used in real product for now, and will likely heavily change given OVS rejected this design. So I would personally not bother backporting patches for it. Jiayu, Chenbo, do you think otherwise? Regards, Maxime >> Therefore, this patch removes copy threshold support in async vhost >> data path. >> >> Signed-off-by: Jiayu Hu >> Signed-off-by: Cheng Jiang > <...> > >