From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id E9F4C1B1C5 for ; Wed, 17 Jan 2018 17:56:59 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jan 2018 08:56:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,372,1511856000"; d="scan'208";a="10996977" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.48]) ([10.237.220.48]) by fmsmga007.fm.intel.com with ESMTP; 17 Jan 2018 08:56:58 -0800 To: Kirill Rybalchenko , dev@dpdk.org Cc: andrey.chilikin@intel.com, thomas@monjalon.net References: <1516035500-6010-1-git-send-email-kirill.rybalchenko@intel.com> <1516037612-69603-1-git-send-email-kirill.rybalchenko@intel.com> From: Ferruh Yigit Message-ID: Date: Wed, 17 Jan 2018 16:56:57 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <1516037612-69603-1-git-send-email-kirill.rybalchenko@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3] ethdev: increase flow type limit from 32 to 64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jan 2018 16:57:00 -0000 On 1/15/2018 5:33 PM, Kirill Rybalchenko wrote: > Increase the internal limit for flow types from 32 to 64 > to support future flow type extensions. > Change type of variables from uint32_t[] to uint64_t[]: > rte_eth_fdir_info.flow_types_mask > rte_eth_hash_global_conf.sym_hash_enable_mask > rte_eth_hash_global_conf.valid_bit_mask > > This modification affects the following components: > net/i40e > net/ixgbe > app/testpmd > > v2: > implement versioning of rte_eth_dev_filter_ctrl function > for ABI backward compatibility with version 17.11 and older > > v3: > fix code style warnings > > Signed-off-by: Kirill Rybalchenko Reviewed-by: Ferruh Yigit I suggest keeping deprecation notice and clean versioning in next release, does it make sense?