From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DB28AA0032; Fri, 24 Jun 2022 14:01:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CADAA40A8A; Fri, 24 Jun 2022 14:01:35 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2065.outbound.protection.outlook.com [40.107.94.65]) by mails.dpdk.org (Postfix) with ESMTP id 2DEAD400EF; Fri, 24 Jun 2022 14:01:34 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CgrTPLjTkMa8mh+ooCZldOKdRRi6WatoRYpfEcGsioWd0/Cw0Wuo13paRd/J4BW1uHXp1MqotMn28tzwRMhYSpp7LpwYjrqBV70rQO7tUnGULboD+JM7TdPalQSqDulg+cNIgkXvWW6PnnZVXRxhEnE0T5eH04KPORniFoHjizL47vylWm/I7uwycDXIDVKQ+ZP4eYK9En/1zx0GcgkjIOU/2rYwcrCkxLEIuGHSKrBGfFRugTmdBK28gQY8eO1GD1g7X5mDwOAa11Tdhpvk0UHcwLt5mrBMCCo7kg5WrU8POPzsGlSwldm/+xwCYWoNJ5CW6qZoPf/nYqwjxJbjkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n7UuSqOydl9yjTzu7+7iv6tGo94NYiyAsiu09kQcAsw=; b=E2frSYRAKuDCfrT6eyB2tyl5WCVQ3ey1XG0pZEFmafmGzBH4jPucj4RdLwOKsTyp6Yn3icndGYpVezELFMzq6JZbLAyfQE3SQ/74ki+POYwh1ZxbLOZ2F1ypgkcUhlPdNvMzle5fe4DIY+Y7Bz9IrUBT1aLYgWDhtxqoPRNtbYtvV000lCNqOQtITzmooT3hr1pSt4+AmZTWr6KvhBxfCtEnSxncAcwix0K4x0U0iOMPxTB//RwJSZfaKrSQ/UViCLFxRCHJVRcYuZHXMJgdehw3OtUhPv4fVXVnanYnNRQKlHYp5WtRFXr8/W8mWyyHUk9xodd1TOYB1uNeV50LfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=huawei.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n7UuSqOydl9yjTzu7+7iv6tGo94NYiyAsiu09kQcAsw=; b=f4HTjeDDDKBbUgOpumKrw48uCS5UYHJIRYCIOgcSmbIM752WakYDpdB0R74AmP1A1d5zz/dvoYzW6gVuLXHt1OPRgy8YHC8Dzo02ZVhSGC1dAK0lU20VZfjqGRtD95c/Rv+5Mm4DxYQK1LgDlGzQfkAA9aqofkq/jk5bS5WoIpE= Received: from SN6PR01CA0023.prod.exchangelabs.com (2603:10b6:805:b6::36) by SA2PR02MB7516.namprd02.prod.outlook.com (2603:10b6:806:14e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.17; Fri, 24 Jun 2022 12:01:32 +0000 Received: from SN1NAM02FT0017.eop-nam02.prod.protection.outlook.com (2603:10b6:805:b6:cafe::58) by SN6PR01CA0023.outlook.office365.com (2603:10b6:805:b6::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.15 via Frontend Transport; Fri, 24 Jun 2022 12:01:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com; pr=C Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by SN1NAM02FT0017.mail.protection.outlook.com (10.97.4.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5373.15 via Frontend Transport; Fri, 24 Jun 2022 12:01:31 +0000 Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Fri, 24 Jun 2022 13:01:29 +0100 Received: from smtp.xilinx.com (172.21.105.197) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Fri, 24 Jun 2022 13:01:29 +0100 Envelope-to: liudongdong3@huawei.com, stable@dpdk.org, lihuisong@huawei.com, humin29@huawei.com, yisen.zhuang@huawei.com, oulijun@huawei.com, fengchengwen@huawei.com, dev@dpdk.org Received: from [10.71.119.54] (port=11596) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1o4i09-0006DV-Dn; Fri, 24 Jun 2022 13:01:29 +0100 Message-ID: Date: Fri, 24 Jun 2022 13:01:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 1/2] net/hns3: fix fail to obtain VF LSC capability Content-Language: en-US To: Dongdong Liu CC: , Huisong Li , "Min Hu (Connor)" , Yisen Zhuang , Lijun Ou , Chengwen Feng , References: <20220611074227.30276-1-liudongdong3@huawei.com> <20220611074227.30276-2-liudongdong3@huawei.com> From: Ferruh Yigit In-Reply-To: <20220611074227.30276-2-liudongdong3@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 021303ff-efc0-4eec-c657-08da55d94711 X-MS-TrafficTypeDiagnostic: SA2PR02MB7516:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Z08wBTNY3SvMFwcCKPAMyq1Cv7aiaBUxXsQ5h+sBsYUI260iLXy6qmBzfx4oEKUjXbQfLkfx8J3OdLtrNg/uikQg6qOu+F/prMdFunuXi1ZxFxdeVptc5a7eADFjS05MvKoFQkGZvXKAB6yW/wpoAPoZj/FO5vcJk78LKtY9HbFC0C7XAt6RPxOkD+cfQ2Qsv7ATTb9PjDVR5D0xVe+D91QMFsz+pi6HGKob38ZHZ32uc81cXOFj9qyjNpy4gWziPtkUNBJfZ75uAz22rrPu4cK2rTMkhjigDVID9h3puj8Z2r/o1FvNYPDbuOuFgvxWH9sK/VrJ3AxksYdsNy2MyVR6bx2PDmmGJA8kn7Q2bOZrVK9f/NQO6HfyenEINR/T/rQ92TU9NNLupyHR72N7CFmAfFnecXUB6X+Y/MNVzcq5NkyOfL7m9u4ZIIqGgSPmmCJyaETc6+otBI0yetea2fORcVhVLfEaogy8nO3kF3l7DK3crII+MS/eZe2mZealPNxd7Jm5croMB87/yr85VHXpaRMUuq1ChPPmZw3wr2JROMtquPO29KmYXWVP7Rs2dEvLT80TXx1DH3g8kWwrrQuJrJlHqmvG0kfz/0F6/LigbGDp8QzW4yI+iLj65+Yaj4syKFCyiXGwhQz33ny6FeK/gJvauBxKDic5sS9oEYkSC7GQwFsf11BFp2Mmx4HusIuKuEfVcqySUtsSF7RJGV+MjcIRYque2ooQgsAtWwa66HSQDsVcs687nasB8c1A5WFehikvdME5Xnd/LiY2jTSJ1Yy5943M1L4ZKpUOywAuM9hz5zsmTax2uh0ETugQinUC+im1BiLTO9IzhXNr8eqUFrEh1LAWIgEwRU5Wl3k= X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch01.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230016)(4636009)(346002)(376002)(396003)(136003)(39860400002)(36840700001)(40470700004)(46966006)(53546011)(83380400001)(426003)(31686004)(82310400005)(2906002)(478600001)(36756003)(41300700001)(316002)(26005)(336012)(47076005)(40460700003)(2616005)(36860700001)(6916009)(4326008)(8676002)(7636003)(44832011)(70586007)(70206006)(8936002)(9786002)(186003)(356005)(40480700001)(5660300002)(54906003)(31696002)(82740400003)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jun 2022 12:01:31.2301 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 021303ff-efc0-4eec-c657-08da55d94711 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0017.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR02MB7516 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/11/2022 8:42 AM, Dongdong Liu wrote: > From: Huisong Li > > Currently, the VF LSC capability is obtained from PF driver in > the interrupt mailbox interrupt thread, it is asynchronous. > The VF driver waits for 500ms to get this capability in probe > process. > > The primary process will receive a message and do probe in the > interrupt thread context when attach a device in the secondary > process. At this case, VF driver never obtains this capability > from PF. > > The root cause is that 'vf->pf_push_lsc_cap' is not updated by > the handling mailbox thread until finishing probe. The reason > this update wouldn't be done is that the handling mailbox interrupt > thread and the probe alarm thread are both in epool thread, and > the probe alarm thread is before the mailbox interrupt thread. > > Fixes: 9bc2289fe5ea ("net/hns3: refactor VF LSC event report") > Cc: stable@dpdk.org > > Signed-off-by: Huisong Li > Signed-off-by: Dongdong Liu Applied to dpdk-next-net/main, thanks.