From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id C0C252A6C for ; Thu, 5 Jan 2017 18:01:35 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 05 Jan 2017 09:01:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,322,1477983600"; d="scan'208";a="1108449965" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.38]) ([10.237.220.38]) by fmsmga002.fm.intel.com with ESMTP; 05 Jan 2017 09:01:28 -0800 To: Adrien Mazarguil References: <1481290078-4530-1-git-send-email-nelio.laranjeiro@6wind.com> <2da35386-f774-a1ca-c4f2-cc77f74f6e2c@intel.com> <20170105163226.GP12822@6wind.com> <20170105165223.GQ12822@6wind.com> Cc: Nelio Laranjeiro , dev@dpdk.org From: Ferruh Yigit Message-ID: Date: Thu, 5 Jan 2017 17:01:27 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170105165223.GQ12822@6wind.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix Tx doorbell X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jan 2017 17:01:36 -0000 On 1/5/2017 4:52 PM, Adrien Mazarguil wrote: > On Thu, Jan 05, 2017 at 05:32:26PM +0100, Adrien Mazarguil wrote: >> Hi Ferruh, >> >> On Thu, Jan 05, 2017 at 03:19:35PM +0000, Ferruh Yigit wrote: >>> On 12/9/2016 1:27 PM, Nelio Laranjeiro wrote: >>>> Too much data is uselessly written to the Tx doorbell. >>>> >>>> Fixes: 1d88ba171942 ("net/mlx5: refactor Tx data path") >>>> >>>> Signed-off-by: Nelio Laranjeiro >>>> Acked-by: Adrien Mazarguil >>>> >>> >>> Applied to dpdk-next-net/master, thanks. >>> >>> Is not CC'ing stable intentional, since this patch depends on a patch >>> introduced in this release? If not intentional, please CC stable. >> >> I intended to update the commit message for this patch as in the meantime we >> discovered it addresses a significant regression introduced in v16.11. >> >> CC'ing stable now. >> >> If possible, can you amend the commit log with: >> >> --- >> >> net/mlx5: fix Tx doorbell >> >> Too much data is uselessly written to the Tx doorbell, which since v16.11 >> may also cause Tx queues to behave erratically and crash applications. >> >> This regression was seen on VF devices when the BlueFlame buffer size is >> zero (txq->cqe_n == 0) due to the following change: >> >> - cqe = &(*txq->cqes)[ci & (txq->cqe_n - 1)].cqe64; >> + cqe = &(*txq->cqes)[ci & ((1 << txq->cqe_n) - 1)]; >> >> Fixes: 1d88ba171942 ("net/mlx5: refactor Tx data path") >> Fixes: e2f116ee3cac ("net/mlx5: reduce memory overhead for CQE handling") >> >> Signed-off-by: Nelio Laranjeiro >> Acked-by: Adrien Mazarguil >> Cc: stable@dpdk.org >> >> --- > > I mixed the commit that introduced the regression with a similar looking yet > harmless one, here is the proper message to use, sorry for the noise: > > --- > > net/mlx5: fix Tx doorbell > > Too much data is uselessly written to the Tx doorbell, which since v16.11 > may also cause Tx queues to behave erratically and crash applications. > > This regression was seen on VF devices when the BlueFlame buffer size is > zero (txq->bf_buf_size) due to the following change: > > - txq->bf_offset ^= txq->bf_buf_size; > + txq->bf_offset ^= (1 << txq->bf_buf_size); > > Fixes: 1d88ba171942 ("net/mlx5: refactor Tx data path") > Fixes: d5793daefec8 ("net/mlx5: reduce memory overhead for BF handling") > > Signed-off-by: Nelio Laranjeiro > Acked-by: Adrien Mazarguil > Cc: stable@dpdk.org > > --- > Can you please confirm commit in latest next-net?