From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id C703A1B1FE for ; Mon, 2 Oct 2017 12:21:52 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E55F22DA; Mon, 2 Oct 2017 10:21:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E55F22DA Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=echaudro@redhat.com Received: from rhvm.imac (ovpn-116-148.ams2.redhat.com [10.36.116.148]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6CFAB5C881; Mon, 2 Oct 2017 10:21:51 +0000 (UTC) To: "Mcnamara, John" Cc: "dev@dpdk.org" References: <138d85856e7b5c6c09abfccdb885927458120be8.1506689397.git.echaudro@redhat.com> From: Eelco Chaudron Organization: Red Hat Message-ID: Date: Mon, 2 Oct 2017 12:22:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Mon, 02 Oct 2017 10:21:52 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] doc: Adds reference to use mlockall() in the Programmer's guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: echaudro@redhat.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Oct 2017 10:21:53 -0000 On 29/09/17 17:44, Mcnamara, John wrote: > Hi Eelco, > > Thanks for that. It is always good to get doc improvements. > Some minor comments below. > Thanks for pointing out the below issues, and I send out a V2. > The title should be lowercase (except for known acronyms), <= 50 > characters > and the verb should be in the imperative. This is explained in the Contributor's > Guide: > > http://dpdk.org/doc/guides/contributing/patches.html#commit-messages-subject-line > > Also you can check with the DPDK check-git-log.sh tool: > > $ devtools/check-git-log.sh > Wrong headline uppercase: > doc: Adds reference to use mlockall() in the Programmer's guide > Headline too long: > doc: Adds reference to use mlockall() in the Programmer's guide > > I'd suggest a title like: > > doc: add use of mlockall to programmers guide > >> diff --git a/doc/guides/prog_guide/writing_efficient_code.rst >> b/doc/guides/prog_guide/writing_efficient_code.rst >> index 8223aceea..3975026ce 100644 >> --- a/doc/guides/prog_guide/writing_efficient_code.rst >> +++ b/doc/guides/prog_guide/writing_efficient_code.rst >> @@ -105,6 +105,20 @@ meaning that if all memory access operations are done >> on the first channel only, >> >> By default, the :ref:`Mempool Library ` spreads the >> addresses of objects among memory channels. >> >> +Locking memory pages >> +~~~~~~~~~~~~~~~~~~~~ > Add a blank line after a header+underline. > >> +The underlying operating system is allowed to load/unload memory pages at >> its own discretion. >> +These page loads could impact the performance, as the process is on hold >> when the kernel fetches them. >> + >> +To avoid these you could pre-load, and lock them into memory with the >> mlockall() call. > Include the function call in backquotes: ``mlockall()``. > > Thanks, > > John > > Reviewed-by: John McNamara > >