From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7EDDEA3160 for ; Wed, 9 Oct 2019 10:04:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 937DE1C1A4; Wed, 9 Oct 2019 10:04:51 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 6AE641BFAF; Wed, 9 Oct 2019 10:04:49 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us2.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 47D6580064; Wed, 9 Oct 2019 08:04:48 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 9 Oct 2019 09:04:42 +0100 To: Tiwei Bie CC: Maxime Coquelin , Zhihong Wang , , Dilshod Urazov , References: <1569944672-24754-1-git-send-email-arybchenko@solarflare.com> <1569944672-24754-3-git-send-email-arybchenko@solarflare.com> <20191008054650.GA22478@___> From: Andrew Rybchenko Message-ID: Date: Wed, 9 Oct 2019 11:04:38 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191008054650.GA22478@___> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24964.003 X-TM-AS-Result: No-8.455400-8.000000-10 X-TMASE-MatchedRID: VfovoVrt/ob4ECMHJTM/ufZvT2zYoYOwC/ExpXrHizwdQW9W2F3v/bBZ szSz1qei7UXWmJKyEwfENlHLFvCEt6ZY4PxfRMWEExdS7WFvZWtDDkW9i7BcEhnAauHjLiLM7+h Y9l7Y+Oza2aiqIZS9olO9V994jC9DIeFIFB+CV+wD2WXLXdz+AadT43GpXcMNGDt/hPCfr1ZPH2 OEh/+ebJ/7pv2u04as91FGhk3lKQBvAVPVxkfEIQuLP4ROdWHV+IfriO3cV8Swe5+81QHzJg/DZ +ACFMnI4KiXcWxRSwqRk6XtYogiau9c69BWUTGwVnRXm1iHN1bEQdG7H66TyJ8TMnmE+d0ZOB5W W9SdBUMOr6XW00regmR7dGZTPP2VnZ1yNE+nCsCLxGbHxgAVGkRIL6Inas49wxLwJKkAskVDkNe g4mRtKT/u9sxDh0I+1DXsKeBNv04EqZlWBkJWd7MZNZFdSWvHG2wlTHLNY1JWXGvUUmKP2w== X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--8.455400-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24964.003 X-MDID: 1570608289-VNQPx6_u__aF Subject: Re: [dpdk-dev] [PATCH 3/3] net/virtio: reject unsupported Rx multi queue modes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/8/19 8:46 AM, Tiwei Bie wrote: > On Tue, Oct 01, 2019 at 04:44:31PM +0100, Andrew Rybchenko wrote: >> From: Dilshod Urazov >> >> This driver supports none of DCB, RSS or VMDQ modes, >> therefore must check and return error if configured incorrectly. >> >> Fixes: c1f86306a026 ("virtio: add new driver") >> Cc: stable@dpdk.org >> >> Signed-off-by: Dilshod Urazov >> Signed-off-by: Andrew Rybchenko >> --- >> drivers/net/virtio/virtio_ethdev.c | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c >> index 7261109dd..0af4fc392 100644 >> --- a/drivers/net/virtio/virtio_ethdev.c >> +++ b/drivers/net/virtio/virtio_ethdev.c >> @@ -2071,6 +2071,13 @@ virtio_dev_configure(struct rte_eth_dev *dev) >> PMD_INIT_LOG(DEBUG, "configure"); >> req_features = VIRTIO_PMD_DEFAULT_GUEST_FEATURES; >> >> + if (rxmode->mq_mode != ETH_MQ_RX_NONE) { >> + PMD_DRV_LOG(ERR, >> + "Unsupported Rx multi queue mode %d", >> + rxmode->mq_mode); >> + return -EINVAL; >> + } > We need similar checks for Tx as well. OK, I'll add. However, I'm not 100% sure about RSS. Yes, I know that virtio has no RSS configuration support, but it looks possible to have multi queue in vhost-net case.