From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 74615A0542; Mon, 6 Jun 2022 09:48:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1830B40A7F; Mon, 6 Jun 2022 09:48:15 +0200 (CEST) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id C546240150 for ; Mon, 6 Jun 2022 09:48:13 +0200 (CEST) Received: from kwepemi500017.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4LGlrX20d4zRhfF for ; Mon, 6 Jun 2022 15:45:00 +0800 (CST) Received: from [10.67.103.235] (10.67.103.235) by kwepemi500017.china.huawei.com (7.221.188.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 6 Jun 2022 15:48:10 +0800 Subject: Re: [PATCH v2 06/11] net/hns3: fix coverity codecheck To: Andrew Rybchenko , "Min Hu (Connor)" , References: <20220519122917.2334-1-humin29@huawei.com> <20220601035251.16408-1-humin29@huawei.com> <20220601035251.16408-7-humin29@huawei.com> <8746557a-44c6-bde4-ee96-c73a921c1d9b@oktetlabs.ru> From: Dongdong Liu Message-ID: Date: Mon, 6 Jun 2022 15:48:10 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <8746557a-44c6-bde4-ee96-c73a921c1d9b@oktetlabs.ru> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.103.235] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemi500017.china.huawei.com (7.221.188.110) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Andrew Many thanks for your review. I will take over Hu Min's current work and continue to do the upstream work. On 2022/6/1 16:32, Andrew Rybchenko wrote: > On 6/1/22 06:52, Min Hu (Connor) wrote: >> In bitwise operation, "val" should be an unsigned type. This patch >> fixed it. >> >> Fixes: 38b539d96eb6 ("net/hns3: support IEEE 1588 PTP") >> Cc: stable@dpdk.org > > Please, let me know coverity ID. No necessity to resend. > I'll add it on applying. The code warning is checked by our internal code check tool, does not have the coverity ID. Thanks, Dongdong > >> >> Signed-off-by: Min Hu (Connor) >> --- >> drivers/net/hns3/hns3_ptp.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/hns3/hns3_ptp.c b/drivers/net/hns3/hns3_ptp.c >> index 1442241a4e..0b0061bba5 100644 >> --- a/drivers/net/hns3/hns3_ptp.c >> +++ b/drivers/net/hns3/hns3_ptp.c >> @@ -81,7 +81,7 @@ hns3_timesync_configure(struct hns3_adapter *hns, >> bool en) >> struct hns3_hw *hw = &hns->hw; >> struct hns3_pf *pf = &hns->pf; >> struct hns3_cmd_desc desc; >> - int val; >> + uint32_t val; >> int ret; >> hns3_cmd_setup_basic_desc(&desc, HNS3_OPC_CFG_PTP_MODE, false); > > . >