From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 6E9C14A65 for ; Wed, 8 Feb 2017 14:58:06 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP; 08 Feb 2017 05:58:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,346,1477983600"; d="scan'208";a="222810313" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.137]) ([10.237.220.137]) by fmsmga004.fm.intel.com with ESMTP; 08 Feb 2017 05:58:04 -0800 To: Jeff Guo , helin.zhang@intel.com, jingjing.wu@intel.com References: <1486547416-63712-1-git-send-email-jia.guo@intel.com> Cc: dev@dpdk.org From: Ferruh Yigit Message-ID: Date: Wed, 8 Feb 2017 13:58:03 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <1486547416-63712-1-git-send-email-jia.guo@intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] pci: fix configure device fail issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Feb 2017 13:58:06 -0000 On 2/8/2017 9:50 AM, Jeff Guo wrote: > If assign the "data->dev_flags" after run function "rte_eth_copy_pci_info", the > flag would be miss the “RTE_ETH_DEV_INTR_LSC” value, that will result the device > configuration fail, when rte check the flag if device support link state interrupt. > So the assignment must be modified to "|=" to fix the issue. > > Fixes: 22dda618c00c ("pci: separate detaching ethernet ports from PCI devices") > > Signed-off-by: Jeff Guo drivers/net: fix eth device configuration Fixes: 22dda618c00c ("pci: separate detaching ethernet ports from PCI devices") Signed-off-by: Qi Zhang Signed-off-by: Jeff Guo Applied to dpdk-next-net/master, thanks.