From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id E4F431B297; Mon, 2 Oct 2017 23:39:31 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Oct 2017 14:39:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,471,1500966000"; d="scan'208";a="906013876" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.131]) ([10.241.225.131]) by FMSMGA003.fm.intel.com with ESMTP; 02 Oct 2017 14:39:29 -0700 To: Michal Jastrzebski , skhare@vmware.com Cc: dev@dpdk.org, deepak.k.jain@intel.com, yongwang@vmware.com, stable@dpdk.org, Tomasz Kulasek References: <20170922123906.13308-1-michalx.k.jastrzebski@intel.com> <20170929130402.32196-1-michalx.k.jastrzebski@intel.com> From: Ferruh Yigit Message-ID: Date: Mon, 2 Oct 2017 22:39:29 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170929130402.32196-1-michalx.k.jastrzebski@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] net/vmxnet3: fix dereference before null check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Oct 2017 21:39:32 -0000 On 9/29/2017 2:04 PM, Michal Jastrzebski wrote: > Coverity reports check_after_deref: > Null-checking rq suggests that it may be null, but it > has already been dereferenced on all paths leading to > the check. > This patch removes NULL checking of "rq" from function > vmxnet3_dev_rx_queue_reset as it is already checked against NULL > one level up the callstack (function vmxnet3_dev_clear_queues). > > Coverity issue: 143468 > Fixes: 5aecdc17a97d ("vmxnet3: fix stop/restart") > Cc: yongwang@vmware.com > Cc: stable@dpdk.org > > Signed-off-by: Tomasz Kulasek > Signed-off-by: Michal Jastrzebski Reviewed-by: Ferruh Yigit