From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 5A445F618
 for <dev@dpdk.org>; Thu, 12 Jan 2017 15:21:39 +0100 (CET)
Received: from orsmga005.jf.intel.com ([10.7.209.41])
 by orsmga105.jf.intel.com with ESMTP; 12 Jan 2017 06:21:38 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,349,1477983600"; d="scan'208";a="52204386"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.38])
 ([10.237.220.38])
 by orsmga005.jf.intel.com with ESMTP; 12 Jan 2017 06:21:37 -0800
To: "Dai, Wei" <wei.dai@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
References: <1484063146-15796-1-git-send-email-wei.dai@intel.com>
 <1484063146-15796-7-git-send-email-wei.dai@intel.com>
 <a9cc3ccf-0466-0e06-26d6-f555ea650ceb@intel.com>
 <49759EB36A64CF4892C1AFEC9231E8D63A327604@PGSMSX106.gar.corp.intel.com>
Cc: "Zhang, Helin" <helin.zhang@intel.com>,
 "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <ca92f54c-0f0a-3ecf-b4c8-398f00043d55@intel.com>
Date: Thu, 12 Jan 2017 14:21:36 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.6.0
MIME-Version: 1.0
In-Reply-To: <49759EB36A64CF4892C1AFEC9231E8D63A327604@PGSMSX106.gar.corp.intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 6/7] net/ixgbe/base: add some debug traces
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Jan 2017 14:21:39 -0000

On 1/12/2017 2:18 PM, Dai, Wei wrote:
>> -----Original Message-----
>> From: Yigit, Ferruh
>> Sent: Wednesday, January 11, 2017 11:39 PM
>> To: Dai, Wei <wei.dai@intel.com>; dev@dpdk.org
>> Cc: Zhang, Helin <helin.zhang@intel.com>; Ananyev, Konstantin
>> <konstantin.ananyev@intel.com>
>> Subject: Re: [dpdk-dev] [PATCH 6/7] net/ixgbe/base: add some debug traces
>>
>> On 1/10/2017 3:45 PM, Wei Dai wrote:
>>> This patch adds some traces in the reset_hw logic and semaphore
>>> acquisition logic to help debugging.
>>
>> Is verbosity of the PMD changes with this update?
>>
>> Is something required in PMD to disable DEBUGOUT1(), DEBUGOUT2(),
>> DEBUGOUT() by default?
> 
> In drivers/net/ixgbe/ixgbe_logs.h, there are
> #ifdef RTE_LIBRTE_IXGBE_DEBUG_DRIVER
> #define PMD_DRV_LOG_RAW(level, fmt, args...) \
> 	RTE_LOG(level, PMD, "%s(): " fmt, __func__, ## args)
> #else
> #define PMD_DRV_LOG_RAW(level, fmt, args...) do { } while (0)
> #endif
> 
> And in drivers/net/ixgbe/base/ixgbe_osdep.h, there are
> #include "../ixgbe_logs.h"
> ....
> #define DEBUGOUT(S, args...)    PMD_DRV_LOG_RAW(DEBUG, S, ##args)
> #define DEBUGOUT1(S, args...)   DEBUGOUT(S, ##args)
> #define DEBUGOUT2(S, args...)   DEBUGOUT(S, ##args)
> #define DEBUGOUT3(S, args...)   DEBUGOUT(S, ##args)
> #define DEBUGOUT6(S, args...)   DEBUGOUT(S, ##args)
> #define DEBUGOUT7(S, args...)   DEBUGOUT(S, ##args)
> 
> In config/common_base, there is 
> CONFIG_RTE_LIBRTE_IXGBE_DEBUG_DRIVER=n
> 
> So according above codes, the macro RTE_LIBRTE_IXGBE_DEBUG_DRIVER in drivers/net/ixgbe/ixgbe_logs.h is not defined
> and PMD_DRV_LOG_RAW(level, fmt, args...) do { } while (0) will be valid,
> then DEBUGOUT() is just a null definition by default.

OK, thanks for clarification.

> 
>>
>>>
>>> Signed-off-by: Wei Dai <wei.dai@intel.com>
>>> ---
>>
>> <...>