From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 28149A0561; Tue, 21 Apr 2020 04:52:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 400F31D566; Tue, 21 Apr 2020 04:52:30 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id E77151D411 for ; Tue, 21 Apr 2020 04:52:28 +0200 (CEST) IronPort-SDR: VkKytDk3JSgNwfKDH7zb+L1sGOFDsMza6eL4GbEnt4D3DuSbF42eenCXhdnUN4rnJ8kpr/4Tvb C4E/9cy2/yeg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2020 19:52:28 -0700 IronPort-SDR: zcL0RTMsxELu3Tx8iSugWaJtZJXJfKSdudkb/OrsyBtyU8nlygoX4YtZwOiKJLAuGK1lL6PXvL Zl904flJ5YWQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,408,1580803200"; d="scan'208";a="290310341" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by fmsmga002.fm.intel.com with ESMTP; 20 Apr 2020 19:52:26 -0700 Received: from irsmsx606.ger.corp.intel.com (163.33.146.139) by IRSMSX101.ger.corp.intel.com (163.33.3.153) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 21 Apr 2020 03:52:25 +0100 Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by IRSMSX606.ger.corp.intel.com (163.33.146.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 21 Apr 2020 03:52:24 +0100 Received: from shsmsx603.ccr.corp.intel.com ([10.109.6.143]) by SHSMSX603.ccr.corp.intel.com ([10.109.6.143]) with mapi id 15.01.1713.004; Tue, 21 Apr 2020 10:52:23 +0800 From: "Wang, Haiyue" To: Thomas Monjalon , David Marchand CC: Neil Horman , dev , "Burakov, Anatoly" , Vamsi Attunuru , Jerin Jacob Kollanukkaran , "Yigit, Ferruh" , "Richardson, Bruce" , "Kinsella, Ray" Thread-Topic: [PATCH v8 0/2] support for VFIO-PCI VF token interface Thread-Index: AQHWFafaI2Lui2Y2EEyeOUOuYmQWTqiBtuGAgACHcqD//347AIAAjE3A//973ACAAQnooP//hLAAABDTtmA= Date: Tue, 21 Apr 2020 02:52:23 +0000 Message-ID: References: <20200305043311.17065-1-vattunuru@marvell.com> <3886348.YqazSvReao@thomas> <5346011.DvuYhMxLoT@thomas> In-Reply-To: <5346011.DvuYhMxLoT@thomas> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v8 0/2] support for VFIO-PCI VF token interface X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Tuesday, April 21, 2020 10:13 > To: David Marchand ; Wang, Haiyue > Cc: Neil Horman ; dev ; Burakov, Ana= toly > ; Vamsi Attunuru ; Jeri= n Jacob Kollanukkaran > ; Yigit, Ferruh ; Richardson,= Bruce > ; Kinsella, Ray > Subject: Re: [PATCH v8 0/2] support for VFIO-PCI VF token interface >=20 > 21/04/2020 03:38, Wang, Haiyue: > > From: Thomas Monjalon > > > 20/04/2020 19:37, Wang, Haiyue: > > > > From: Thomas Monjalon > > > > > 20/04/2020 19:02, Wang, Haiyue: > > > > > > From: David Marchand > > > > > > > I had a look at the CI, I can see we are still missing bits t= o handle > > > > > > > the ABI failure on rte_vfio_setup_device. > > > > > > > > > > > > Yes, not handle it now. > > > > > > > > > > > > If 'rte_vfio_setup_device' can be internal, not official DPDK A= PI, then __rte_internal > > > > > > is the best way to handle ABI issue. > > > > > > > > > > Please could you help finishing integration of __rte_internal? > > > > > > > > I thought it should be Neil ? "Yes, I'll get back to this today" ;-= ) > > > > http://inbox.dpdk.org/dev/CAJFAV8ydLkV0afEHqbh6KeA3Box0Yxb3N0MNGtMD= 4S9bmSgT0A@mail.gmail.com/ > > > > > > It did not happen after several months. > > > If you want to unblock your patches, I think it is safer to finish yo= urself. > > > > > > > Unfortunately, this __rte_internal will still make the ci fail to run w= hen move the function > > to INTERNAL session: > [...] > > +INTERNAL { > > + global: > > + > > + # added in 20.05 > > + rte_vfio_setup_device; > > +}; >=20 > Why do you need to move the symbol explicitly in .map? > The tool should ignore symbols moving to internal, as an exception until = 20.11. > If not move the symbol explicitly in .map, another kind of error happened. ./devtools/check-abi.sh old_abi new_abi Functions changes summary: 0 Removed, 1 Changed, 0 Added function Variables changes summary: 0 Removed, 0 Changed, 0 Added variable 1 function with some indirect sub-type change: [C] 'function int rte_vfio_setup_device(const char*, const char*, int*, v= fio_device_info*)' at eal_vfio.c:704:1 has some indirect sub-type changes: parameter 5 of type 'unsigned char*' was added Error: ABI issue reported for 'abidiff --suppr ./devtools/libabigail.abigno= re --no-added-syms --headers-dir1 old_abi/include --headers-dir2 new_abi/in= clude old_abi/dump/librte_eal.dump new_abi/dump/librte_eal.dump' =20