From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 3F5321B12D for ; Fri, 5 Oct 2018 15:23:20 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Oct 2018 06:23:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,344,1534834800"; d="scan'208";a="78739089" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.49]) ([10.237.221.49]) by orsmga007.jf.intel.com with ESMTP; 05 Oct 2018 06:19:37 -0700 To: Dekel Peled , wenzhuo.lu@intel.com, jingjing.wu@intel.com, bernard.iremonger@intel.com, dev@dpdk.org, olivier.matz@6wind.com, adrien.mazarguil@6wind.com, thomas@monjalon.net, arybchenko@solarflare.com Cc: shahafs@mellanox.com, orika@mellanox.com References: <1537104835-9034-1-git-send-email-dekelp@mellanox.com> <1537108670-11380-4-git-send-email-dekelp@mellanox.com> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: Date: Fri, 5 Oct 2018 14:19:36 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1537108670-11380-4-git-send-email-dekelp@mellanox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 3/3] app/testpmd: add debug command Tx metadata set X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Oct 2018 13:23:20 -0000 On 9/16/2018 3:37 PM, Dekel Peled wrote: > As described in [1],[2] this series adds option to set metadata value as > match pattern when creating a new flow rule. > > This patch introduces code for debug porpuse only. > The new debug command takes a 32 bit value and stores it per port. > testpmd will add to any Tx packet sent from this port the metadata > value, and set ol_flags accordingly. > > [1] "ethdev: support metadata as flow rule criteria" > [2] "app/testpmd: support metadata as flow rule criteria" > > Signed-off-by: Dekel Peled <...> > @@ -851,6 +851,13 @@ Disable hardware insertion of a VLAN header in packets sent on a port:: > > testpmd> tx_vlan reset (port_id) > > +tx_metadata set > +~~~~~~~~~~~~~~~ > + > +Set metadata value to insert in packets sent to PMD:: > + > + testpmd> tx_metadata set (port_id) (value) My usual testpmd grunting: Everybody is adding a high level command to testpmd, with own syntax and in the scope of a specific feature, that nobody else knows about, it makes testpmd confusing/hard to use. If this is a command to set a port feature, why not extend existing, "port config ..." Like "port config tx_metadata " ? And second, I think it is good to have a set & show as pairs, this function sets the "tx_metadata", is there a way to display existing "tx_metadata"? If not, what about: "show port tx_metadata"?