From: fengchengwen <fengchengwen@huawei.com>
To: Andre Muezerie <andremue@linux.microsoft.com>,
Kevin Laatz <kevin.laatz@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>
Cc: <dev@dpdk.org>
Subject: Re: [PATCH] dmadev: enable lib to be compiled with MSVC
Date: Tue, 4 Mar 2025 10:40:17 +0800 [thread overview]
Message-ID: <cae94b70-b173-4de8-8877-e26dc41404d5@huawei.com> (raw)
In-Reply-To: <1741053304-9891-1-git-send-email-andremue@linux.microsoft.com>
Acked-by: Chengwen Feng <fengchengwen@huawei.com>
Thanks
On 2025/3/4 9:55, Andre Muezerie wrote:
> With the outstanding issues preventing dmadev from being compiled
> with MSVC being fixed, the lib can be enabled to be compiled with MSVC.
>
> Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
> ---
> lib/dmadev/meson.build | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/lib/dmadev/meson.build b/lib/dmadev/meson.build
> index e66dcb66b0..62b0650b9b 100644
> --- a/lib/dmadev/meson.build
> +++ b/lib/dmadev/meson.build
> @@ -1,12 +1,6 @@
> # SPDX-License-Identifier: BSD-3-Clause
> # Copyright(c) 2021 HiSilicon Limited.
>
> -if is_ms_compiler
> - build = false
> - reason = 'not supported building with Visual Studio Toolset'
> - subdir_done()
> -endif
> -
> sources = files('rte_dmadev.c', 'rte_dmadev_trace_points.c')
> headers = files('rte_dmadev.h')
> indirect_headers += files('rte_dmadev_core.h', 'rte_dmadev_trace_fp.h')
prev parent reply other threads:[~2025-03-04 2:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-04 1:55 Andre Muezerie
2025-03-04 2:40 ` fengchengwen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cae94b70-b173-4de8-8877-e26dc41404d5@huawei.com \
--to=fengchengwen@huawei.com \
--cc=andremue@linux.microsoft.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=kevin.laatz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).