From: Shijith Thotton <sthotton@marvell.com>
To: <jerinj@marvell.com>
Cc: Shijith Thotton <sthotton@marvell.com>, <dev@dpdk.org>,
<pbhagavatula@marvell.com>
Subject: [PATCH] app/test-eventdev: wait for workers before cryptodev destroy
Date: Thu, 2 Jun 2022 17:15:28 +0530 [thread overview]
Message-ID: <cafd91ddf913c856bd92f77a9c99dc1da35627db.1654170277.git.sthotton@marvell.com> (raw)
Destroying cryptodev resources before exiting workers are not safe.
Moved cryptodev destroy after worker thread exit in main thread.
Fixes: de2bc16e1bd1 ("app/eventdev: add crypto producer mode")
Signed-off-by: Shijith Thotton <sthotton@marvell.com>
---
app/test-eventdev/evt_main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/app/test-eventdev/evt_main.c b/app/test-eventdev/evt_main.c
index c5d63061bf..b785e603ee 100644
--- a/app/test-eventdev/evt_main.c
+++ b/app/test-eventdev/evt_main.c
@@ -159,9 +159,6 @@ main(int argc, char **argv)
if (test->ops.ethdev_rx_stop)
test->ops.ethdev_rx_stop(test, &opt);
- if (test->ops.cryptodev_destroy)
- test->ops.cryptodev_destroy(test, &opt);
-
rte_eal_mp_wait_lcore();
if (test->ops.test_result)
@@ -173,6 +170,9 @@ main(int argc, char **argv)
if (test->ops.eventdev_destroy)
test->ops.eventdev_destroy(test, &opt);
+ if (test->ops.cryptodev_destroy)
+ test->ops.cryptodev_destroy(test, &opt);
+
if (test->ops.mempool_destroy)
test->ops.mempool_destroy(test, &opt);
--
2.25.1
next reply other threads:[~2022-06-02 11:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-02 11:45 Shijith Thotton [this message]
2022-06-13 6:38 ` Pavan Nikhilesh Bhagavatula
2022-06-13 6:59 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cafd91ddf913c856bd92f77a9c99dc1da35627db.1654170277.git.sthotton@marvell.com \
--to=sthotton@marvell.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=pbhagavatula@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).