From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 782CF42CA7; Tue, 13 Jun 2023 18:38:59 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 513D240C35; Tue, 13 Jun 2023 18:38:59 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2041.outbound.protection.outlook.com [40.107.220.41]) by mails.dpdk.org (Postfix) with ESMTP id 369AA40A8A for ; Tue, 13 Jun 2023 18:38:58 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K2Rn9v1YwM7UXI1o1zXJOpvDDG0++G4dRfeaw3m6KwXkOE7Nt5D/w2aFpwKhZp0kZOV2z6WpxlIVpWdOakG0LiR7rO54k+jHn3U1JxqlEKN9kMRQmKTvu9AnG5CZEqiuKI+phulq1H253NQ7iulR4UYyRVIQKpP1LsB+CoRQkXue/UY2yHaBqfGF1sZA/nbtkRRilsBfCL1phvxYMXkYuxbneHCl0A9bgy1gT8EX+mmav6oCZICA/ilozAE5FcRoD+lCDaNAbNnh7MThxR0qtDNdtbjL5ZfJtx01OIakjWC4ikEygA/8O2rjWl41D9kM9qnXrUHN5YkLjrx2r2tLDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yM7RtUmoDw3cuvvd9AXYCOmq6XYYAwt+sNXTdzYAGx4=; b=MIxBGJW6+xvNQDzt7KG+dCFP5DoTz3loZ+4o4+zI24lh+X8ea1T6Nn/vDolL4K0WLXm0Qdk/j4OBZlr/ByMSNP5xqaK+ZgnzntU5uYB2x0rh6NJuMkzW90osiv/vGJhOZZO6zTB9Ct8jpIsLBTyfjYnT1iA6eWUFO5gRpSbQG/lkRqx3tEdCM0L9YzQsF+By9ZEGpdmOOd1QpINglapbVgvKnmoIOu92YU9BMKyEcj/LOxp4P2GeigODyQcz0IULbyDEa2mj10wI2kCHB+PPxx0tM5RtSmcGBsASOCkSK2UNALR8tyzKucNcm1vCG4B0yXzGpG0JZz49dZ0fjXNEQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yM7RtUmoDw3cuvvd9AXYCOmq6XYYAwt+sNXTdzYAGx4=; b=LUHNTvyv8T4E9tXxEMAoEk1P+3IJ+KtPD07MNX/AWuKoXFxVRIZN86cIAvxk1kU90Xifks8LIft78UUayiiJMBPaUL4m02ozsKDpfgHy2iNWqNhJiQ4KIXa/6tJrTgcCY1TmRgPpNNhZQIgsgEKvNhDGBsF1KmLqVJ0NzeqrsGE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH7PR12MB6906.namprd12.prod.outlook.com (2603:10b6:510:1b8::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.46; Tue, 13 Jun 2023 16:38:55 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42%3]) with mapi id 15.20.6477.028; Tue, 13 Jun 2023 16:38:55 +0000 Message-ID: Date: Tue, 13 Jun 2023 17:37:50 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2] ethdev: prefer offload names in logs Content-Language: en-US To: David Marchand , dev@dpdk.org Cc: Thomas Monjalon , Andrew Rybchenko References: <20230309081633.780438-1-david.marchand@redhat.com> <20230613132431.781883-1-david.marchand@redhat.com> From: Ferruh Yigit In-Reply-To: <20230613132431.781883-1-david.marchand@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P302CA0007.GBRP302.PROD.OUTLOOK.COM (2603:10a6:600:2c2::14) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH7PR12MB6906:EE_ X-MS-Office365-Filtering-Correlation-Id: 1a9cae53-468d-4fdc-4a3a-08db6c2cadd5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JLsVbq8dvoXKOk6zrWzZZMrT6jL4GkSoOpcbQ+XII9E/Ly6wLllVVp6Bn2IUtzVJpDXCrYuJsHYzUAnwNrIBWGy8GXYkrYzQ3kGvJWbcYPeDShzs9vG9FlrGc3zceSO5XOyzjF+DqIX/EPBNbquB0Y6x5VaDtDBHMIaKdtslBMK5xlnDCIih+YLodjnO8a6NubayJjaUGpP+I+mjXpbcGsiDv/HcthXe1W5Q5WBM89k+qQTqFLC9MfxpJEc1t260mlXuWF9ySTis8TGqtCpnsAm39FCF1AnbbmAHp9Po53ObkVwpscOe3/QcGD1FxFwmGrW2VelviOxJh0h+JgiQ0LqNKkXf+2HRPkwwNNicn1mqiS6bbpNOuZ7dImAqLX1Y8e1akBRZKGlqcdPapjqiL7MZNIRdORH/y/1+9g1QhC5CuLvrnrGlZIETE2hrHOA1T0D+crqNhYlB5HSZkSDH+UTkgciAL0Rm3vzOwZdL9DAFq7UkuLqORVVmQZq/yG7AV36SX+e+fCsPo8tgUI0s812pJynqlBXboE5x0IHtaNKdRoYbdrQep5k27/2BdeF2uUdjU3dBV47bQ6IwRAckIlHvOKGLvV7vbOeC69Wkr/JR71m4mDsoxZ6L9Ow47m+Fk1qufyUwrezUs1Uf+1K/xw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(136003)(376002)(396003)(346002)(366004)(39860400002)(451199021)(6666004)(6486002)(478600001)(6512007)(53546011)(26005)(6506007)(186003)(36756003)(83380400001)(38100700002)(31696002)(86362001)(2616005)(66476007)(66556008)(66946007)(4326008)(316002)(8936002)(44832011)(8676002)(31686004)(5660300002)(4744005)(2906002)(54906003)(41300700001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N1FkeURvMnNwaUx3d2lFb2RranFiNncwUll6eko2SFd4cVlES05uQkFwNmZV?= =?utf-8?B?QmRQVFY0dGtxSU9aSmhsQ1IycXJQOEpIRXdSRVZnbXpKMWdUMytjenFpTEs4?= =?utf-8?B?a0kyWWZGR3VNMVdodFFuTk1CTmVuY1NIeXhVcUg0U1ZLYzJPZU50SDV0MDdy?= =?utf-8?B?R0srVUl2MzVDYzFPSXdSTlU4Q1JBeXlFMDJvVjQ4U0NWN2ZvLzhpMzFCSUdI?= =?utf-8?B?L3kzVGRiSE5MRUQ4Rk5XUUYzeVdWbFFRY1lqOWoxVEdZQWhRVzk5M21rSW55?= =?utf-8?B?c056Q0E2aE9JRldCNHVOMkhsOEZlbGM1YWROVjZGWUlQd2FYM3h0N2piT2VZ?= =?utf-8?B?ZlZET2lkMkFlSWRZZ0Y5MmNjZVRDQWJXbCtyRUtYMDlTSTZuOHMyL01oS2t2?= =?utf-8?B?TGN2bGMvTFRRMFhwQnMvT0xOLzVoellMaUhXUVU4Y0NDZUlITVNKdjgzWFZm?= =?utf-8?B?WXF0K0VrbXNSQ1h1MjVxdml5cmhadndjdy9DdUVLZTBFVStvdmZHRVNNTG1Y?= =?utf-8?B?cEg5ZWpIYWpiZlVCUnN5WVpRdkhGUHJUckQybHI1NFNjU3JlTnFRZFA4N0pM?= =?utf-8?B?OFprekE3M3VXLytDclBOU3dKRHRCM1VKL3MwRnpZa0JDY254VEVPMFBFY3pz?= =?utf-8?B?b1p2bmlLbEozdUlIQ2N6dXlNZTZuM05HZlVEOWpLa2pqMmNvVzlIbnRSUFBy?= =?utf-8?B?dXpmZy9LVW9HQVdSeDZ5Qmw3NjFVdzdxdS96T3IrbkpreWd4NjVTRUdVSUtx?= =?utf-8?B?TllvSnhRQ1pYRm0vb1hzOXJYNUovcDROQnZaVktwSXYyS3h3ZFljRW43cHBF?= =?utf-8?B?UmVhN01HVHFWbVo5Nk80Z3J1ckxDWWxXcWNlblNoQU9kdU1BdU1JQm9wdi93?= =?utf-8?B?bmoxaXI3eWpsV2lvMHR6cDFYY0NVK0NwUjdRbTEyWjN1Nmo1UzlmZk5zdGNE?= =?utf-8?B?TGxqM2JVdU1wazRFL2gwbU9ESlVLcm1kdDNXYjk0WGNDNHQ0UGpPZmowci9X?= =?utf-8?B?TkQrN3lUMjVQWGl5NnNEQ21HaUU3YzBGOHJuWkV0c05RaVpsMVNlSndXS3lR?= =?utf-8?B?Tk9yQTNGYWtDbXJvUkhsMWFlQ25jT25WaUZwZ0hEN1F3WGhyaWxhY21kODNp?= =?utf-8?B?M1ZxN2I2UnZnWkphd0hVaUp4MVVHSjljS2czUmM2MFhrVDVJbmhuWjdGQjBl?= =?utf-8?B?elNZb2ZsdzV0ZCtQaVgvNjc0QjIzY29KRllHYWtlZ1R2TzRXQlBaM2ZrOUsr?= =?utf-8?B?VEExZ3JZTUlOaktqaHBSZTV4VXUrMVNTM0c5aDZvZ3dXMUcrbmVnUXhldWhT?= =?utf-8?B?TEhVREEyYkJBTzlXRUxZazVwNm81VlpVU1A4RWNlczIySGNtM2tRNlRKUEhw?= =?utf-8?B?VTJ2bnlqTXpsRmNYcDJmMGxHMkMyR0tyZFY2a2QrbTB0ZGJ5QlkzbjR6SUV4?= =?utf-8?B?aUE3dnNkVTViV2RSczRMcjNOYU5ZQ2V3V0R5MVhkT2VyMk9aWmxoY0FvSUxa?= =?utf-8?B?a0pZdmlQYmxpM0tlQXdhZ0hnNE5McitwMGNtNm0yQXFnQ1hBb2RWNFJnSmpN?= =?utf-8?B?YmhpWjFYMzdQK3d4STBRVmFpMjlHZ3lsdFNKUUQ1THkrODR3L3YvVFZYK0pw?= =?utf-8?B?T2pDRnl5OVdPRktuVlBtM0w3T1BSb0xST0xhR2ZDSnpJcTR0N3NxcEozNTNn?= =?utf-8?B?c21KWTh6ZFVWb3BYRS9QUmplQ1ZXaSs5MVRpNkw5aU9qT3lxRTg4bVI1aXJj?= =?utf-8?B?MFkvRmZORmFOclJZZjM5SGVuUllPbDFIOG5hOVR1NHZ0bVpsM1E5QitlQXBN?= =?utf-8?B?anJSVW1BYUhRdEVuTEpsZ0QzRkRUUjJweUY5TFlhTHBhZUIxdXk2R1AvKyt5?= =?utf-8?B?TnhlVkw4S2tueHVISnFtd2pDcENCczUzUHVpaWFmQ1NJTm82OXFWSHp0KzBi?= =?utf-8?B?U04rU2cvcml6MVRnV0k4cVcxSUNXME9CR0F2cUVLMENKZkxwZ2xjUDdydlZN?= =?utf-8?B?RGE4ZjNpeWZtbmcwL3ltbWhqWGliSHJQMCtXUFZ0NzFCMHdEeStnWFhTaGo2?= =?utf-8?B?bk1hcnhZRTc5Z1ZTWWkrdThIc2FOYmoySUdxZTRiS0EzSjA3V3BrdGNDWmNo?= =?utf-8?Q?p3k/7u+/bjUZjINibtLGN19ZK?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1a9cae53-468d-4fdc-4a3a-08db6c2cadd5 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2023 16:38:55.6371 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DhxRu34wBUO3nTGsMiIF9itE/f7dZgULq6Dc5uFcUS/jqUb+TJaOIEVMvdAAW+at X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6906 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/13/2023 2:24 PM, David Marchand wrote: > Displaying a bitmask is terrible for users. > Prefer offload names when refusing some offloads in > rte_eth_dev_configure. > > Before: > Ethdev port_id=0 requested Rx offloads 0x621 doesn't match Rx offloads > capabilities 0x0 in rte_eth_dev_configure() > > After: > Ethdev port_id=0 does not support Rx offloads VLAN_STRIP,QINQ_STRIP,VLAN_FILTER,VLAN_EXTEND > Ethdev port_id=0 was requested Rx offloads VLAN_STRIP,QINQ_STRIP,VLAN_FILTER,VLAN_EXTEND > Ethdev port_id=0 supports Rx offloads none > > Signed-off-by: David Marchand > Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.