Re: [dpdk-dev] [PATCH v4 01/16] ethdev: add error types to flow API

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 4/18/2018 9:41 AM, Adrien Mazarguil wrote:
> On Tue, Apr 17, 2018 at 08:37:31PM +0100, Ferruh Yigit wrote:
>> On 4/16/2018 5:22 PM, Adrien Mazarguil wrote:
>>> These enable more precise reporting of objects responsible for errors.
>>>
>>> This breaks ABI compatibility for the following public functions:
>>>
>>> - rte_flow_create()
>>> - rte_flow_destroy()
>>> - rte_flow_error_set()
>>> - rte_flow_flush()
>>> - rte_flow_isolate()
>>> - rte_flow_query()
>>> - rte_flow_validate()
>>
>> Is there a deprecation notice for this API break?
> 
> A notice covering the main changes in this series (most patches have an ABI
> impact) was sent but not included [1]. This particular patch rides on the
> announced ABI breakage in order to add a relatively minor feature while
> there.

My take from "announced ABI breakage" is the deprecation notice get three acks
and merged into release, so it seems there is no deprecation notice and
according process first deprecation notice should go in this release.

Hi Thomas,

Any comment on issue?

> 
> This ABI change was implicitly needed by upcoming work for 18.05 (Xueming's
> RSS stuff [2][3], Declan's TEP [4], the rest is summarized by a RFC [5]) due
> to the necessary changes of behavior in flow rules.
> 
> Note that Xueming's deprecation notice [3] alone would have triggered such
> an ABI change because struct rte_flow_action_rss wouldn't have been binary 
> compatible if struct rte_eth_rss_conf was updated. This change would have
> propagated back to rte_flow functions manipulating them.

To be honest I lost track of Xueming's patches, because of split/merge of
patchset, multiple set with multiple versions out.

Is it possible to document the dependency graph including your set?

> 
> [1] "doc: announce API changes for flow rules"
>      http://dpdk.org/ml/archives/dev/2018-February/090988.html
> [2] "MLX5 tunnel Rx offloading"
>     http://dpdk.org/ml/archives/dev/2018-February/091461.html
> [3] "doc: annouce ABI change for RSS configuraiton structure"
>     http://dpdk.org/ml/archives/dev/2018-February/090127.html
> [4] "tunnel endpoint hw acceleration enablement"
>     http://dpdk.org/ml/archives/dev/2017-December/084676.html
> [5] "Switch device offload with DPDK"
>     http://dpdk.org/ml/archives/dev/2018-March/092513.html
> 
>>> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
>>> Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
>>
>> <...>
>>
>