From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0046.outbound.protection.outlook.com [104.47.33.46]) by dpdk.org (Postfix) with ESMTP id B04286CB9 for ; Tue, 11 Oct 2016 08:35:37 +0200 (CEST) Received: from BLUPR0301CA0030.namprd03.prod.outlook.com (10.162.113.168) by DM5PR03MB2443.namprd03.prod.outlook.com (10.168.233.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.659.11; Tue, 11 Oct 2016 06:35:36 +0000 Received: from BL2FFO11FD049.protection.gbl (2a01:111:f400:7c09::153) by BLUPR0301CA0030.outlook.office365.com (2a01:111:e400:5259::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.659.11 via Frontend Transport; Tue, 11 Oct 2016 06:35:36 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; tuxdriver.com; dkim=none (message not signed) header.d=none;tuxdriver.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BL2FFO11FD049.mail.protection.outlook.com (10.173.161.211) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.629.5 via Frontend Transport; Tue, 11 Oct 2016 06:35:35 +0000 Received: from [10.232.14.87] ([10.232.14.87]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id u9B6ZWVH006045; Mon, 10 Oct 2016 23:35:33 -0700 To: Neil Horman References: <1475847187-28967-1-git-send-email-shreyansh.jain@nxp.com> <1776769.u7sKE3cfDQ@xps13> <20161010125624.GA19423@hmsreliant.think-freely.org> CC: Thomas Monjalon , "david.marchand@6wind.com" , "dev@dpdk.org" From: Shreyansh Jain Message-ID: Date: Tue, 11 Oct 2016 12:06:27 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161010125624.GA19423@hmsreliant.think-freely.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131206413359869555; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1109001)(1110001)(339900001)(377454003)(189002)(377424004)(199003)(13464003)(24454002)(86362001)(4326007)(64126003)(19580405001)(33646002)(93886004)(76176999)(19580395003)(54356999)(50986999)(189998001)(105606002)(11100500001)(68736007)(47776003)(23746002)(8676002)(36756003)(356003)(81166006)(81156014)(7846002)(65806001)(8936002)(65956001)(305945005)(15395725005)(104016004)(6916009)(2950100002)(6666003)(31686004)(106466001)(2906002)(626004)(92566002)(65826007)(4001350100001)(5660300001)(15975445007)(31696002)(230700001)(97736004)(110136003)(87936001)(85426001)(77096005)(50466002)(586003)(83506001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR03MB2443; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD049; 1:ZafER2eg+6tX+MxnJKY98FGNh3yEJT9J8b8uoxsqf+SRziLjohYwrQNlQ7D5YN/5QA1X4pkKLkFqN5KWcPjIWHQM1Gg70JcPAcwueONvV4Bny6kCRk/6F7dwbSwjgbcJVB/papgX3aB/k6EHso1g9WKotEQJj/3sgzGuiq5vYMSOvpYq67qUvLpCrF6hQcJf8Ev5Cvf9R0ejrwEpfWRgJA3OoIEGVCGEki2dJfnYVQahXHebIRlyEKGJCxJnmwDQ48e3eiFfyv+sqfo+LH5nzu0tIzLUmyJNkOTMxk6eEwy4+6t0WvcmVsLwsbxDb3FYUHyNRsjiiSkSO38oY356brgwrzqev1840vFZiqx2a3SvN5GQNEmCoQKVhkzfsDvworKd0b0EM5klI/dXtJlRdRMOF17+jzWd0d82Op/BliywGm72Zi3o+EbgdeSe5/Oizfe/HIGKRzzB7TzDqeKrQRtCtSF1aF8W/CbvY+9acNxJJAnKNQjiqKR5wdsv4O2GypNRToHpgZLnH4U6TrxkLBrc5fYMiNZL2s67Qd7jYJXi0d1KtCuaZJ39bYZMNO1cStP0CTV23omv5pHmWikdUw== X-MS-Office365-Filtering-Correlation-Id: 9d4f375f-cdc8-464c-6e73-08d3f1a0cf08 X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2443; 2:IRgDyGxpWs1vuenf5/+tRVSp+PjCS8dPleir7V6CJwTvyMATJB/Wd8+fMcSaX2J7HQHL9UZ6qIQHpNmG0OlU8HBeVhBi+i83CYhXyQ+LPPg0ahEc+pGuuXHijcLPbvhiAw657Q2uip7bKDCOyBeZFCCNnffwAaRltqEdzJ8I+psYS9WOoUIFBPYdGxWSLaGSKHTyz///qFoq3xvr7P1wYw==; 3:Q2P3EBP4FxFj9Kqh6NaYHZnleaCsp6B14tdUAfOfDcTEWnVSUAOQwVbtaIL9As7GtHPy1YAT7NskajHb5dOtVxasCCepqDt/KGOjwhrQHsmiiqxKU6Ag6lbqyj/aUrmeLK83C45RpTo3whatIPv4siN54yJzKwmq+9E7qbKaxxiiGYhOwm8ekA/sIOOkGOBv5/4nGU/p7zYH/gx+w6MhqYMA8UXf7UwaOpKngaMOS8bRzXFeyS4S9VZ03+NI35i9; 25:0lTVaFZ9ncuT28VYB93REDtlozoQfG55hS+wyJfhkVys2qUym34w2uC0aPwFLwgNj1M7pVSlYlrtvud9n5xHY6DGFcRUOSRHKP9m4zVyVV3AxL96Y36ntfalhhk0FHWKlxtXofa1Z2IjvHnUuHuhK34nabgomBCXNZHk2SPNhrKjijihiO3xN0CeLzex8z3OXPTYJPqFDD0DHncVG3Xm3qfEa0zPFwSL5/cKb5suhTVVhdWJ3Fv42dyB9KNBWBWVlVqsfZqyj3hQf13Bb8kDhE0bbfQzFFIqygHprm2c7tQpW1tKUObQYp54DdmFjAKw5LPYuqLW43/ccWiBR7QMDNMjHcUPT8WVHg03l+yb6Qyjcgatf/iQTRSeIURGX4e50FGR+iaboEq1t0RwPc0prGKP34L6SywWly4EOOLOqRbxBfKjM83l+lVeH2B3sIHv X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM5PR03MB2443; X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2443; 31:luhMV+/NwQFdI0bDkx6z7Xtm0DJtwB/0WHfHGb5lAweY91MKPtnVnhi69tR+RpWpoAMlk0d/e7mj12MPnbf5EHcMSZOvTxubWL83I8GmDDjSESCwjBgwFXS3tfw0tQp+Rf19dCtPUazUwufe4UkijSKNJ9gb7656mlDMYPaXzlRMiCT5rqfRlHhKZHS58hXLcMe9WFzUYs8ADU6423hDdAMJSAYaPKaM/vmKaktghiB4U1kQTirAMAzhn5N+N17VWNLjt9G3cUzv/8e7Ok5IkQ==; 4:sHtRZ/+SVNPXX/NqLb8HRlEFR/6ai1pCCe2gVVBkNiQzLWAbpehallFc5r7Q2sJVPB/jSckd60rWryd/DjLBlj1CrgeivQO5W8HoATUGtXGDgbeZD5yAmZWbc6CwbLNVBwatws8sg/tIctfOj5B4veFg6u4IUIAO2DQ1TJn4eUd1SdkrTALIs0XmtclwyO/BQQdXC/q8/RCGGAp7JhTmDYzNjiLaAJfdyJ/TJxWc8CETBczXozq80UzZucDg5mXdSwoTWn/JR+LcNtodo8jCKSNayQF7xcmkLmJCTYtA6d4oVL5OhZqXRr8K9Fe9MBoh2O4//HWYYqhP11WJ5rAxRrmuPOAe+dGv+J639df7+CrxLPgnkOU+U30nRi4CPQ+iTgpWGRUtLhfNEp33gQY2KVc14CXalBmz4a92ZZ2HyfNn8QjB9vrl554RvFWs7RHnGETtm1ee/1lymdOsYIZUYwrkS+w4OF7eqymjohjj8BI8gT/TDDDwSrs/0ZtBJq5l843dTFR8jy+SAlEO9xkIfJAV2dn1/7F0Y+2fGd7HJP2O2YBknGH9eBCcLye8j5nvHu1x71hWHzDhmpw/9T2yxw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(155532106045638); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(8121501046)(13017025)(13018025)(13024025)(13015025)(5005006)(13023025)(10201501046)(3002001)(6055026); SRVR:DM5PR03MB2443; BCL:0; PCL:0; RULEID:(400006); SRVR:DM5PR03MB2443; X-Forefront-PRVS: 00922518D8 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; DM5PR03MB2443; 23:o6aYQjLblFkpR4QbkJ541Po471UpDHX7CP1fT?= =?Windows-1252?Q?wOReeXkOsOymag76JXGOLCb6pSTjABgQnFabL2TZot4CYAB423jQOKyJ?= =?Windows-1252?Q?YEV8u2I6jLCupn9nS0lNjC6BQqURxWNEb6j9lpr9F/pTDFfUbi/Y2aWl?= =?Windows-1252?Q?00BwKZGo/wctqVU/kwJ4PK0WuJD5CCa8XN1GjXE3PMvfnl8/hjFB9sxM?= =?Windows-1252?Q?wJY9MFYrYJvHqGnM7xHhShEXRa2CpdsEyLIV1BWamu0E3BMsH+GZvi9l?= =?Windows-1252?Q?Qx+aBexTjgmyh7q1HsmznXKNWdmY/4MMnPOIFzc7qx++FKXfU9CItC/y?= =?Windows-1252?Q?cGXlRA1dOoA8MAeZKveMiPN8UpeOtfAL2D+zZy2IsnWfh90z3o8SFKqB?= =?Windows-1252?Q?+cI4AXy4UmZDoAjlg1sE3TITyE679SsuaQygUhzH+iOYIcNYWv2oceP+?= =?Windows-1252?Q?Vq3r2oW4MrA3xXxcGRFlakocaDdcJdADvoAPldRd/c3Ah7FgXGZVRSzE?= =?Windows-1252?Q?wNlFCHXBuhfjHaEUq/sw/3UeABgtmwYBy7P8xjPKO/7vzX53mNzp9yd7?= =?Windows-1252?Q?n2VEPdr7g7rV9gEfEElt45Q8XKyU95kCmAkZsV5mIlp57Y994rmTK4fE?= =?Windows-1252?Q?dlEZ3A2Or+g67UXBjqDYQGIkRj16Pcq4Hxv0ACSX64DS1yPbKDF8iBL4?= =?Windows-1252?Q?GXrjkHulQ99ma5yuNlgveDy2YP+ZFfbjnVpk99f9cMV/DOfFwpdQTwKQ?= =?Windows-1252?Q?tRWBSNcqk7uI0Nimq9bpLoS54gF2864x6LSpHK+3C/0rzddzVGebqx37?= =?Windows-1252?Q?rxlIOgbxBNntHR09kXvVeChjpowMSQvrX2du9+PWrpjGx/dN1XtVQPKq?= =?Windows-1252?Q?jzo7z7gHPJlSTE2tJEk/l1t1v/MsjPknkfPjedntfz+6yCD+t/1VsXZq?= =?Windows-1252?Q?rBVrUidYidTEdxP3OEbT+val769SJbnVzJfPtAaBl/edeO4YEgMUSMo8?= =?Windows-1252?Q?wHPWQ4uFnY6ePoQEma3/BuI6pCuNRR/6cWkYfAOWxMRD0Nj3zoNP4x4H?= =?Windows-1252?Q?5qANR+bVEqeTjuhL9dSEjAns7ZJuHIViI0+52RIgPfsUuewb2PPMSh6M?= =?Windows-1252?Q?uNYhDxWEGYK88TIkCVvBrmAXO7LqGkHUTfCEiQYyHuAjj4bP6ddKOmGW?= =?Windows-1252?Q?EgTIcbPCfozKMSbfy++ThNSkTvph3bro5EsTeyNB2jX6h2kDOwMKmMLw?= =?Windows-1252?Q?OM2CjzWAKmnB19RZptYugLTf5Aq5eYU3bKhn16oRbPJc/nYq5bE5N5qp?= =?Windows-1252?Q?EMF6LOt11rvQ8lTN2PYW0I4VOPfqjql24j0uBA9nto9DXr2plb+Qb1IA?= =?Windows-1252?Q?kJj6L4rspTuCpNLPchO0JavPbOBQeLUMpQtte1FIX//9REhGiDhNsEhZ?= =?Windows-1252?Q?7CfPgeb40+nr2m/iQjq8C+D7fVHO8uCjboov8b8CqddtuUt+Ze5PKDd/?= =?Windows-1252?Q?zZxzKJYZ9fwUMVnvT1zLrkAnBLUNM6C4YPeQeT+hBIR+4h8XRY13rL9h?= =?Windows-1252?Q?GzpO2tTaHhBI348z/SRZbyB4uCU2wH92re9?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2443; 6:YP7V1I95JBCRUXDSEUaPW0E4/xhsKRscgOzThkmtsY09ELl/GladkuhPKidVRNW3DUBocZ70zW1175VmIT8G9nSr3kz8gqwbgPhfVenQcpX2ChoJc1/IAbl0sH0hlEJ1nq+jTgExQtW0aT0QIjqxXCx7lZbfRqv1dwrgkzJX959IyoXYrXcYhPhPpNfw8qyW2ywRDMO/i/n3x0QkTRa+FXMDw4A0lcEYImLhrMAEso7W8Pijl8SoJXPrOJdRdlIdaj5yvhGrCElxZL9CM+Z98zu8ZcGa4BcWFfSqFIuDvcUrMlSjBwGlQeOiD6km/2XW; 5:rjagb07Q1jiC8GT9NN3GiLvEUxvWLUgyMRqymV+RyLDctu709oMam/6TLgR0VQLqosky3SLQ0j/RUGeAYqruYv1UqC0jA5+xV3U7OAjRadvNO/vpQB73x0gxtXntl1GB4teN84LW+PloxZuDCNoLW9M7zOR7GevYQZfHnHwDZYeKihUx0L6Qm59ATbrbLuQN; 24:nxmy+PfRMKz5l0n2Fpux+LKT0TIX8jTYR22T6mWmWnj+qOKNX/TEZoggkSWgSGlSNZHKUB+vDyU0CZIt4hkng1Fw506NW60v3e0eU3G7edc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2443; 7:wrOCLNPAPpBLpOIHhCC6PRo2X8CGQhdDmWprILSNTKlHGVchfLYamdWGGZxGj11RQAlrhiHgE/wFW6IE58qAMIMBumwGIgpieHu71YeAAFCRjJE1fGN/pgGOKnTTFlfudztTiIVuu2Fk3alfHmP7JhsvL45/jTj5j1wQGHBKTwh4wb6P8joXqTaM68BoghOGly7mpSbhBCKB+7a+mhLLSjO4KNUa8Yb8zo+hRnyNbvwI8dVkgOWbKn1ApvxOJJZXrcqeMxULPAUcPTQySNvJMemIFGmAjS5el61+FLkAnpCyBI1GnZ7jIwHYq6zse44MME4dmEpXQjhZX5YhkKXfNuPprUGf0lN9X1k+VeGyVwE= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2016 06:35:35.7685 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2443 Subject: Re: [dpdk-dev] [PATCH 1/3] eal/drivers: prefix driver REGISTER macros with EAL X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Oct 2016 06:35:38 -0000 On Monday 10 October 2016 06:26 PM, Neil Horman wrote: > On Sat, Oct 08, 2016 at 01:00:59PM +0000, Shreyansh Jain wrote: >> Hi Thomas, >> >>> -----Original Message----- >>> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] >>> Sent: Friday, October 07, 2016 7:22 PM >>> To: Shreyansh Jain >>> Cc: david.marchand@6wind.com; dev@dpdk.org >>> Subject: Re: [PATCH 1/3] eal/drivers: prefix driver REGISTER macros with EAL >>> >>> 2016-10-07 19:11, Shreyansh Jain: >>>> --- a/mk/internal/rte.compile-pre.mk >>>> +++ b/mk/internal/rte.compile-pre.mk >>>> @@ -87,7 +87,7 @@ endif >>>> PMDINFO_GEN = $(RTE_SDK_BIN)/app/dpdk-pmdinfogen $@ $@.pmd.c >>>> PMDINFO_CC = $(CC) $(CPPFLAGS) $(CFLAGS) -c -o $@.pmd.o $@.pmd.c >>>> PMDINFO_LD = $(CROSS)ld $(LDFLAGS) -r -o $@.o $@.pmd.o $@ >>>> -PMDINFO_TO_O = if grep -q 'DRIVER_REGISTER_.*(.*)' $<; then \ >>>> +PMDINFO_TO_O = if grep 'EAL_REGISTER_.*(.*)' $<; then \ >>>> echo "$(if $V,$(PMDINFO_GEN), PMDINFO $@.pmd.c)" && \ >>>> $(PMDINFO_GEN) && \ >>>> echo "$(if $V,$(PMDINFO_CC), CC $@.pmd.o)" && \ >>>> >>>> --->8--- >>>> CC eal_pci_vfio.o >>>> PMDINFO eal_pci_vfio.o.pmd.c >>>> /bin/sh: 1: >>>> /home/shreyansh/build/DPDK/02_dpdk/x86_64-native-linuxapp-gcc/app/dpdk- >>> pmdinfogen: >>>> not found >>>> /home/shreyansh/build/DPDK/02_dpdk/mk/internal/rte.compile-pre.mk:138: >>>> recipe for target 'eal_pci_vfio.o' failed >>>> --->8--- >>>> >>>> I don't think PMDINFO should be running on eal_pci_vfio file. Isn't it? >>> >>> Every files are scanned for the pattern. >> >> Sorry, I should have been clearer in my statement. >> I meant, I didn't think eal_pci_vfio.o had anything of interest for the PMD tool and hence the mk files would have skipped over it in absence of a match. >> I understand that PMDINFO would run on all files. >> > Thats incorrect, the Makefile does a REGEX search for appropriate registration > macros that imply the need for pmdinfo to run. If its running on an > inappropriate file its because your new macros inadvertently match the current > regex, hence my suggestion that the regex should be tuned to be more specific Agree. Thats is what I wanted to clarify as stated below: "...EAL_REGISTER_* (macro name has changed since) is matching EAL_REGISTER_TAILQ..". As for 'more specific' match - I did suggest [2] a longer more specific version but Thomas had a different view point [1]. You can have a look at [2] and let me know your suggestion or if that is wrong. [1] http://dpdk.org/ml/archives/dev/2016-October/048425.html [2] http://dpdk.org/ml/archives/dev/2016-October/048407.html > > Neil > >>> >>>> Is it because EAL_REGISTER_* is matching EAL_REGISTER_TAILQ like macro >>>> as well? >>> >>> Probably. >>> That's another argument in favor of good prefixes. >>> I think you should use RTE_DRIVER_REGISTER_ or better, RTE_PMD_REGISTER_ >> >> I thought of EAL_PMD_REGISTER_* but dropped it because for PCI_TABLE like macros, the name got really long (EAL_PMD_REGISTER_PCI_TABLE()). >> Anyways, I will use RTE_PMD_REGISTER_* now and send another version. >> >>>> >>>> I am not very well versed with how PMDINFO is linking with the build >>>> system so any hints/insight into this would be really helpful. >>>> >>>> One I get more clarity on this, I will push a new version of this patch. >>> >>> Thanks >> >> - >> Shreyansh >> > - Shreyansh