From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1D2E1A0545; Mon, 20 Jun 2022 12:57:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BD7EA40151; Mon, 20 Jun 2022 12:57:08 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id A262740150 for ; Mon, 20 Jun 2022 12:57:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655722627; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Qy0H5QqNRBSpFOAnCURPRjVHnlPhu67NeNObaGmB3Z4=; b=B293aoutAduPnQO0vlIEOzaWsyt6x561t5Zmp6/2CvJ+UfsLvIqXpZde6OQv9yLgng90AL Bsfdtplr76Ju6HI77D6SMFGSmaYLOz7QkSF6i8nvehI5llEZoh1bJSpqOFojJOmS/nBvhM HyaOTwfrJ80YqbT4PeUItJ6vUp4NZ/4= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-607-Rp9vgBroMq-Tzns53hPOIA-1; Mon, 20 Jun 2022 06:57:06 -0400 X-MC-Unique: Rp9vgBroMq-Tzns53hPOIA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7444C3817A60; Mon, 20 Jun 2022 10:57:05 +0000 (UTC) Received: from [10.39.208.29] (unknown [10.39.208.29]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DAB7E40CFD0A; Mon, 20 Jun 2022 10:57:03 +0000 (UTC) Message-ID: Date: Mon, 20 Jun 2022 12:57:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v4 08/15] vdpa/mlx5: add multi-thread management for configuration To: Li Zhang , orika@nvidia.com, viacheslavo@nvidia.com, matan@nvidia.com, shahafs@nvidia.com Cc: dev@dpdk.org, thomas@monjalon.net, rasland@nvidia.com, roniba@nvidia.com References: <20220408075606.33056-1-lizh@nvidia.com> <20220618090258.91157-1-lizh@nvidia.com> <20220618090258.91157-9-lizh@nvidia.com> From: Maxime Coquelin In-Reply-To: <20220618090258.91157-9-lizh@nvidia.com> X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/18/22 11:02, Li Zhang wrote: > The LM process includes a lot of objects creations and > destructions in the source and the destination servers. > As much as LM time increases, the packet drop of the VM increases. > To improve LM time need to parallel the configurations for mlx5 FW. > Add internal multi-thread management in the driver for it. > > A new devarg defines the number of threads and their CPU. > The management is shared between all the devices of the driver. > Since the event_core also affects the datapath events thread, > reduce the priority of the datapath event thread to > allow fast configuration of the devices doing the LM. > > Signed-off-by: Li Zhang > Acked-by: Matan Azrad > --- > doc/guides/vdpadevs/mlx5.rst | 11 +++ > drivers/vdpa/mlx5/meson.build | 1 + > drivers/vdpa/mlx5/mlx5_vdpa.c | 41 ++++++++ > drivers/vdpa/mlx5/mlx5_vdpa.h | 36 +++++++ > drivers/vdpa/mlx5/mlx5_vdpa_cthread.c | 129 ++++++++++++++++++++++++++ > drivers/vdpa/mlx5/mlx5_vdpa_event.c | 2 +- > drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 8 +- > 7 files changed, 223 insertions(+), 5 deletions(-) > create mode 100644 drivers/vdpa/mlx5/mlx5_vdpa_cthread.c > Reviewed-by: Maxime Coquelin Thanks, Maxime