From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 6CCB1A0C57;
Mon, 1 Nov 2021 13:49:04 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 2C1AA40E28;
Mon, 1 Nov 2021 13:49:04 +0100 (CET)
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
by mails.dpdk.org (Postfix) with ESMTP id 0330A40DF6
for <dev@dpdk.org>; Mon, 1 Nov 2021 13:49:02 +0100 (CET)
X-IronPort-AV: E=McAfee;i="6200,9189,10154"; a="254612768"
X-IronPort-AV: E=Sophos;i="5.87,199,1631602800"; d="scan'208";a="254612768"
Received: from orsmga006.jf.intel.com ([10.7.209.51])
by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
01 Nov 2021 05:48:44 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.87,199,1631602800"; d="scan'208";a="448939089"
Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83])
by orsmga006.jf.intel.com with ESMTP; 01 Nov 2021 05:48:44 -0700
Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by
fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2242.12; Mon, 1 Nov 2021 05:48:43 -0700
Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by
fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2242.12; Mon, 1 Nov 2021 05:48:42 -0700
Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by
fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2242.12 via Frontend Transport; Mon, 1 Nov 2021 05:48:42 -0700
Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100)
by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.1.2242.12; Mon, 1 Nov 2021 05:48:42 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=HFfrC/2t30TlcIo6FxrAHCseZB89G3EyaJ+tIZKvYmj3Cu6ufZq1So566FaPnbyrowsCM+njXYxgvcIar95BkLWK0Gr+77hp2RM1SY/igyliKJ77iET2OWjv/8WbFQ0kWmsVQjaiXT/cMHVsj4Dty1prr2wH5KG47EdkyjtNzZs8uXXcH/PQ39mJBXdr6dsYFU4ZZCzMjbT0RGZJdKKXAlCkaHnocGR/Ja7+RLQ3S+FIQRKwLKe+hHfZqiFttHAgeyJ+fht+NdFYVbuBTKnHNwAAnD+XOneocHqYKGgNrJBgR3gUNCqT+YP2jvvOpdXSiH28VVeVOaOPOCz54ST5xw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=L9ydE4T65Nf8I/Ff050BlHjaEp3b9BNAN+0KHdiTOwE=;
b=U7B2Dw1f/NlnyZmoqhLL3rFKInFWSUARWIQ55kR30R0eeix7RKRyCBCqYKLxb2Uw/C3o4VV+2Tx/L90z7MQi9UMwziE76mTvLt3cHVdoo8dV5vIQRg0CR2NF3Jdqf6+yZZ4mWvkQhRtxoGRF2LbIQCvCAnEqs75EZ3u7O7IuJUh55x3gUr0zEgi7zujhct8Bs/odyYfs9Lajc/dUtzrW/YAUPivj5BopBLvvnYE9Vl3vVHHxyJv32EBs01sbMdAUbBL7WcsIzu9FFpE40v1mWXLGVJd6b27qseIA9OvBz02AFxpm3uP8HiSd8kUjwyeI2RzZ4/99G6H5+VyZZ3MQQw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
dkim=pass header.d=intel.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;
s=selector2-intel-onmicrosoft-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=L9ydE4T65Nf8I/Ff050BlHjaEp3b9BNAN+0KHdiTOwE=;
b=u2VhZWkmyy+CpJemwuYMSPmDiRm/010a5hFOl/68l0xue4anxy2aVmr38R+TmeIg7HIPnPZT18SSREErdwNTGkMzXyI3BZiypLijpLVGyOPnz3V3Hu4xRzLBmL5sPDzKxspon2kOWc8wnGT8L2PRH6SGA2tmQEVoH2A/yFXu/BY=
Authentication-Results: trustnetic.com; dkim=none (message not signed)
header.d=none;trustnetic.com; dmarc=none action=none header.from=intel.com;
Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19)
by PH0PR11MB4918.namprd11.prod.outlook.com (2603:10b6:510:31::16)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14; Mon, 1 Nov
2021 12:48:41 +0000
Received: from PH0PR11MB5000.namprd11.prod.outlook.com
([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com
([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4649.019; Mon, 1 Nov 2021
12:48:41 +0000
Message-ID: <cba287c8-fdf1-d34f-cf1b-398b3b8de241@intel.com>
Date: Mon, 1 Nov 2021 12:48:35 +0000
Content-Language: en-US
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Jiawen Wu <jiawenwu@trustnetic.com>
CC: <dev@dpdk.org>
References: <20211022020243.2932559-1-ferruh.yigit@intel.com>
<20211022110314.470843-1-ferruh.yigit@intel.com>
<011301d7cf02$2f53bc20$8dfb3460$@trustnetic.com>
<4f7f64fa-dc6f-8725-3fd0-f3d41d0bce03@intel.com>
X-User: ferruhy
In-Reply-To: <4f7f64fa-dc6f-8725-3fd0-f3d41d0bce03@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: DB6PR0202CA0007.eurprd02.prod.outlook.com
(2603:10a6:4:29::17) To PH0PR11MB5000.namprd11.prod.outlook.com
(2603:10b6:510:41::19)
MIME-Version: 1.0
Received: from [192.168.0.206] (37.228.236.146) by
DB6PR0202CA0007.eurprd02.prod.outlook.com (2603:10a6:4:29::17) with Microsoft
SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.4649.14 via Frontend Transport; Mon, 1 Nov 2021 12:48:40 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9239e779-c595-4c77-7393-08d99d35ee6e
X-MS-TrafficTypeDiagnostic: PH0PR11MB4918:
X-Microsoft-Antispam-PRVS: <PH0PR11MB49180177AF1CC04E8656D207958A9@PH0PR11MB4918.namprd11.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1332;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: TL9SzIlcB9yvUqTSpoIjRwlBY7+osOHoErGciZHwSrwD1yCNJwsvkZBKs0NY4+7pepUdAnV+vrU5jBGBeWMsqP7Freji3oU5/XjKUUS5x73SHmtqhJjWUcSAUM1FadJ0SZ06P1EHcAIRzckZmpdRhSfDBKcUJ4fb/1/l6cUxl+Me5sqMlPKfgyuuSp0Ho3HEN11+KM8ykOFBUkTvE7Mp88OcyqnW5+z5o3LU4wM2Ty+HCqgBb14PuWq1eFRcl469vtmR6PwtYfITKUIQ+BJgIg+J3ebJjmIWGCZTAsQLOZTjEOAl53RITrHPtTB78Sj0ZVVKrD29kQyAIn1NN/19pRRSAOMTL9KFKxJUfmGSV8q7U1YAQFct1oiRcXjWi2G832dwLhNEY+tgDD+xQyb1zMJK+0msdFdldGEa0lbOVJSZVCW0v7HTaEUXrSc62V5qizNjI1RmWhD9T6ZBtLV9Xf4BRRNSk0djeXBl1/1pB6ty6Xf63wMqGoHblULV+VxtF+xGyqW8rqwlP0yGrMdoWE1qTNpheVhH3pn9pAPzfsxxlpF0YEWiS/RfGmgvSI4Nxzyu/jHGiQyNWOaFVEZT5SZ+uiTcF21f2C36MVDyhHDT+2zYUMzoAVu7TDZr2QJ13yr2TjStMY3XOHqsqGzC2/CNsv98qySshKU54n/9hANdVAOWKf0KNhJh29IU+CgYgf2e2K0Ma0VyyaeInwuJ6Q==
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE;
SFS:(366004)(66476007)(66556008)(38100700002)(53546011)(86362001)(44832011)(31696002)(66946007)(956004)(2616005)(16576012)(316002)(2906002)(6666004)(36756003)(26005)(186003)(8676002)(6916009)(4326008)(83380400001)(31686004)(82960400001)(508600001)(6486002)(5660300002)(8936002)(45980500001);
DIR:OUT; SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Qzk3S2RlOUYyT2FVL1REM1dmZ2luTVIzU0JrNUhXcXNrdm5LUVBTLzZnbm1t?=
=?utf-8?B?Tk9ncExYUG9jWGlyaFlNUVJ1Y0J1cjRiblpHSVlJbVN4WjZRQTk3N1c1VThr?=
=?utf-8?B?Z25YTWhZOFN5cWk0bG56Yk51VnFLaFM0cSs4dm5sOUgzalExbWlXczRHcklD?=
=?utf-8?B?NFlYMGdzUkcxYU5ManpvWHhEcVVOLzhsRzN0OHZhVHNQTWlmR0o3Rjh3MDdt?=
=?utf-8?B?NVVHeFBYWWZpSGlHdFl6b2pITkJ6S1FPcnpueDNZVGc3by9FbmE0SGdWTjEv?=
=?utf-8?B?NUl1dGZPQmxCZGJ5Z0JaT2hUbURYaS9ZRjUvN3RCZ1V6b3NHNTBIOGtBZHR6?=
=?utf-8?B?NjBIWnBnb3U3UEp6VG5wMCs5NEFkaTVRaEhFR0VpM3lnck15M1NwclltMGVW?=
=?utf-8?B?clhrMzUzbnZDanMyR1hBZklkT0JUS284VTNRNTViZjNFdHlrcHBSTnFRcW5P?=
=?utf-8?B?NFlCSzZraFNLU3Z5Q0tzWjFaZEhtaEVuZmlpbFF6UEN1V0lBeEhYMnV4ZHZL?=
=?utf-8?B?SHlQUmx6RFBQTGRGOW9UUG5DdTMvQWdMQlIrclVOeEdwcGhMNFdUdjB0dURl?=
=?utf-8?B?WnRLRytaUUphMFV5VjVHZDIzM3llaE5QekZpdmhWNktjVHQ2c29uYVhzUWQz?=
=?utf-8?B?cC9ySXphOXdLR1dKUTNvTXlXQUpQNnZ2UTRmWTVQVHRXUHNJNTAwZVMzUTVr?=
=?utf-8?B?b3o2VCs5ampkeGptcHFIbXFyOThVMk1NbzdCSDQwUmlncVZOVDIrOEwwczhK?=
=?utf-8?B?UURQUWlLRTY2bU04czMwVHZobWdnbXdkMFJmLyswMFg0bjZrbmtzR2RSVXV1?=
=?utf-8?B?Qk0vcFJtRy9UMGtaZjhwQTNXMTlwaURqMkdsejRBNEJyZU1CMXNOdk5MdWtN?=
=?utf-8?B?NVBRV3htUWlDWC9telNNZDJlSXpQYURkQUwrR2J5Uitnem1WRGRKVkpHVE5H?=
=?utf-8?B?NTFEeEovTEZpKzdvV2R3QjRSY1RWc0h6VFlCUWplakRYZlRRRTMvdEhJSjZF?=
=?utf-8?B?eHBVUWZBWEl5R0NnbDVReC9uZWNkZUNmSjlXK3pUaDlWcklWQkllM0RtaklZ?=
=?utf-8?B?eEZ3Vk82aFN4QVJ3bDNpMG9nNUY2UUdFNFNOT0cyZ1M5TXkxVy9DVTlEMnlj?=
=?utf-8?B?NE1SKzJrYVZQVzFoMnIvZmxXVXphM09DWXZ5ZlZhMnZiZU1SSUNlcW1PTDFx?=
=?utf-8?B?RFR0eXRmNU9wa3dEbisrTkJZZjB1WlY2Qk5JbVdJckE5M0kwQ0hwUjdOeXlU?=
=?utf-8?B?U2pMakZZSE01SmFQdXhGSUprTTd2L2VSclI1V2lQaXBNZFArMHdjOEJMMFBB?=
=?utf-8?B?K29UK1AwbGs2Q3VKcHFrWkVsZnBtV0tWcnJGRVJzV1l4akgzaWh4YUZUTEhz?=
=?utf-8?B?YkdLTXNmZnBBMDJEd2F6eVovL3B1VDJoV0xCd2kydmhUVVpnc1BRZkZyUEpy?=
=?utf-8?B?Q05NKzAzd1NLU1NkbnJZMmhCdTI4dlJQMVhrS1d1aWIwdGRjT2FQVTJ2MlFH?=
=?utf-8?B?QjVjM05YSGJDZGpaTllhbXMxUS80U2Jnc0dwM1RKbjFnUzFVV081cnFRbUh0?=
=?utf-8?B?YTJTRURkU1NJemJ3NUJVcXVXL0NKa1B6V2Q4UXUrU0RCOUl6VitFRE9EVzl0?=
=?utf-8?B?SmJoVFVpZ254RFhSOWs4ZXdmM2Q4cUtIdkhiTm9jUkFsTk5oZDE4dndUbHB6?=
=?utf-8?B?dDZaWHpyS0NsTGVyQm1mRGxLYlBsRVBCR1ZPYnllTkhaRzR6a3RqUmhKSWR0?=
=?utf-8?B?V05ZQnBibnIvWEp5ZlB6YWsvSHlvQlNSL3lIejhSV0xhL1lNZ21iSG5qUEJz?=
=?utf-8?B?LzNJZ0ZYTlBMNTJJN1I5ZWpRVEpUV0F5S1c4bTRNTjJva0llVnI0Y3NrVTdM?=
=?utf-8?B?b3dBa1JWeG9MeWcwL2ZJV2lFakNRUVEzS2JoNGlTV0J5bnJkSHVlTHlEbkxX?=
=?utf-8?B?ck5yZzlkMEpDR0l1VWYrWlhWN0lmMFNyYVEzd3lVRzhhcUpCY3pFUEZUOFhm?=
=?utf-8?B?eFU0OHBJVzFQVERMdkpIaUhmcWNOeDRvd25kZzdBeGV2OStHOVh5Q0FYd092?=
=?utf-8?B?MzExTG5IbEdKdHJXM1dJeWRqY3hDT2lBM0JoK2tIZ1dMR2psa2EvdW53NDJp?=
=?utf-8?B?dXpiTG1hVUFrbm5ZczRYaktnczArTmdCdGRTTmN4OXdkYURnMno4WkpZbE9t?=
=?utf-8?Q?unH4d5yZITh4zkykILVXZkU=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9239e779-c595-4c77-7393-08d99d35ee6e
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2021 12:48:41.1148 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: K8vwQuQAW8iGm0y79cefp/bnseoqMywJrpuhG+ITwEkJx46XXFpLTjexotUEk8ySs94KNcfCMNL884nrKmSdcQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4918
X-OriginatorOrg: intel.com
Subject: Re: [dpdk-dev] [PATCH v7] ethdev: add namespace
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On 11/1/2021 12:39 PM, Ferruh Yigit wrote:
> On 11/1/2021 9:23 AM, Jiawen Wu wrote:
>> On October 22, 2021 7:03 PM, Ferruh Yigit wrote:
>>>
>>> diff --git a/drivers/net/txgbe/txgbe_ethdev.c
>>> b/drivers/net/txgbe/txgbe_ethdev.c
>>> index 7b46ffb68635..0b0f9db7cb2a 100644
>>> --- a/drivers/net/txgbe/txgbe_ethdev.c
>>> +++ b/drivers/net/txgbe/txgbe_ethdev.c
>>> @@ -2695,11 +2695,11 @@ txgbe_dev_link_update_share(struct rte_eth_dev
>>> *dev,
>>> int wait = 1;
>>>
>>> memset(&link, 0, sizeof(link));
>>> - link.link_status = ETH_LINK_DOWN;
>>> - link.link_speed = ETH_SPEED_NUM_NONE;
>>> - link.link_duplex = ETH_LINK_HALF_DUPLEX;
>>> + link.link_status = RTE_ETH_LINK_DOWN;
>>> + link.link_speed = RTE_ETH_SPEED_NUM_NONE;
>>> + link.link_duplex = RTE_ETH_LINK_HALF_DUPLEX;
>>> link.link_autoneg = !(dev->data->dev_conf.link_speeds &
>>> - ETH_LINK_SPEED_FIXED);
>>> + RTE_ETH_LINK_AUTONEG);
>>>
>>
>> Hi Ferruh,
>> Is there some wrong that 'ETH_LINK_SPEED_FIXED' is changed to
>> auto-negotiation?
>>
>
> Not sure how it happened, but I will send a patch to fix it.
Ahh, there is another driver change [1] between this patch versions,
that seems lead the conflict resolve error.
[1]
Commit 196f0e123bcb ("net/txgbe: set fixed flag for exact link speed")
- link.link_autoneg = ETH_LINK_AUTONEG;
+ link.link_autoneg = !(dev->data->dev_conf.link_speeds &
+ ETH_LINK_SPEED_FIXED);