From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8035343FDA; Wed, 8 May 2024 11:10:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F0ADE40A6E; Wed, 8 May 2024 11:10:29 +0200 (CEST) Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by mails.dpdk.org (Postfix) with ESMTP id C70BF402AF for ; Wed, 8 May 2024 11:10:27 +0200 (CEST) Received: from mail.maildlp.com (unknown [172.19.163.44]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4VZ8Tc6lVLz1HBk1; Wed, 8 May 2024 17:09:08 +0800 (CST) Received: from dggpeml500024.china.huawei.com (unknown [7.185.36.10]) by mail.maildlp.com (Postfix) with ESMTPS id 92BBF140133; Wed, 8 May 2024 17:10:25 +0800 (CST) Received: from [10.67.121.161] (10.67.121.161) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 8 May 2024 17:10:25 +0800 Subject: Re: [PATCH v4 0/6] refine argparse library To: Thomas Monjalon CC: , References: <20240220131502.47510-1-fengchengwen@huawei.com> <20240318111838.16991-1-fengchengwen@huawei.com> <2817175.XrmoMso0CX@thomas> From: fengchengwen Message-ID: Date: Wed, 8 May 2024 17:10:25 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <2817175.XrmoMso0CX@thomas> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.121.161] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml500024.china.huawei.com (7.185.36.10) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Thomas, On 2024/3/22 1:27, Thomas Monjalon wrote: > 18/03/2024 12:18, Chengwen Feng: >> I found a couple of issues when I revisited the argparse_autotest >> output, so got this patchset. >> >> Chengwen Feng (6): >> argparse: refine error message >> argparse: remove dead code >> argparse: replace flag enum with marco >> argparse: fix argument flags operate as uint32 type >> test/argparse: refine testcases >> argparse: fix doc don't display two hyphens > > I'd like to get an approval from someone else for the API changes here. > I feel it is better to wait post 24.03. > Anyway it is a fresh experimental API. Could you review this patchset and merge? BTW: this patchset also fixes bug 1409 Thanks > > > > . >