From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.warmcat.com (mail.warmcat.com [163.172.24.82]) by dpdk.org (Postfix) with ESMTP id E392A1BB7C for ; Fri, 11 May 2018 02:30:11 +0200 (CEST) To: Stephen Hemminger Cc: Jerin Jacob , dev@dpdk.org References: <152591991920.119328.14523975619615362920.stgit@localhost.localdomain> <20180510061731.GB12718@jerin> <20180510091147.GA26838@jerin> <20180510115759.GA8776@jerin> <20180510080142.0c49116f@xeon-e3> From: Andy Green Message-ID: Date: Fri, 11 May 2018 08:29:35 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 In-Reply-To: <20180510080142.0c49116f@xeon-e3> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 00/40] Fix build on gcc8 and various bugs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 May 2018 00:30:12 -0000 On 05/10/2018 11:01 PM, Stephen Hemminger wrote: > On Thu, 10 May 2018 20:13:31 +0800 > Andy Green wrote: > >> I appreciate the reply. >> >> But why bother having a subject line at all if it is going to be >> mechanically enforced that nothing in it is allowed to be "useful"? >> That really doesn't make sense does it. > > > It was done because there were lots of clueless patches showing > up on the driver development list which had useless subject > lines. The "cure" is worse than the disease... - I can mention, eg, that something changed to an int. But a size_t or my_type_t? I am not allowed to mention it even if that is the whole reason for the patch. - I can mention most libc apis, but not those that happen to have an underscore, eg, timerfd_create(), even if that was the focus of the patch. - Any kind of manifest constant like MY_CONSTANT: illegal to mention, even if the patch's job is change MY_CONSTANT to, say, 5. What should I entitle that patch? "lib: change something to 5"? "lib: change MY.CONSTANT to 5"? - I can mention most filenames or paths, eg, down /proc, or myfile.c. But not if the filepath happens to contain an underscore. Even if the effect of the patch is to migrate stuff from myfile.c to my_files/ The results are arbitrary... please consider removing this now it has been in place a while and made its original point. -Andy