Re: [dpdk-dev] [PATCH] kni: fix ethtool build with kernel 4.11

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 5/3/2017 5:39 PM, Nicolas Dichtel wrote:
> Le 03/05/2017 à 18:00, Ferruh Yigit a écrit :
>> build error:
>> .../build/build/lib/librte_eal/linuxapp/kni/igb_main.c:1034:10:
>> error: implicit declaration of function ‘pci_enable_msix’
>> [-Werror=implicit-function-declaration]
>>     err = pci_enable_msix(pdev,
>>               ^~~~~~~~~~~~~~~
>>
>> This build error observed when CONFIG_RTE_KNI_KMOD_ETHTOOL config option
>> enabled.
>>
>> Following Linux commit removes the pci_enable_msix()
>> Linux: 4244de1c64de ("PCI: remove pci_enable_msix")
>>
>> Switch to pci_enable_msix_range() for kernel > 4.8 since current Linux
>> igb driver uses this function.
> When looking at the kernel patches, it seems that the way to go is to use
> pci_alloc_irq_vectors(), but it needs a bit more work.

I remember this from your igb_uio fix, but latest igb kernel driver uses
pci_enable_msix_range(), I found it easy and safe to replicate it.

We can update it when kernel igb driver updates the code, unless you
have a strong opinion to switch pci_alloc_irq_vectors() in advance?

Thanks,
ferruh

> 
> Exemple :
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=da6f4cf58e40
> 
> 
> Regards,
> Nicolas
>