From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Aaron Conole <aconole@redhat.com>, stable@dpdk.org
Cc: Alejandro Lucero <alejandro.lucero@netronome.com>,
Luca Boccassi <bluca@debian.org>,
Eelco Chaudron <echaudro@redhat.com>,
Yuanhan Liu <yliu@fridaylinux.org>,
dev@dpdk.org
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] nfp: restore the unlink operation
Date: Fri, 18 May 2018 10:48:16 +0100 [thread overview]
Message-ID: <cc273a83-fddf-e5a4-4abc-861037f60b7a@intel.com> (raw)
In-Reply-To: <20180514144658.9671-1-aconole@redhat.com>
On 5/14/2018 3:46 PM, Aaron Conole wrote:
> For the stable versions of DPDK, the NFP driver's NSP user space
> driver was modified to account for non-root usage. When that
> happened, commit 515933ad8385 ("nfp: allow for non-root user")
> inadvertently removed the unlink() call.
This patch is for stable tree.
Which stable branches are effected? Only 18.02?
And a generic stable tree question, is there a easy way to find out which stable
versions has a fix? For this example which versions get "nfp: allow for non-root
user" fix?
>
> Fixes: 515933ad8385 ("nfp: allow for non-root user")
> Cc: Alejandro Lucero <alejandro.lucero@netronome.com>
> Cc: Luca Boccassi <bluca@debian.org>
> Cc: Eelco Chaudron <echaudro@redhat.com>
> Cc: Yuanhan Liu <yliu@fridaylinux.org>
> Signed-off-by: Aaron Conole <aconole@redhat.com>
> ---
> drivers/net/nfp/nfp_nfpu.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/nfp/nfp_nfpu.c b/drivers/net/nfp/nfp_nfpu.c
> index ae2e07220..c003640c7 100644
> --- a/drivers/net/nfp/nfp_nfpu.c
> +++ b/drivers/net/nfp/nfp_nfpu.c
> @@ -121,5 +121,6 @@ nfpu_close(nfpu_desc_t *desc)
> close(desc->lock);
>
> nspu_get_lockfile_path(lockname, sizeof(lockname), desc);
> + unlink(lockname);
> return 0;
> }
>
next prev parent reply other threads:[~2018-05-18 9:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-14 14:46 [dpdk-dev] " Aaron Conole
2018-05-14 15:09 ` Eelco Chaudron
2018-05-18 8:45 ` Alejandro Lucero
2018-05-18 9:48 ` Ferruh Yigit [this message]
2018-05-18 13:11 ` [dpdk-dev] [dpdk-stable] " Aaron Conole
2018-05-18 13:22 ` [dpdk-dev] " Luca Boccassi
2018-05-18 15:57 ` Aaron Conole
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc273a83-fddf-e5a4-4abc-861037f60b7a@intel.com \
--to=ferruh.yigit@intel.com \
--cc=aconole@redhat.com \
--cc=alejandro.lucero@netronome.com \
--cc=bluca@debian.org \
--cc=dev@dpdk.org \
--cc=echaudro@redhat.com \
--cc=stable@dpdk.org \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).