From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B23A4A00BE; Thu, 10 Feb 2022 16:50:46 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4B0B5426EE; Thu, 10 Feb 2022 16:50:46 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 4F47C426ED for ; Thu, 10 Feb 2022 16:50:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644508244; x=1676044244; h=message-id:date:from:to:cc:references:subject: in-reply-to:content-transfer-encoding:mime-version; bh=NfHj77iwH+oDOTBtKeC8H9QSGXtP/L3FeNY9tqYggTQ=; b=aPU7ITcvwyx9JAoQVXfeZBW/sjoeEIM4sTwSYVK7drhfURsxv/JLJ6LV /1PxSiawWg1oIj7d7Gjjr1JYhkdvzk28UiT9lqP5DyjPHumiNOjsDbG2A ti3Y1ArijG8VOo0+tczLa2rTWTJul3Z1hGD0nBABVAxkOu/cY6ZLEj3c3 D/rxsoeiUHLotSZA0MMio3ZtM55Oqj5WzFP48Kmhl4JXzvN/37DB9Pbyp Lf3tncMjAGK4V00Kbl2T0o6/k06bxFwuBlzG4+xwbWr76Bb/IOVpWtTqf /Hg5OPYCTbqv3yPjqzSPrEGCPIlUO1EekcpKhKZntTe3ivKwNbncJ4MkW w==; X-IronPort-AV: E=McAfee;i="6200,9189,10254"; a="229485920" X-IronPort-AV: E=Sophos;i="5.88,359,1635231600"; d="scan'208";a="229485920" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2022 07:50:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,359,1635231600"; d="scan'208";a="773914663" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga005.fm.intel.com with ESMTP; 10 Feb 2022 07:50:42 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 10 Feb 2022 07:50:42 -0800 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 10 Feb 2022 07:50:42 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 10 Feb 2022 07:50:42 -0800 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.44) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 10 Feb 2022 07:50:40 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hsWTh9NzNV7HqgbJHwG4Gb8WtLsTxemovN1nzNdbFAruwCjehejKsvDQAZLk2POK4HH7RY349+TN1i82IsZQZ7fEBk71BrfsUKRByRRP/W4IwQaXJzVlnj/BqcQ9BsYBUVs0uabEFn2j056ugfkV3Z1v/WuLmvScUEPATPeFhwORB3Uc/EABKmMmaxrPEnYS/U5OuY4wwXlMQ7ZUWh2gah06TGlfTIapcBGq1UmezVesdk02+14SaXOnRpOlLlvWde3j+WzPR/5awSbEtxT/qhS8kB/RZ7lyFWRAvr96vzHvER/rRLrMEI7niLvyl3qvSd8QdPY4DbVIh52V+FhxBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Bvb5gdEjBwU20uZgwlMdDVRUzN8ajUBPmJIzdqEynJM=; b=jRzjdcv5b0COHNWBzeiZarg7/k+Z4Tb9sJ6j4azmec916/9vJNnJyqu5GApcs431ijIITrzOCdLMYjqaHHVaFHkZ8mf2o6w9r+fK3453gidjVTyJ85PwcabrfqEveXpZ1Cqg6fQDLDO8vvih8HHW+lwpa8DI9TS9Xc8CpRBlVIuNYSmPIvZc/XlIbnG/PXBt/vJ+PbgzN8frS8Zia2WGmzqQOlF/t/ufYlB3TjbSuh8Rqjdb9QwqEK2x+sGArAfxFr5EsmyiKfCki8kNHWQg5z7Nx5FmbjLXB/eYm0xrnZDvRvdYk1GRwgJKva0NXPlHEQ+aPjgxwQhGYNQgfBItgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by MW5PR11MB5860.namprd11.prod.outlook.com (2603:10b6:303:19f::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Thu, 10 Feb 2022 15:50:38 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4975.011; Thu, 10 Feb 2022 15:50:38 +0000 Message-ID: Date: Thu, 10 Feb 2022 15:50:32 +0000 Content-Language: en-US From: Ferruh Yigit To: "Min Hu (Connor)" , CC: =?UTF-8?Q?Morten_Br=c3=b8rup?= , Ray Kinsella , Ajit Khaparde , Thomas Monjalon , Andrew Rybchenko , David Marchand References: <20220111115437.32855-1-humin29@huawei.com> <20220209012106.23404-1-humin29@huawei.com> <60e29397-888b-0132-25b9-e9d470be3a5d@intel.com> <860bd211-e9cc-fb91-a6d5-553172f128d4@huawei.com> <3aca3a4c-3703-221b-ab88-524030ec18ab@intel.com> Subject: Re: [PATCH v3] ethdev: introduce dump API X-User: ferruhy In-Reply-To: <3aca3a4c-3703-221b-ab88-524030ec18ab@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0488.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13a::13) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 71d17f09-2d36-4de5-2d3f-08d9ecad152d X-MS-TrafficTypeDiagnostic: MW5PR11MB5860:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ncagFTSPzV3YHgyzZQdBrqLrgh5AIAHe3mvEDKKWwnvIbqKa6NnDSd3T4NeOn3jSQze1r7hhJ+IjDquR33+mHkt7pIQAr9T/1vqzFgwyH0JV7CLehHFSakLdA7L0juF6687efj6cVPzd71UHgQB4gCTOrD97PLHLiXo/PSQpm99qmDZ08eNMHWR2cacwFdOJekbOBXVTHq40Hn49HC05VjSX3mc1U5V32pN9WBh7yHDe2sWyA+fZTD8/9s6DwCABLjYzW2JhRGVNPHGaoKMSiNeOyRbIdRlLCyLdeb6VfHfiJYyH0rAS1noR7Au7Qcgm2AZlIG8vzWYqIAA/Uh3GcHtxFSOBNl48YVq+MPwYPMydLKsd1aHm4T/7BhYhANjDeyLxGdYnxso0Mx0r/btjubeYwZBLxJjIdTcLsVOf7YTlVNODqXsKdRxzMLAoqeyUU00zqCH56z+URyB8IinTHz5e89opOUW3UcQ9cL2rfQHfuRzB/aX/TLFXK79wsgB+X2RWyx/l/1Q9ygzMOygLN5RBPiX+XvtvBES7ovnYCNQsSEnalhdy6Gz9xrzPOGj1/yF/RNW33wq45akzVGHFfABg0Ru4bTr7YHBG0g5JhEr2nUZFAUW83HOmq5T4+cbMdhKwniBcRa7SL4RcC5at+UPKmmVuJQEbFmuwj6pREUh4k84u653S2yCXdgQHn8hqrpxZbhncf79CoMhyqxswwA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(54906003)(66574015)(36756003)(316002)(4326008)(2616005)(66946007)(44832011)(5660300002)(66476007)(66556008)(6666004)(8676002)(186003)(2906002)(26005)(83380400001)(6506007)(8936002)(55236004)(53546011)(508600001)(6486002)(6512007)(31686004)(82960400001)(31696002)(86362001)(38100700002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RTVMRDBraUhiRkM1V0lpbUkrdEpmaHlJcXd4NERyWk00KzdmeHl5OHpjK3ht?= =?utf-8?B?L3ZqNHVzUXBoOXo1Uy9LbTlwY2hYR0dQWXVpWjY5ejl5NDdMTTFRNmpFR3dI?= =?utf-8?B?bUI0Wm9UaDRJTmk3T0Rkdm9qSW04czNZV2crVzBYejlSZi82NlEza2tzcFdu?= =?utf-8?B?TXk1SmxrU3Evc3FZejZ5UEhUMFZxYkJVZGtxcWhMbDZORFFPdk40WklNZGZ1?= =?utf-8?B?SnF3Ti9RdzdIbzMyVG9CNFdxK0NTZE9TSGpSTUlvZFFiakxOL1FHRWpsczZo?= =?utf-8?B?VmtLMGJIcDJ5OVpnc0tJVnVwa0VKUjhnRFFMLzByTlZpdjdPVFpGR3p2dG5h?= =?utf-8?B?QnprTFNvRFdEVUtaa3B4ckRta1Q0cDZnQ010OWgrbldpTXNENy81UmhKVFEy?= =?utf-8?B?NVhXSFZFSDhseW1CS3p4WlNjaHBPN1ArR3dkNzh5YmdNL053L1VtTVlIcVhW?= =?utf-8?B?K3VOMmZSYU84VXBrN0ZIVnZrZTJlSjZTL09BNTkvNlNQT09CUE0yK2RsTVNh?= =?utf-8?B?M2owbVdvS0FjTmR5KzFzejQ4SHhjQXVIZ0lmckkvZmdYTHhGNTFJdVBNK20v?= =?utf-8?B?ajRMWHR5NTRnZDZ0R2pqMllhWUlNODU3R0xRVGV1aUVNYXN2d29kOE12Rno1?= =?utf-8?B?ajNaQ281aWU3TUZwZTQ5ZUc3OUxMcVQ4NTFlUHEvWE8rRGhhaUxnSFRqdTFh?= =?utf-8?B?TlNWc2hPdmFhU1crK1l1MHRyRnl2bGlZOFZkemxLRlBEVTlwQmp4Sy9PSU9R?= =?utf-8?B?ak95Ym1yeW1pZzF4NTU4c0xxNUVrTVN2WEJUblBvQURCOTVKbjBHblFUT3Yw?= =?utf-8?B?NTdUM2pqRUt2T0pzQ0RuZk56S3Axb0hTSVE1UlJaR3ZreG5oMHVBRzcxY09P?= =?utf-8?B?QlFVWHR6QlYxcFQ1M3NoUGdEbmc2dUdnUkdOK0xtQ0NpUVdJU2QzM29hQ204?= =?utf-8?B?WmNpWDRPUGtKcFRQelRZOWlXY0hFbnRSVW0yQU5sUHVhWU5sSjhuNWpnN3lw?= =?utf-8?B?N3lQWEVrRnlCNVJXVjJhSnFzclRxUW1HdjhBejFpYXlXUVNtWDFxVWNIZUN2?= =?utf-8?B?bVY3R3hERFVDZy95bjdyaGRjN0xlWTdxcDdoRHJLVWMyMGZ3WXZqbDdxc2ZH?= =?utf-8?B?YWRGdjdWS09YWkJmNFJWcFFtTmN4Z2FiOGxrUUhCNjQvZER2VWc4SUFMQjNX?= =?utf-8?B?K3l5bG9FTlV1OVVHcG12UHE0eEZzUGppUVFZV1hKcUZGTzIzY0tjSk9DWE93?= =?utf-8?B?NGgxMFFCczZxaHZKNkZHSXloVGhycUNLb01leDJiVGZXQmxpL0xwYURBcFpK?= =?utf-8?B?SjlzUUNESnVQdlJDdE9KampNZGtTTWhlMnJidGlxNlp1cFVSVy9SUjkxYkZH?= =?utf-8?B?NG1QNjVkd0tBWk55LzM4Y0hOQWRJTWJLY01aYkltWVVCdHQ0MXpWTzRHdG5h?= =?utf-8?B?TlpIM1NMZ3FBTGpvQlJsM1dTSytaWHFRTko1MW5hM2pBaWxPL09ja2tML0ly?= =?utf-8?B?SjhHaW1ENEFaQTJndGlzTmh1Z21YMmpEbXkvT2xwRUhyWXBESFYvdG1sMGpn?= =?utf-8?B?ck8xb2FpTDBFYmZPdWxiUzR2V2kyVlRNRmhkeWIwNmY4eTRacFdmWnNXaVJ1?= =?utf-8?B?SnJSdENkZ091ck9kdmxKbGZzSzBzWm9ON1pDYnMzZzdRT2lBR2hMU0d6eE4y?= =?utf-8?B?VXE5bDJkYWRVTk80UGpma21nRjJvY3F1QkdJZVRqUEUvRC9wekJabHR0RFZz?= =?utf-8?B?VWxBVDJqUnEycnF0V1lpR1BpM1RUdEd6eE5Td1lYRVNqRkU0TXVqRE8xeE1z?= =?utf-8?B?ZHhIbDlsTm9mN0V5YmxPdUY4U3EyMVlaTHdpZlNtNDNKRTZXQmpXVjhhR3Q2?= =?utf-8?B?MWVPV0FtU054RE0xNzhjb3UveE5sUjRNTHh1bHo0TGVqdzFZV2tWc0FBYVd5?= =?utf-8?B?TWpNMFRLYTZNYTArcmNIb3RNNFlKOWRwZ3pNSzdiSW5ESGZHbm9XeUN0NHp1?= =?utf-8?B?Mjg4a3FjWjNiS1RGTDVJZDRldUliUmZJMVJGTHNJN3RhUkYwWThXR1VhSWtk?= =?utf-8?B?REJWRCs3bFlvaHNHT3BQaG5jL1FQTTR4YUIxNTNVc3RqVTh0aFpPV2VkSUty?= =?utf-8?B?bWRaaCtKMHlCT1lsdGlsOEJzaVVlOTFoMUEwVlhsYThCV0R1bjg2c25FdnhC?= =?utf-8?Q?z9b+5PQbvbHUb5n70X73IHU=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 71d17f09-2d36-4de5-2d3f-08d9ecad152d X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2022 15:50:38.3414 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xhhMNvYDmp8oGWH9wiX2bvmmNCk3wA5n52128U3jrpTiZeTqpjlXLXYJZdcAo2TERkDpDjGmAdV/61i071qQ1A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR11MB5860 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/10/2022 1:22 PM, Ferruh Yigit wrote: > On 2/10/2022 1:16 PM, Min Hu (Connor) wrote: >> Hi, Ferruh, >> >> 在 2022/2/10 20:37, Ferruh Yigit 写道: >>> On 2/9/2022 1:21 AM, Min Hu (Connor) wrote: >>>> Added the ethdev dump API which provides querying private info from ethdev. >>>> There exists many private properties in different PMD drivers, such as >>>> adapter state, Rx/Tx func algorithm in hns3 PMD. The information of these >>>> properties is important for debug. As the information is private, the new >>>> API is introduced. >>>> >>>> Signed-off-by: Min Hu (Connor) >>>> Acked-by: Morten Brørup >>>> Acked-by: Ray Kinsella >>>> Acked-by: Ajit Khaparde >>>> --- >>>> v3: >>>> * change 'ethdev' to 'device' >>>> v2: >>>> * fixed comments from Ferruh. >>>> --- >>>>   doc/guides/rel_notes/release_22_03.rst |  7 +++++++ >>>>   lib/ethdev/ethdev_driver.h             | 23 +++++++++++++++++++++++ >>>>   lib/ethdev/rte_ethdev.c                | 17 +++++++++++++++++ >>>>   lib/ethdev/rte_ethdev.h                | 20 ++++++++++++++++++++ >>>>   lib/ethdev/version.map                 |  3 +++ >>> >>> >>> Btw, can you please confirm that there will be a PMD implementation >>> in this release, (it can be after -rc1)? > >> YES, I will send a set of patches about hns3 PMD implementation once the >> API is accepted. > > ack, thanks. > in fact process document [1] requires at least draft PMD implementation ready to apply the API change [2]. Can be possible to send a draft, simple PMD implementation tomorrow, to justify API design? It can be improved later after -rc1 with new versions. [1] doc/guides/contributing/patches.rst [2] * At least one PMD should implement the API. It may be a draft sent in a separate series.