From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E40B2A0543; Tue, 4 Oct 2022 10:31:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7C02740DDC; Tue, 4 Oct 2022 10:31:15 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id C4ECB40A87 for ; Tue, 4 Oct 2022 10:31:13 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 2DA545D; Tue, 4 Oct 2022 11:31:13 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 2DA545D DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1664872273; bh=J+JEC8PEN8EQ/fb6kCHWUlFof1eUAmiG7qa0X6lfE10=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=JHzg6sn35NWB92HrV9hHaa6fg9+hbL0q4ieyMQHBv7cCkAQV5lMXgCc4KRciywp4i PuMLwC4YlvTE6HoW7PgXOzUQbid688crQbfRtEcKsXaHoEHBbhAR6u04RSa7c6XI0o 4JYyQnEOEM0AExA2+uJsBiEFBiOrJZBgV/+ZvwYI= Message-ID: Date: Tue, 4 Oct 2022 11:31:12 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v3] ethdev: add hint when creating async transfer table Content-Language: en-US To: Rongwei Liu , matan@nvidia.com, viacheslavo@nvidia.com, orika@nvidia.com, thomas@monjalon.net, Aman Singh , Yuying Zhang , Ferruh Yigit Cc: dev@dpdk.org, rasland@nvidia.com References: <5d8d42b2-7011-cb46-7f2c-1b1019c4151e@oktetlabs.ru> <20220928092425.68214-1-rongweil@nvidia.com> From: Andrew Rybchenko Organization: OKTET Labs In-Reply-To: <20220928092425.68214-1-rongweil@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/28/22 12:24, Rongwei Liu wrote: > The transfer domain rule is able to match traffic wire/vf > origin and it means two directions' underlayer resource. > > In customer deployments, they usually match only one direction > traffic in single flow table: either from wire or from vf. > > Introduce one new member transfer_mode into rte_flow_template_table_attr > to indicate the flow table direction property: from wire, from vf > or bi-direction(default). > > It helps to save underlayer memory also on insertion rate, and this > new field doesn't expose any matching criteira. > > By default, the transfer domain is to match bi-direction traffic, and > no behavior changed. > > 1. Match wire origin only > flow template_table 0 create group 0 priority 0 transfer wire_orig... > 2. Match vf origin only > flow template_table 0 create group 0 priority 0 transfer vf_orig... Since wire_orig and vf_orig are just optional hints and not all PMDs are obliged to handle it, it does not impose any matching criteria. So, example above are misleading and you need to add pattern items to highlight that corresponding rules are really wire_orig or vf_orig. > > Signed-off-by: Rongwei Liu > Acked-by: Ori Kam [snip]