From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CDAC9A00BE; Tue, 29 Oct 2019 17:28:06 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0D6D41BEF0; Tue, 29 Oct 2019 17:28:06 +0100 (CET) Received: from dispatchb-us1.ppe-hosted.com (dispatchb-us1.ppe-hosted.com [148.163.129.53]) by dpdk.org (Postfix) with ESMTP id AB9A01BEED for ; Tue, 29 Oct 2019 17:28:04 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us5.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id D3403800078; Tue, 29 Oct 2019 16:28:02 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 29 Oct 2019 16:27:55 +0000 To: Stephen Hemminger , Ziyang Xuan CC: , , , , , References: <20191029085036.1a7b2fba@hermes.lan> From: Andrew Rybchenko Message-ID: Date: Tue, 29 Oct 2019 19:27:52 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191029085036.1a7b2fba@hermes.lan> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-25008.003 X-TM-AS-Result: No-5.362700-8.000000-10 X-TMASE-MatchedRID: 5+1rHnqhWUTmLzc6AOD8DfHkpkyUphL9LgJt/p5N7ynJfDUN5trKvvOP Ra/sN+oGJ2spf+DCeJy7SO9Tqhfeix+zr4ZrJWTd2bpX2XJNwqEZ9kiZvd+oBKS1C8QmZA9co8W MkQWv6iUDpAZ2/B/BlgJTU9F/2jaz3QfwsVk0UbuGrPnef/I+ejVqbiarfRbltokexDtTq8Jhef kIHVh6uy2eDjq0oKak6gsmHm5e1+w= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--5.362700-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-25008.003 X-MDID: 1572366483-1N8fOUxEkZyI Subject: Re: [dpdk-dev] [PATCH v6 11/15] net/hinic: add hinic PMD build and doc files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/29/19 6:50 PM, Stephen Hemminger wrote: > On Thu, 27 Jun 2019 16:18:20 +0800 > Ziyang Xuan wrote: > >> +# >> +# Compile burst-oriented HINIC PMD driver >> +# >> +CONFIG_RTE_LIBRTE_HINIC_PMD=n > The most common naming convention for drivers is: > CONFIG_RTE_LIBRTE_PMD_XXX > > so please use that. It looks like we really need some conventions for all future PMDs: $ git grep CONFIG_RTE_LIBRTE_PMD_ config/common_base | wc -l 59 $ git grep CONFIG_RTE_LIBRTE_.*_PMD= config/common_base  | wc -l 40