From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7B769A0562; Tue, 4 May 2021 09:50:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EB3184014D; Tue, 4 May 2021 09:50:55 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 2F08640147 for ; Tue, 4 May 2021 09:50:53 +0200 (CEST) IronPort-SDR: tOD71+nn375lsMdovjbx4rUuSW/LFWzxA+Zt6w9VTL1FOrfP6onXKbieFi3Y2AZ41Sg8iydZax hh/aFZvJYD4A== X-IronPort-AV: E=McAfee;i="6200,9189,9973"; a="218728598" X-IronPort-AV: E=Sophos;i="5.82,271,1613462400"; d="scan'208";a="218728598" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 May 2021 00:50:52 -0700 IronPort-SDR: 3jDlVs2se9MV9sDvXxb8yOrm8br/L/LAe2+8PKnOp4oIyV48hVDNonFctoztU/ercDf5CjjXTC eWwEDjlpFgVg== X-IronPort-AV: E=Sophos;i="5.82,271,1613462400"; d="scan'208";a="433156697" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.243.109]) ([10.213.243.109]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 May 2021 00:50:49 -0700 To: Ivan Malov , dev@dpdk.org Cc: Andrew Rybchenko References: <20210428094926.22185-1-ivan.malov@oktetlabs.ru> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Tue, 4 May 2021 08:50:44 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 1/3] common/sfc_efx/base: update MCDI headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/30/2021 6:05 PM, Ivan Malov wrote: > Hi Ferruh, > > These changes are imported. Furthermore, originally, these files are > auto-generated, so in order to fix spelling I can't just apply my edits to the > imported changes. The fixes are to be made in the original source, and I believe > this should be somehow discussed internally. > > So, the changeset is either to be applied "as it is" (meaning that the fixes are > expected to be submitted with future updates) or postponed. Maybe Andrew can > advise. > > Yes, I see the spelling warnings, they're pretty much valid. But some of them > are.. questionable. In particular, "misspelling" of the word HIST in > MC_CMD_LTSSM_HIST_MSGSET. For sure, the suggested replacement doesn't quite fit > the intended meaning of the macro. > You can ignore invalid warnings. > Thank you. > > On 30/04/2021 18:56, Ferruh Yigit wrote: >> On 4/28/2021 10:49 AM, Ivan Malov wrote: >>> From: Andrew Rybchenko >>> >>> Signed-off-by: Andrew Rybchenko >>> Signed-off-by: Ivan Malov >>> --- >>>   drivers/common/sfc_efx/base/efx_regs_mcdi.h   | 3509 +++++++++++++++-- >>>   .../common/sfc_efx/base/efx_regs_mcdi_aoe.h   |  142 +- >>>   .../common/sfc_efx/base/efx_regs_mcdi_strs.h  |    2 +- >>>   3 files changed, 3312 insertions(+), 341 deletions(-) >> >> Hi Ivan, >> >> There are some checkpatch spelling warnings, can you please check them? >> >> Also is there a versioning on the MCDI, if so you may want to document the >> updated version in driver guide and/or release notes. >> >