From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E79D5A052A; Mon, 25 Jan 2021 18:30:38 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D0952141120; Mon, 25 Jan 2021 18:30:38 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mails.dpdk.org (Postfix) with ESMTP id 7EEBE14112A for ; Mon, 25 Jan 2021 18:30:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611595836; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mUf6MN4old8QuLdO+6R1805H5BgLw1mVqrDKvHP10Oc=; b=ZDh4OxqTJQ+EaWR+CcW7aEJRFPVr7TeVixCRVNr4VJ0GkqB2tQyVSlYfA7F5tykAjEjui3 PDI8XLjdrajNf5n+JOfLM3CqKUFlgMKi/CFpZuH4+qm250HlqaBjVXzlBqj7G5YUTm0Jfd zvpnoEyA13INqACOAd69MN03Wdj+pBc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-524-FNIBhcfbMNeQUeCvQZeRug-1; Mon, 25 Jan 2021 12:30:35 -0500 X-MC-Unique: FNIBhcfbMNeQUeCvQZeRug-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2304D1934118; Mon, 25 Jan 2021 17:30:34 +0000 (UTC) Received: from [10.36.110.31] (unknown [10.36.110.31]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 392DF60C0F; Mon, 25 Jan 2021 17:30:33 +0000 (UTC) To: dev@dpdk.org, chenbo.xia@intel.com, amorenoz@redhat.com References: <20201222135658.53916-1-maxime.coquelin@redhat.com> From: Maxime Coquelin Message-ID: Date: Mon, 25 Jan 2021 18:30:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20201222135658.53916-1-maxime.coquelin@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 0/3] vhost: make virtqueue cache-friendly X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/22/20 2:56 PM, Maxime Coquelin wrote: > As done for Virtio PMD, this series improves cache utilization > of the vhost_virtqueue struct by removing unused field, > make the live-migration cache dynamically allocated at > live-migration setup time and by moving fields > around so that hot fields are on the first cachelines. > > With this series, The struct vhost_virtqueue size goes > from 832B (13 cachelines) down to 320B (5 cachelines). > > With this series and the virtio one, I measure a gain > of up to 8% in IO loop micro-benchmark with packed > ring, and 5% with split ring. > > I don't have a setup at hand to run PVP testing, but > it might be interresting to get the numbers as I > suspect the cache pressure is higher in this test as > in real use-cases. > > Maxime Coquelin (3): > vhost: remove unused Vhost virtqueue field > vhost: move dirty logging cache out of the virtqueue > vhost: optimize vhost virtqueue struct > > lib/librte_vhost/vhost.c | 14 +++++++-- > lib/librte_vhost/vhost.h | 54 +++++++++++++++++------------------ > lib/librte_vhost/vhost_user.c | 25 ++++++++++++++++ > 3 files changed, 64 insertions(+), 29 deletions(-) > Deferring to v21.05 release. Maxime