From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <patrick@patrickmacarthur.net>
Received: from plateau.patrickmacarthur.net (plateau.patrickmacarthur.net
 [174.138.60.243]) by dpdk.org (Postfix) with ESMTP id 523981B1A8;
 Thu, 21 Sep 2017 18:07:30 +0200 (CEST)
Received: from [132.177.127.174] (gtp127174.iol.unh.edu [132.177.127.174])
 by plateau.patrickmacarthur.net (Postfix) with ESMTPSA id EFF3ABE613;
 Thu, 21 Sep 2017 16:07:24 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=patrickmacarthur.net; s=mail; t=1506010045;
 bh=PXkVgQgPDwFpPLrT6IBcP6l6+X566wn1RuVuMax1VCI=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=qB07YU7bLU61mJsQHEUa79aRun8MtTjJVR5aFTs60bWD+H7Uw1bYeI73oKRL/Azkb
 fl4AuDmCIgML/WD6+rtOY8fbAFZL0wMPlPPQWBGEYKaZqlVjZf6gdzg3S6jmUVXSX3
 UaOgZbyxKQvYVcGnOf5ylw/JuNqbQSuTnes0H1mg=
To: Michal Jastrzebski <michalx.k.jastrzebski@intel.com>,
 anatoly.burakov@intel.com
Cc: dev@dpdk.org, deepak.k.jain@intel.com, Kuba Kozak
 <kubax.kozak@intel.com>, stable@dpdk.org
References: <1505901573-463-1-git-send-email-kubax.kozak@intel.com>
 <20170921134908.5076-1-michalx.k.jastrzebski@intel.com>
From: Patrick MacArthur <patrick@patrickmacarthur.net>
Message-ID: <cceb9c75-2aa5-8770-f8a4-967e04807efa@patrickmacarthur.net>
Date: Thu, 21 Sep 2017 12:07:24 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <20170921134908.5076-1-michalx.k.jastrzebski@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-1.1 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
 DKIM_VALID,DKIM_VALID_AU,URIBL_BLOCKED autolearn=ham autolearn_force=no
 version=3.4.1
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on
 plateau.patrickmacarthur.net
Subject: Re: [dpdk-dev] [PATCH v2] vfio: fix close unchecked file descriptor
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 21 Sep 2017 16:07:30 -0000

On 09/21/2017 09:49 AM, Michal Jastrzebski wrote:
> From: Kuba Kozak <kubax.kozak@intel.com>
> 
> Add file descriptor value check before calling close() function.
> 
> Coverity issue: 141297
> Fixes: 811b6b25060f ("vfio: fix file descriptor leak in multi-process")
> Cc: patrick@patrickmacarthur.net
> Cc: stable@dpdk.org
> 
> Signed-off-by: Kuba Kozak <kubax.kozak@intel.com>
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

FWIW:

Acked-by: Patrick MacArthur <patrick@patrickmacarthur.net>