From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6808CA04B5; Thu, 24 Sep 2020 16:47:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 914AD1C2FB; Thu, 24 Sep 2020 16:47:06 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 18C9C1C2F8 for ; Thu, 24 Sep 2020 16:47:04 +0200 (CEST) Received: from mx1-us1.ppe-hosted.com (unknown [10.7.65.60]) by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 9704160141; Thu, 24 Sep 2020 14:47:03 +0000 (UTC) Received: from us4-mdac16-2.ut7.mdlocal (unknown [10.7.65.70]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 9445F200AC; Thu, 24 Sep 2020 14:47:03 +0000 (UTC) X-Virus-Scanned: Proofpoint Essentials engine Received: from mx1-us1.ppe-hosted.com (unknown [10.7.66.39]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id D65E41C0053; Thu, 24 Sep 2020 14:47:02 +0000 (UTC) Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 24F8B80077; Thu, 24 Sep 2020 14:47:02 +0000 (UTC) Received: from [192.168.38.17] (10.17.10.39) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 24 Sep 2020 15:46:54 +0100 To: "Min Hu (Connor)" , CC: , , , References: <1599534347-20430-1-git-send-email-humin29@huawei.com> <1600952745-55993-1-git-send-email-humin29@huawei.com> <1600952745-55993-2-git-send-email-humin29@huawei.com> From: Andrew Rybchenko Autocrypt: addr=arybchenko@solarflare.com; keydata= mQINBF2681gBEACbdTxu8eLL3UX2oAelsnK9GkeaJeUYSOHPJQpV7RL/iaIskqTwBRnhjXt7 j9UEwGA+omnOmqQMpeQTb/F9Ma2dYE+Hw4/t/1KVjxr3ehFaASvwR4fWJfO4e2l/Rk4rG6Yi 5r6CWU2y8su2654Fr8KFc+cMGOAgKoZTZHZsRy5lHpMlemeF+VZkv8L5sYJWPnsypgqlCG3h v6lbtfZs+QqYbFH6bqoZwBAl5irmxywGR7ZJr1GLUZZ1lfdazSY8r6Vz0/Ip/KVxGu2uxo81 QCsAj0ZsQtwji9Sds/prTiPrIjx8Fc/tfbnAuVuPcnPbczwCJACzQr4q26XATL3kVuZhSBWh 4XfO/EAUuEq5AemUG5DDTM87g7Lp4eT9gMZB6P+rJwWPNWTiV3L7Cn+fO+l9mTPnOqdzBgDe OaulKiNSft1o0DY4bGzOmM2ad2cZt0jfnbMPMTE9zsr6+RFa+M8Ct20o6U1MUE4vP6veErMK of4kZ8PdoMM+Sq1hxMPNtlcVBSP9xMmdSZPlfDYI5VWosOceEcz7XZdjBJKdwKuz70V7eac4 ITSxgNFCTbeJ03zL2MR5s0IvD9ghISAwZ6ieCjU5UATn5+63qpD0nVNLsAdb/UpfvQcKAmvj 0fKlxu/PMVkjBa7/4cfNogYOhWDKUO+1pMaFwvb6/XTo6uMpfQARAQABtCxBbmRyZXcgUnli Y2hlbmtvIDxhcnliY2hlbmtvQHNvbGFyZmxhcmUuY29tPokCVAQTAQoAPhYhBP6NPgcKRj/Y X0yXQahue0sAy4m+BQJduvNYAhsDBQkB4TOABQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKhue0sAy4m+t3gP/j1MNc63CEozZo1IZ2UpVPAVWTYbLdPjIRdFqhlwvZYIgGIgIBk3ezKL K0/oc4ZeIwL6wQ5+V24ahuXvvcxLlKxfbJ6lo2iQGC7GLGhsDG9Y2k6sW13/sTJB/XuR2yov k5FtIgJ+aHa1PDZnepnGGOt9ka9n/Jzrc9WKYapOIIyLRe9U26ikoVgyqsD37PVeq5tLWHHA NGTUKupe9G6DFWidxx0KzyMoWDTbW2AWYcEmV2eQsgRT094AZwLFN5ErfefYzsGdO8TAUU9X YTiQN2MvP1pBxY/r0/5UfwV4UKBcR0S3ZvzyvrPoYER2Kxdf/qurx0Mn7StiCQ/JlNZb/GWQ TQ7huduuZHNQKWm7ufbqvKSfbPYvfl3akj7Wl8/zXhYdLqb5mmK45HXrgYGEqPN53OnK2Ngx IgYKEWr05KNv09097jLT5ONgYvszflqlLIzC4dV245g7ucuf9fYmsvmM1p/gFnOJBJL18YE5 P1fuGYNfLP+qp4WMiDqXlzaJfB4JcinyU49BXUj3Utd6f6sNBsO8YWcLbKBV9WmA324S3+wj f4NPRp3A5E+6OmTVMLWire2ZvnYp3YvifUj1r8lhoZ2B2vKuWwiTlHOKYBEjnOQJQnqYZEF0 JQQ1xzVDBQKE01BPlA3vy6BGWe6I4psBVqMOB9lAev/H+xa4u6Z3uQINBF269JsBEAC2KB3W 8JES/fh74avN7LOSdK4QA7gFIUQ4egVL81KnxquLzzilABuOhmZf3Rq6rMHSM8xmUAWa7Dkt YtzXStjEBI/uF0mAR3mMz1RcL2Wp+WD/15HjVpA7hPjXSEsWY0K2ymPerK4yrLcfFTHdMonY JfuACCC9NtOZxrWHOJoUS+RT7AWk80q/6D2iwQ47/2dBTznVG+gSeHSes9l91TB09w6f9JX/ sT+Ud0NQfm7HJ7t2pmGI9O6Po/NLZsDogmnIpJp/WwYOZN9JK7u2FyX2UyRzR8jK42aJkRsh DXs16Cc2/eYGakjrdO3x9a+RoxN7EuFtYhGR1PzMXdUiB5i+FyddYXkYUyO43QE/3VPA5l1v TUOagzZq6aONsdNonGJkV3TIG3JmUNtM+D/+r6QKzmgoJ8w576JxEZI09I/ZFN+g7BnUmlMx 6Z3IUOXVX/SWfGFga0YajwajHz03IBhChEbYbbqndVhmshu2GFURxrfUPYWdDXEqkh+08a5U Didia9jm2Opv4oE1e1TXAePyYJl/Zyps4Cv00GObAxibvMBQCUZQ+IBnNldRBOwXXRQV2xpx P+9iO1VYA/QXn0KqRK+SH1JGRXbJYi42YFaW1gE0EU0fiR2Wb9pK+doNEjjOhlzUGuvOEAUS +4m0m3dlfEvpCV9GMr7ERRpZzh9QkQARAQABiQI8BBgBCgAmFiEE/o0+BwpGP9hfTJdBqG57 SwDLib4FAl269JsCGwwFCQlmAYAACgkQqG57SwDLib7x6g//e+eCtNnJz7qFGbjWRJYNLCe5 gQwkhdyEGk4omr3VmjGj3z9kNFy/muh4pmHUngSAnnpwZggx14N4hhKf9y8G4Dwvsqa6b1zB Jq/c4t/SBDtGW4M/E331N04PaQZpcrbTfp1KqHNknk2N7yOk4CcoLVuIZmA5tPguASV8aAfz ZwhWAwn6vUEw9552eXEAnGFGDTCbyryNwzB5jtVQOEEDjTxcCkpcXMB45Tb1QUslRTu/sBAe HhPCQSUcJHR+KOq+P6yKICGAr291PZd6Qc7C3UyE+A3pY/UfdEVWj0STBWx1qvYLaHLrI4O9 KXDgh7luLjZZafcueCaPYmNo4V2lmNb3+7S4TvqhoZS+wN+9ldRQ4gH3wmRZybN6Y/ZCqxol RaZpE3AqdWsGvIgAkD0FpmtZNii9s2pnrhw0K6S4t4tYgXGTossxNSJUltfFQZdXM1xkZhtv dBZuUEectbZWuviGvQXahOMuH2pM64mx2hpdZzPcI2beeJNHkAsGT2KcaMETgvtHUBFRlLVB YxsUYz3UZmi2JSua4tbcGd6iWVN90eb8CxszYtivfpz6o2nPSjNwg0NaVGSHXjAK0tdByZ9t SkwjC3tEPljVycRSDpbauogOiAkvjENfaPd/H26V5hY822kaclaKDAW6ZG9UKiMijcAgb9u5 CJoOyqE8aGS5Ag0EXbr1RwEQAMXZHbafqmZiu6Kudp+Filgdkj2/XJva5Elv3fLfpXvhVt0Y if5Rzds3RpffoLQZk9nPwK8TbZFqNXPu7HSgg9AY7UdCM94WRFTkUCGKzbgiqGdXZ7Vyc8cy teGW+BcdfQycDvjfy50T3fO4kJNVp2LDNdknPaZVe8HJ80Od63+9ksB6Ni+EijMkh6Uk3ulB CSLnT4iFV57KgU2IsxOQVLnm+0bcsWMcCnGfphkY0yKP+aJ6MfmZkEeaDa7kf24N14ktg50m vOGDitcxA/+XXQXOsOIDJx1VeidxYsQ2FfsKu1G8+G6ejuaLf4rV5MI/+B/tfLbbOdikM5PF pxZVgTir9q13qHumMxdme7w5c7hybW412yWAe9TsrlXktFmFjRSFzAAxQhQSQxArS6db4oBk yeYJ59mW52i4occkimPWSm/raSgdSM+0P6zdWUlxxj+r1qiLgCYvruzLNtp5Nts5tR/HRQjE /ohQYaWDSVJEsc/4eGmgwzHzmvHtXeKkasn01381A1Lv3xwtpnfwERMAhxBZ8EGKEkc5gNdk vIPhknnGgPXqKmE1aWu8LcHiY+RHAF8gYPCDMuwyzBYnbiosKcicuIUp0Fj8XIaPao6F+WTi In4UOrqrYhsaCUvhVjsTBbNphGih9xbFJ8E+lkTLL8P3umtTcMPnpsB4xqcDABEBAAGJBHIE GAEKACYWIQT+jT4HCkY/2F9Ml0GobntLAMuJvgUCXbr1RwIbAgUJCWYBgAJACRCobntLAMuJ vsF0IAQZAQoAHRYhBNTYjdjWgdaEN5MrAN+9UR5r/4d3BQJduvVHAAoJEN+9UR5r/4d3EiQP /3lyby6v49HTU94Q2Fn2Xat6uifR7kWE5SO/1pUwYzx6v+z5K2jqPgqUYmuNoejcGl0CTNhg LbsxzUmAuf1OTAdE+ZYvOAjjKQhY4haxHc4enby/ltnHfWJYWJZ9UN5SsIQLvITvYu6rqthO CYjpXJhwkj3ODmC9H1TrvjrBGc6i7CTnR8RCjMEwCs2LI2frHa4R6imViEr9ScMfUnzdABMQ B0T5MOg8NX92/FRjTldU2KovG0ML9mSveSvVHAoEBLy4UIs5nEDdNiO1opJgKb5CXvWQugub 7AR52phNdKVdEB0S4tigJT4NalyTaPiUhFEm+CzZpMQDJ5E+/OowaPRfN4HeJX+c8sB+vUAZ mkAaG75N+IEk5JKFK9Z+bBYgPgaBDFZYdWDB/TMH0ANt+KI5uYg0i12TB4M8pwKG1DEPUmWc F2YpvB3jnbwzsOpSFiJOOlSs6nOB0Sb5GRtPOO3h6XGj+6mzQd6tcL63c9TrrUkjq7LDkxCz SJ2hTYRC8WNX8Uw9skWo5728JNrXdazEYCenUWmYiKLNKLslXCFodUCRDh/sUiyqRwS7PHEA LYC/UIWLMomI0Yvju3KA5v3RQVXhL+Gx2CzSj3GDz9xxGhJB2LfRfjzPbTR/Z27UpjCkd8z0 Ro3Ypmi1FLQwnRgoOKDbetTAIhugEShaLTITzJAP/iRDJCQsrZah5tE8oIl81qKEmBJEGcdt HYikbpQe7ydcXhqTj7+IECa3O7azI5OhCxUH2jNyonJ/phUslHH2G1TTBZK8y4Hrx5RpuRNS esn3P9uKu9DHqBAL7DMsCPwb2p1VNnapD72DBmRhzS/e6zS2R4+r9yNv03Hv7VCxKkmtE63H qpS//qpjfrtsIcHAjnKDaDtL1LYCtHoweI+DOpKKULSAYp/JE6F8LNibPQ0/P3S5ZIJNC4QZ uESjFOalJwFIqGQdkQB7ltRNJENLrHc+2jKGOuyFHm/Sbvp5EMGdaeQ0+u8CY0P+y6oXenwx 7WrJz/GvbNoFhJoJ6RzxCMQrFgxrssVZ7w5HcUj94lbnJ6osdYE/WpSd50B6jet6LKh5revg u9XI9CoqsPQ1V4wKYYdllPuogCye7KNYNKuiiuSNpaF4gHq1ZWGArwZtWHjgc2v3LegOpRQF SwOskMKmWsUyHIRMG1p8RpkBQTqY2rGSeUqPSvaqjT0nq+SUEM6qxEXD/2Wqri/X6bamuPDb S0PkBvFD2+0zr5Bc2YkMGPBYPNGZiTp3UjmZlLfn3TiBKIC92jherY563CULjSsiBEJCOSvv 4VPLn5aAcfbCXJnE3IGCp/hPl50iQqu7BPOYBbWXeb9ptDjGCAThNxSz0WAXkmcjAFE8gdE6 Znk9 Message-ID: Date: Thu, 24 Sep 2020 17:46:50 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <1600952745-55993-2-git-send-email-humin29@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.17.10.39] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.6.1012-25674.003 X-TM-AS-Result: No-16.662500-8.000000-10 X-TMASE-MatchedRID: IeZYkn8zfFrmLzc6AOD8DfHkpkyUphL9APiR4btCEeYMrRrnLCZEmmlp muYgAcs4dOoPdC4yUWizRs6JvWq9DKydbJHVd3oI0H8ihGEHNUd6QyBM5BtUWxw0HKhKjTfpm0Y WgfJf5dr1YHAY1rGxGV6iKClWgGXMvPkMPT62RvVX7UpJhGB2YmrNcACR7H8ig62QWKBoZ9TPSm XqL9sFGLeWF4GBKlt0H3y7OszTkqRx5hhUIjcbmqo2fOuRT7aay0Q+dW8+UWRXiLrvhpKLfIaAT SpziR3NlPevhG7KBdAszPf+RXWLtzNkf87O5ZmPnMQdNQ64xfd3ipg0lIGuKN9zZd3pUn7KaPML nExawDVbSHdN5creifA/Qs4OgRBV9WKY7y9mp3eInASnzB5VfFJAsn89ih94Bph69XjMbdlAHOg 8qEtqyKkOAx94vw/e57jS/hsxRY9bcZOtVr8VLqoNIG7S1SGvSkWlzdsmIx64zlF1pkNzlsbagK 1ZBOkXZV00PZUhlzR/smbFyZT8fHHj330r7L1gMiMrbc70Pffr+i+blgZMaXy/Hx1AgJrrO32Kd BHKAkwccm/HRMXhDE1yBvaom/V828kyIYAvAxrwqDryy7bDITRVNTvIvcOTDO+DX+rUwfYWkHqH AqxWxAu3bGAgWGF7KDEqaiZlkjhKQnPnTDdKkY4VSIjAMorObsFLINmYCfFQKAQSutQYXEidN4t JfaiRTIxGxG8pNg+q/NEcFlfF+RLwsVmbC9NrHcQQBuf4ZFsDvq08kg4qxVabQmUcC70BQBkp4e UF8b7P1b7ff0XTPQOw+nGDEPjvA1429wfIZESeAiCmPx4NwLTrdaH1ZWqC1B0Hk1Q1KyLgfCfWl nNb/1cppCzPq+1UOwBXM346/+w54BvEaptnb77Bt7Al76EXfIJeUo96eO0UIv2v2boXZ/LMeEQE 0ctt X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--16.662500-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.6.1012-25674.003 X-MDID: 1600958823-QK8CUVmPrc3K Subject: Re: [dpdk-dev] [PATCH V12 1/4] ethdev: introduce FEC API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/24/20 4:05 PM, Min Hu (Connor) wrote: > This patch adds Forward error correction(FEC) support for ethdev. > Introduce APIs which support query and config FEC information in > hardware. Almost good now. See my notes below. Many thanks for hard work and patience. > > Signed-off-by: Min Hu (Connor) > Reviewed-by: Wei Hu (Xavier) > Reviewed-by: Chengwen Feng > Reviewed-by: Chengchang Tang > Reviewed-by: Ajit Khaparde > Acked-by: Konstantin Ananyev I think that tags for Ajit and Konstantin should be dropped, since API changes significantly after their review. > --- > v10->v11: > allow to report capabilities per link speed. > specify what should be reported if link is down > when get FEC. > change mode to capa bitmask. > > --- > v9->v10: > add macro RTE_ETH_FEC_MODE_CAPA_MASK(x) to indicate > different FEC mode capa. > > --- > v8->v9: > added reviewed-by and acked-by. > > --- > v7->v8: > put AUTO just after NOFEC in rte_fec_mode definition. > > --- > v6->v7: > deleted RTE_ETH_FEC_NUM to prevent ABI breakage. > add new macro to indicate translation from fec mode > to capa. > > --- > v5->v6: > modified release notes. > deleted check duplicated for FEC API > fixed code styles according to DPDK coding style. > added _eth prefix. > > --- > v4->v5: > Modifies FEC capa definitions using macros. > Add RTE_ prefix for public FEC mode enum. > add release notes about FEC for dpdk20_11. > > --- > v2->v3: > add function return value "-ENOTSUP" for API. > > --- > lib/librte_ethdev/rte_ethdev.c | 37 +++++++++++++ > lib/librte_ethdev/rte_ethdev.h | 91 ++++++++++++++++++++++++++++++++ > lib/librte_ethdev/rte_ethdev_driver.h | 82 ++++++++++++++++++++++++++++ > lib/librte_ethdev/rte_ethdev_version.map | 3 ++ > 4 files changed, 213 insertions(+) > > diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c > index dfe5c1b..b614bfc 100644 > --- a/lib/librte_ethdev/rte_ethdev.c > +++ b/lib/librte_ethdev/rte_ethdev.c > @@ -3679,6 +3679,43 @@ rte_eth_led_off(uint16_t port_id) > return eth_err(port_id, (*dev->dev_ops->dev_led_off)(dev)); > } > > +int > +rte_eth_fec_get_capability(uint16_t port_id, uint32_t *num, > + struct rte_eth_fec_capa *speed_fec_capa) > +{ > + struct rte_eth_dev *dev; > + > + if (num == NULL || speed_fec_capa == NULL) > + return -EINVAL; I think it is OK to have speed_fec_cap==NULL if *num is 0. I.e. a request to get number of required array entries. > + > + RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); > + dev = &rte_eth_devices[port_id]; > + RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->fec_get_capability, -ENOTSUP); > + return eth_err(port_id, (*dev->dev_ops->fec_get_capability)(dev, num, > + speed_fec_capa)); > +} > + > +int > +rte_eth_fec_get(uint16_t port_id, uint32_t *mode) > +{ > + struct rte_eth_dev *dev; I think it would be good to check that mode is not NULL here. > + > + RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); > + dev = &rte_eth_devices[port_id]; > + RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->fec_get, -ENOTSUP); > + return eth_err(port_id, (*dev->dev_ops->fec_get)(dev, mode)); > +} > + > +int > +rte_eth_fec_set(uint16_t port_id, uint32_t mode) > +{ > + struct rte_eth_dev *dev; > + > + dev = &rte_eth_devices[port_id]; > + RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->fec_set, -ENOTSUP); > + return eth_err(port_id, (*dev->dev_ops->fec_set)(dev, mode)); > +} > + > /* > * Returns index into MAC address array of addr. Use 00:00:00:00:00:00 to find > * an empty spot. > diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h > index 645a186..104181d 100644 > --- a/lib/librte_ethdev/rte_ethdev.h > +++ b/lib/librte_ethdev/rte_ethdev.h > @@ -1544,6 +1544,29 @@ struct rte_eth_dcb_info { > struct rte_eth_dcb_tc_queue_mapping tc_queue; > }; > > +/** > + * This enum indicates the possible (forward error correction)FEC modes (forward error correction)FEC -> Forward Error Correction (FEC) > + * of an ethdev port. > + */ > +enum rte_eth_fec_mode { > + RTE_ETH_FEC_NOFEC = 0, /**< FEC is off */ > + RTE_ETH_FEC_AUTO, /**< FEC autonegotiation modes */ > + RTE_ETH_FEC_BASER, /**< FEC using common algorithm */ > + RTE_ETH_FEC_RS, /**< FEC using RS algorithm */ > +}; > + > +/* Translate from FEC mode to FEC capa */ > +#define RTE_ETH_FEC_MODE_TO_CAPA(x) (1U << (x)) > + > +/* This macro indicates FEC capa mask*/ Add missing space before */ > +#define RTE_ETH_FEC_MODE_CAPA_MASK(x) (1U << (RTE_ETH_FEC_ ## x)) > + > +/* A structure used to get capabilities per link speed */ > +struct rte_eth_fec_capa { > + uint32_t speed; /**< Link speed (see ETH_SPEED_NUM_*) */ > + uint32_t capa; /**< FEC capabilities bitmask (see RTE_FEC_CAPA_*) */ > +}; > + > #define RTE_ETH_ALL RTE_MAX_ETHPORTS > > /* Macros to check for valid port */ > @@ -3397,6 +3420,74 @@ int rte_eth_led_on(uint16_t port_id); > int rte_eth_led_off(uint16_t port_id); > > /** > + * @warning > + * @b EXPERIMENTAL: this API may change, or be removed, without prior notice > + * > + * Get Forward Error Correction(FEC) capability. > + * > + * @param port_id > + * The port identifier of the Ethernet device. > + * @param num > + * the num is in/out with a number of elements in an array. Please, see below my notes on callback description. > + * @param speed_fec_capa > + * speed_fec_capa is out only with per-speed capabilities. > + * > + * @return > + * - (0) if successful. > + * - (-ENOTSUP) if underlying hardware OR driver doesn't support. > + * that operation. > + * - (-EIO) if device is removed. > + * - (-ENODEV) if *port_id* invalid. > + * - (-EINVAL) if *num* or *speed_fec_capa* invalid > + */ > +__rte_experimental > +int rte_eth_fec_get_capability(uint16_t port_id, uint32_t *num, > + struct rte_eth_fec_capa *speed_fec_capa); > + > +/** > + * @warning > + * @b EXPERIMENTAL: this API may change, or be removed, without prior notice > + * > + * Get current Forward Error Correction(FEC) mode. > + * If link is down and AUTO is enabled, AUTO is returned, otherwise, > + * configured FEC mode is returned. > + * If link is up, current FEC mode is returned. > + * > + * @param port_id > + * The port identifier of the Ethernet device. > + * @param mode > + * returns the FEC mode from the device. > + * @return > + * - (0) if successful. > + * - (-ENOTSUP) if underlying hardware OR driver doesn't support. > + * that operation. > + * - (-EIO) if device is removed. > + * - (-ENODEV) if *port_id* invalid. > + */ > +__rte_experimental > +int rte_eth_fec_get(uint16_t port_id, uint32_t *mode); > + > +/** > + * @warning > + * @b EXPERIMENTAL: this API may change, or be removed, without prior notice > + * > + * Set Forward Error Correction(FEC) mode. > + * > + * @param port_id > + * The port identifier of the Ethernet device. > + * @param mode > + * the FEC mode. See below. > + * @return > + * - (0) if successful. > + * - (-EINVAL) if the FEC mode is not valid. > + * - (-ENOTSUP) if underlying hardware OR driver doesn't support. > + * - (-EIO) if device is removed. > + * - (-ENODEV) if *port_id* invalid. > + */ > +__rte_experimental > +int rte_eth_fec_set(uint16_t port_id, uint32_t mode); > + > +/** > * Get current status of the Ethernet link flow control for Ethernet device > * > * @param port_id > diff --git a/lib/librte_ethdev/rte_ethdev_driver.h b/lib/librte_ethdev/rte_ethdev_driver.h > index 23cc1e0..625b8c5 100644 > --- a/lib/librte_ethdev/rte_ethdev_driver.h > +++ b/lib/librte_ethdev/rte_ethdev_driver.h > @@ -575,6 +575,81 @@ typedef int (*eth_tx_hairpin_queue_setup_t) > const struct rte_eth_hairpin_conf *hairpin_conf); > > /** > + * @internal > + * Get Forward Error Correction(FEC) capability. > + * > + * @param dev > + * ethdev handle of port. > + * @param num > + * the num is in/out with a number of elements in an array. I'm sorry, I should do it before my previous suggestion, but: Looking at rte_eth_xstats_get_names() and trying to be consistent I'd like to suggest to put the argument after speed_fec_capa and make it input only with a number of array elements. Positive return values should be used to provide number of filled in array elements. If the returned value is greater than 'num', just provided elements are filled in, but it is indication as well, that num is too small. > + * @param speed_fec_capa > + * speed_fec_capa is out only with per-speed capabilities. > + * > + * @return > + * Negative errno value on error, 0 on success. > + * > + * @retval 0 > + * Success, get FEC success. See above. > + * @retval -ENOTSUP > + * operation is not supported. Should start from upper case letter > + * @retval -EIO > + * device is removed. Should start from upper case letter > + * @retval -ENODEV > + * Device is gone. What's the difference between "device is remove" and "Device is gone" > + * @retval -EINVAL > + * *num* or *speed_fec_capa* invalid. > + */ > +typedef int (*eth_fec_get_capability_t)(struct rte_eth_dev *dev, uint32_t *num, > + struct rte_eth_fec_capa *speed_fec_capa); > + > +/** > + * @internal > + * Get Forward Error Correction(FEC) mode. > + * > + * @param dev > + * ethdev handle of port. > + * @param mode > + * returns the FEC mode from the device. > + * > + * @return > + * Negative errno value on error, 0 on success. > + * > + * @retval 0 > + * Success, get FEC success. > + * @retval -ENOTSUP > + * operation is not supported. Should start from upper case letter > + * @retval -EIO > + * device is removed. Should start from upper case letter > + * @retval -ENODEV > + * Device is gone. > + */ > +typedef int (*eth_fec_get_t)(struct rte_eth_dev *dev, > + uint32_t *mode); > + > +/** > + * @internal > + * Set Forward Error Correction(FEC) mode. Remove extra spaces before "Set" > + * > + * @param dev > + * ethdev handle of port. > + * @param mode > + * the FEC mode. The description is insufficient and misleading. It should be fec_capa and described as: Bitmask of allowed FEC modes. If must be only one if AUTO is disabled. If AUTO is enabled, other bits specify FEC modes which may be negotiated. > + * > + * @return > + * Negative errno value on error, 0 on success. > + * > + * @retval 0 > + * Success, set FEC success. > + * @retval -ENOTSUP > + * operation is not supported. Should start from upper case letter What about -EINVAL in the case of unsupported FEC mode requested? It is listed above in API function but missing here. > + * @retval -EIO > + * device is removed. Should start from upper case letter > + * @retval -ENODEV > + * Device is gone. What's the difference between "device is remove" and "Device is gone" > + */ > +typedef int (*eth_fec_set_t)(struct rte_eth_dev *dev, uint32_t mode); > + > +/** > * @internal A structure containing the functions exported by an Ethernet driver. > */ > struct eth_dev_ops { > @@ -713,6 +788,13 @@ struct eth_dev_ops { > /**< Set up device RX hairpin queue. */ > eth_tx_hairpin_queue_setup_t tx_hairpin_queue_setup; > /**< Set up device TX hairpin queue. */ > + > + eth_fec_get_capability_t fec_get_capability; > + /**< Get Forward Error Correction(FEC) capability; */ It should be a dot (.) at the end, not semicolon (;). > + eth_fec_get_t fec_get; > + /**< Get Forward Error Correction(FEC) mode; */ same > + eth_fec_set_t fec_set; > + /**< Set Forward Error Correction(FEC) mode; */ same > }; > > /** > diff --git a/lib/librte_ethdev/rte_ethdev_version.map b/lib/librte_ethdev/rte_ethdev_version.map > index c95ef51..b9ace3a 100644 > --- a/lib/librte_ethdev/rte_ethdev_version.map > +++ b/lib/librte_ethdev/rte_ethdev_version.map > @@ -229,6 +229,9 @@ EXPERIMENTAL { > # added in 20.11 > rte_eth_link_speed_to_str; > rte_eth_link_to_str; > + rte_eth_fec_get_capability; > + rte_eth_fec_get; > + rte_eth_fec_set; > }; > > INTERNAL { >