From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
by dpdk.org (Postfix) with ESMTP id 3A69854AE
for <dev@dpdk.org>; Wed, 6 Mar 2019 13:31:19 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga004.jf.intel.com ([10.7.209.38])
by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
06 Mar 2019 04:31:18 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.58,447,1544515200"; d="scan'208";a="280218994"
Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.252.14.113])
([10.252.14.113])
by orsmga004.jf.intel.com with ESMTP; 06 Mar 2019 04:31:15 -0800
To: Rosen Xu <rosen.xu@intel.com>, dev@dpdk.org
Cc: tianfei.zhang@intel.com, dan.wei@intel.com, andy.pei@intel.com,
qiming.yang@intel.com, haiyue.wang@intel.com, santos.chen@intel.com,
zhang.zhang@intel.com, Hemant Agrawal <hemant.agrawal@nxp.com>,
Shreyansh Jain <shreyansh.jain@nxp.com>
References: <1551338000-120348-1-git-send-email-rosen.xu@intel.com>
<1551338000-120348-5-git-send-email-rosen.xu@intel.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Openpgp: preference=signencrypt
Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata=
mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy
qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ
+iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9
GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb
+dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF
YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy
ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX
CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1
1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz
cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln
aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJVBBMBAgA/AhsDBgsJCAcDAgYVCAIJCgsE
FgIDAQIeAQIXgBYhBNI2U4dCLsKE45mBx/kz60PfE2EfBQJbughWBQkHwjOGAAoJEPkz60Pf
E2Eft84QAIbKWqhgqRfoiw/BbXbA1+qm2o4UgkCRQ0yJgt9QsnbpOmPKydHH0ixCliNz1J8e
mRXCkMini1bTpnzp7spOjQGLeAFkNFz6BMq8YF2mVWbGEDE9WgnAxZdi0eLY7ZQnHbE6AxKL
SXmpe9INb6z3ztseFt7mqje/W/6DWYIMnH3Yz9KzxujFWDcq8UCAvPkxVQXLTMpauhFgYeEx
Nub5HbvhxTfUkapLwRQsSd/HbywzqZ3s/bbYMjj5JO3tgMiM9g9HOjv1G2f1dQjHi5YQiTZl
1eIIqQ3pTic6ROaiZqNmQFXPsoOOFfXF8nN2zg8kl/sSdoXWHhama5hbwwtl1vdaygQYlmdK
H2ueiFh/UvT3WG3waNv2eZiEbHV8Rk52Xyn2w1G90lV0fYC6Ket1Xjoch7kjwbx793Kz/RfQ
rmBY8/S4DTGn3oq3dMdQY+b6+7VMUeLMMh2CXYO9ErkOq+qNTD1IY+cBAkXnaDbQfz0zbste
ZGWH74FAZ9nCpDOqbRTrBL42aMGhfOWEyeA1x7+hl6JZfabBWAuf4nnCXuorKHzBXTrf7u7p
fXsKQClWRW77PF1VmzrtKNVSytQAmlCWApQIw20AarFipXmVdIjHmJPU611WoyxZPb4JTOxx
5cv9B+nr/RIB+v5dcStyHCCwO1be7nBDdCgd4F6kTQPLuQINBFfWTL4BEACnNA29e8TarUsB
L5n6eLZHXcFvVwNLVlirWOClHXf44o2KnN3ww+eBEmKVfEFo9MSuGDNHS8Zw1NiGMYxLIUgd
U6gGrVVs/VrQWL82pbMk6jCj98N+BXIri+6K1z+AImz7ax7iF1kDgRAnFWU0znWWBgM2mM8Y
gDjcxfXk4sCKnvf6Gjo08Ey5zmqx7dekAKU2EEp8Q1EJY3jbymLdZWRP4AFFMTS1rGMk0/tt
v71NBg1GobCcbNfn9chK/jhqxYhAJqq86RdJQkt3/9x1U1Oq0vXCt4JVVHmkxePtUiuWTTt+
aYlUAsKYZsWvncExvw77x2ArYDmaK0yfjh37wp0lY7DOJHFxoyT8tyWZlLci/VMRG2Ja33xj
0CN4C1yBg+QDeV3QFxQo42iA/ykdXPUR3ezmsND3XKvVLTC4DNb3V/EZQ7jBj64+bEK0VW4G
B31VP00ApNQvSoczsIOAKdk97RNbpmPw6q10ILIB+9T1xbnFYzshzGF17oC0/GENIHATx8vZ
masOZoDiOZQpeneLgnFE9JfzhLTxv6wNZcc/HLXRQVTkDsQr8ERtkAoHCf1E5+b5Yr7pfnE4
YuhET746o25S53ELUYPIs49qoJsEJL34/oexMfPGyPIlrbufiNyty5jc/1MRwUlhJlJ5IOHy
ZUa+6CLR7GdImusFkPJUJwARAQABiQI8BBgBAgAmAhsMFiEE0jZTh0IuwoTjmYHH+TPrQ98T
YR8FAlu6CHAFCQXE7zIACgkQ+TPrQ98TYR9nXxAAqNBgkYNyGuWUuy0GwDQCbu3iiMyH1+D7
llafPcK4NYy1Z4AYuVwC9nmLaoj+ozdqS3ncRo57ncRsKEJC46nDJJZYZ5LSJVn63Y3NBF86
lxQAgjj2oyZEwaLKtKbAFsXL43jv1pUGgSvWwYtDwHITXXFQto9rZEuUDRFSx4sg9OR+Q6/6
LY+nQQ3OdHlBkflzYMPcWgDcvcTAO6yasLEUf7UcYoSWTyMYjLB4QuNlXzTswzGVMssJF/vo
V8lD1eqqaSUWG3STF6GVLQOr1NLvN5+kUBiEStHFxBpgSCvYY9sNV8FS6N24CAWMBl+10W+D
2h1yiiP5dOdPcBDYKsgqDD91/sP0WdyMJkwdQJtD49f9f+lYloxHnSAxMleOpyscg1pldw+i
mPaUY1bmIknLhhkqfMmjywQOXpac5LRMibAAYkcB8v7y3kwELnt8mhqqZy6LUsqcWygNbH/W
K3GGt5tRpeIXeJ25x8gg5EBQ0Jnvp/IbBYQfPLtXH0Myq2QuAhk/1q2yEIbVjS+7iowEZNyE
56K63WBJxsJPB2mvmLgn98GqB4G6GufP1ndS0XDti/2K0o8rep9xoY/JDGi0n0L0tk9BHyoP
Y7kaEpu7UyY3nVdRLe5H1/MnFG8hdJ97WqnPS0buYZlrbTV0nRFL/NI2VABl18vEEXvNQiO+ vM8=
Message-ID: <cd07c5db-d155-702e-616d-98e2be0c83df@intel.com>
Date: Wed, 6 Mar 2019 12:31:14 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
Thunderbird/60.5.2
MIME-Version: 1.0
In-Reply-To: <1551338000-120348-5-git-send-email-rosen.xu@intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH v1 04/11] drivers/raw/ifpga_rawdev: add
IPN3KE support for IFPGA Rawdev
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Mar 2019 12:31:19 -0000
On 2/28/2019 7:13 AM, Rosen Xu wrote:
> Add Intel FPGA Acceleration NIC IPN3KE support for IFPGA Rawdev.
>
> Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> Signed-off-by: Tianfei Zhang <tianfei.zhang@intel.com>
> Signed-off-by: Andy Pei <andy.pei@intel.com>
<...>
> +static int
> +ifgpa_rawdev_get_attr(struct rte_rawdev *dev,
> + const char *attr_name,
> + uint64_t *attr_value)
> +{
> + struct ifpga_rawdev_mac_info *mac_info;
> + struct ifpga_rawdevg_retimer_info *retimer_info;
> + struct opae_retimer_info or_info;
> + struct opae_adapter *adapter;
> + struct opae_manager *mgr;
> + struct ifpga_rawdevg_link_info *linfo;
> + struct opae_retimer_status rstatus;
> +
> + IFPGA_RAWDEV_PMD_FUNC_TRACE();
> +
> + if (!dev || !attr_name || !attr_value) {
> + IFPGA_BUS_ERR("Invalid arguments for getting attributes");
> + return -1;
> + }
> +
> + adapter = ifpga_rawdev_get_priv(dev);
> + if (!adapter)
> + return -1;
> +
> + mgr = opae_adapter_get_mgr(adapter);
> + if (!mgr)
> + return -1;
> +
> + if (!strcmp(attr_name, "retimer_info")) {
> + retimer_info = (struct ifpga_rawdevg_retimer_info *)attr_value;
How you are using the 'get_attr' & 'set_attr' is a little odd.
I think the intention with these APIs to provide a map/dictionary like data
structure, save/get 'attr_values' by 'attr_name'.
How you are using is, instead of getting 'attr_value', you are passing valid
pointers via 'attr_value' and make this function to fill that struct. Why you
don't have a specific function for this purpose instead of using 'get_attr' &
'set_attr' ops? I believe this will be source of confusion in long term.
> + if (opae_manager_get_retimer_info(mgr, &or_info))
> + return -1;
> +
> + retimer_info->retimer_num = or_info.num_retimer;
> + retimer_info->port_num = or_info.num_port;
> + switch (or_info.support_speed) {
> + case MXD_10GB:
> + retimer_info->mac_type =
> + IFPGA_RAWDEV_RETIMER_MAC_TYPE_10GE_XFI;
> + break;
> + case MXD_25GB:
> + retimer_info->mac_type =
> + IFPGA_RAWDEV_RETIMER_MAC_TYPE_25GE_25GAUI;
> + break;
> + case MXD_40GB:
> + retimer_info->mac_type =
> + IFPGA_RAWDEVG_RETIMER_MAC_TYPE_40GE_XLAUI;
> + break;
> + case MXD_100GB:
> + retimer_info->mac_type =
> + IFPGA_RAWDEV_RETIMER_MAC_TYPE_100GE_CAUI;
> + break;
> + default:
> + retimer_info->mac_type =
> + IFPGA_RAWDEV_RETIMER_MAC_TYPE_UNKNOWN;
> + break;
> + }
> + return 0;
> + } else if (!strcmp(attr_name, "default_mac")) {
> + /* not implement by MAX */
> + mac_info = (struct ifpga_rawdev_mac_info *)attr_value;
> + mac_info->addr.addr_bytes[0] = 0;
> + mac_info->addr.addr_bytes[1] = 0;
> + mac_info->addr.addr_bytes[2] = 0;
> + mac_info->addr.addr_bytes[3] = 0;
> + mac_info->addr.addr_bytes[4] = 0;
> + mac_info->addr.addr_bytes[5] = 0xA + mac_info->port_id;
> +
> + return 0;
> + } else if (!strcmp(attr_name, "retimer_linkstatus")) {
> + linfo = (struct ifpga_rawdevg_link_info *)attr_value;
> + linfo->link_up = 0;
> + linfo->link_speed = IFPGA_RAWDEV_LINK_SPEED_UNKNOWN;
> +
> + if (opae_manager_get_retimer_status(mgr, linfo->port, &rstatus))
> + return -1;
> +
> + linfo->link_up = rstatus.line_link;
> + switch (rstatus.speed) {
> + case MXD_10GB:
> + linfo->link_speed =
> + IFPGA_RAWDEV_LINK_SPEED_10GB;
> + break;
> + case MXD_25GB:
> + linfo->link_speed =
> + IFPGA_RAWDEV_LINK_SPEED_25GB;
> + break;
> + case MXD_40GB:
> + linfo->link_speed =
> + IFPGA_RAWDEV_LINK_SPEED_40GB;
> + break;
> + default:
> + linfo->link_speed =
> + IFPGA_RAWDEV_LINK_SPEED_UNKNOWN;
> + break;
> + }
> +
> + return 0;
> + } else
> + return -1;
> +
> + /* Attribute not found */
> + return -1;
> +}
> +
> +static int ifgpa_rawdev_set_attr(struct rte_rawdev *dev,
> + const char *attr_name,
> + const uint64_t attr_value)
> +{
> + struct opae_adapter *adapter;
> + struct opae_manager *mgr;
> + /*struct ifpga_rawdevg_link_info *linfo;*/
> + /*struct opae_retimer_status rstatus;*/
Please remove commented out code.
> +
> + IFPGA_RAWDEV_PMD_FUNC_TRACE();
> +
> + if (!dev || !attr_name) {
> + IFPGA_BUS_ERR("Invalid arguments for setting attributes");
> + return -1;
> + }
> +
> + adapter = ifpga_rawdev_get_priv(dev);
> + if (!adapter)
> + return -1;
> +
> + mgr = opae_adapter_get_mgr(adapter);
> + if (!mgr)
> + return -1;
nothing done with 'adapter' & 'mgr' ? Why getting them?
> +
> + if (!strcmp(attr_name, "retimer_linkstatus"))
> + printf("ifgpa_rawdev_set_attr_func %lx\n", attr_value);
%lx usage is wrong for 32bits, it is giving a build warning [1], also please
don't use 'printf' for logging.
And why there is a specific check for a value and log, in a generic function
like set_attr?
[1]
.../drivers/raw/ifpga_rawdev/ifpga_rawdev.c: In function ‘ifgpa_rawdev_set_attr’:
.../drivers/raw/ifpga_rawdev/ifpga_rawdev.c:465:40: error: format ‘%lx’ expects
argument of type ‘long unsigned int’, but argument 2 has type ‘uint64_t’ {aka
‘const long long unsigned int’} [-We$
ror=format=]
printf("ifgpa_rawdev_set_attr_func %lx\n", attr_value);
~~^ ~~~~~~~~~~
%llx
> +
> + return -1;
Will function always fail?
And are you aware the you did not set anything in this function? Just ignored
the 'attr_value'?
<...>
> @@ -419,7 +559,7 @@
>
> rawdev->dev_ops = &ifpga_rawdev_ops;
> rawdev->device = &pci_dev->device;
> - rawdev->driver_name = pci_dev->device.driver->name;
> + rawdev->driver_name = pci_dev->driver->driver.name;
They are both same right?
<...>
> +
> +#include <rte_ether.h>
> +
> +#ifndef ETH_ALEN
> +#define ETH_ALEN 6
> +#endif
You can use "ETHER_ADDR_LEN" instead, it is defined in above included
'rte_ether.h' header.