* [dpdk-dev] [PATCH] examples/ethtool: fix 2 typos
@ 2019-02-25 19:21 Rami Rosen
2019-02-26 11:09 ` Remy Horton
0 siblings, 1 reply; 3+ messages in thread
From: Rami Rosen @ 2019-02-25 19:21 UTC (permalink / raw)
To: dev; +Cc: stable, remy.horton, Rami Rosen
This patch fixes 2 typos in examples/ethtool:
There is no such thing as ethtool_ops::get_driverinfo
It should be get_drvinfo:
see include/linux/ethtool.h in the kernel tree.
rte_net_change_mtu should be ndo_change_mtu:
see include/linux/netdevice.h in the kernel tree.
Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample application")
Cc: stable@dpdk.org
Signed-off-by: Rami Rosen <ramirose@gmail.com>
---
examples/ethtool/lib/rte_ethtool.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/examples/ethtool/lib/rte_ethtool.h b/examples/ethtool/lib/rte_ethtool.h
index 43adc97a3..31cd5ae4e 100644
--- a/examples/ethtool/lib/rte_ethtool.h
+++ b/examples/ethtool/lib/rte_ethtool.h
@@ -9,7 +9,7 @@
* This new interface is designed to provide a user-space shim layer for
* Ethtool and Netdevice op API.
*
- * rte_ethtool_get_driver: ethtool_ops::get_driverinfo
+ * rte_ethtool_get_driver: ethtool_ops::get_drvinfo
* rte_ethtool_get_link: ethtool_ops::get_link
* rte_ethtool_get_regs_len: ethtool_ops::get_regs_len
* rte_ethtool_get_regs: ethtool_ops::get_regs
@@ -23,7 +23,7 @@
* rte_ethtool_net_stop: net_device_ops::ndo_stop
* rte_ethtool_net_set_mac_addr: net_device_ops::ndo_set_mac_address
* rte_ethtool_net_validate_addr: net_device_ops::ndo_validate_addr
- * rte_ethtool_net_change_mtu: net_device_ops::rte_net_change_mtu
+ * rte_ethtool_net_change_mtu: net_device_ops::ndo_change_mtu
* rte_ethtool_net_get_stats64: net_device_ops::ndo_get_stats64
* rte_ethtool_net_vlan_rx_add_vid net_device_ops::ndo_vlan_rx_add_vid
* rte_ethtool_net_vlan_rx_kill_vid net_device_ops::ndo_vlan_rx_kill_vid
--
2.19.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] examples/ethtool: fix 2 typos
2019-02-25 19:21 [dpdk-dev] [PATCH] examples/ethtool: fix 2 typos Rami Rosen
@ 2019-02-26 11:09 ` Remy Horton
2019-03-05 10:50 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Remy Horton @ 2019-02-26 11:09 UTC (permalink / raw)
To: Rami Rosen, dev; +Cc: stable
On 25/02/2019 19:21, Rami Rosen wrote:
[snip]
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
> ---
> examples/ethtool/lib/rte_ethtool.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Acked-by: Remy Horton <remy.horton@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] examples/ethtool: fix 2 typos
2019-02-26 11:09 ` Remy Horton
@ 2019-03-05 10:50 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2019-03-05 10:50 UTC (permalink / raw)
To: Remy Horton, Rami Rosen, dev; +Cc: stable
On 2/26/2019 11:09 AM, Remy Horton wrote:
>
> On 25/02/2019 19:21, Rami Rosen wrote:
> [snip]
>> Signed-off-by: Rami Rosen <ramirose@gmail.com>
>> ---
>> examples/ethtool/lib/rte_ethtool.h | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Acked-by: Remy Horton <remy.horton@intel.com>
>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-05 10:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-25 19:21 [dpdk-dev] [PATCH] examples/ethtool: fix 2 typos Rami Rosen
2019-02-26 11:09 ` Remy Horton
2019-03-05 10:50 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).