From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 005F5A0C4B; Tue, 27 Jul 2021 05:57:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 79B05410ED; Tue, 27 Jul 2021 05:57:08 +0200 (CEST) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 0FEA2410EC for <dev@dpdk.org>; Tue, 27 Jul 2021 05:57:05 +0200 (CEST) Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4GYjZS1Q7FzcjH1; Tue, 27 Jul 2021 11:53:36 +0800 (CST) Received: from dggpeml500024.china.huawei.com (7.185.36.10) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 27 Jul 2021 11:57:03 +0800 Received: from [10.40.190.165] (10.40.190.165) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 27 Jul 2021 11:57:03 +0800 To: Bruce Richardson <bruce.richardson@intel.com>, <jerinj@marvell.com>, <jerinjacobk@gmail.com>, <mb@smartsharesystems.com> CC: <thomas@monjalon.net>, <ferruh.yigit@intel.com>, <andrew.rybchenko@oktetlabs.ru>, <dev@dpdk.org>, <nipun.gupta@nxp.com>, <hemant.agrawal@nxp.com>, <maxime.coquelin@redhat.com>, <honnappa.nagarahalli@arm.com>, <david.marchand@redhat.com>, <sburla@marvell.com>, <pkapoor@marvell.com>, <konstantin.ananyev@intel.com> References: <1625231891-2963-1-git-send-email-fengchengwen@huawei.com> <1626785182-2973-1-git-send-email-fengchengwen@huawei.com> <6d6bc86b-0bda-bd76-4a31-5d67c0299442@huawei.com> <YP5y3VlHbr51mcU0@bricha3-MOBL.ger.corp.intel.com> From: fengchengwen <fengchengwen@huawei.com> Message-ID: <cd4c186c-cc58-574e-002b-b140bc682167@huawei.com> Date: Tue, 27 Jul 2021 11:57:02 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <YP5y3VlHbr51mcU0@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.40.190.165] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v10] dmadev: introduce DMA device library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Thanks The first two point (STATUS_UNKNOWN->STATUS_ERROR_UNKNOWN, INVALID_ADDR) already fix in V11. @Burce @Jerin @Morten In addition, programming guide is added in v11, please take a look, thanks. On 2021/7/26 16:31, Bruce Richardson wrote: > On Mon, Jul 26, 2021 at 02:53:16PM +0800, fengchengwen wrote: >> Friendly ping. >> >> On 2021/7/20 20:46, Chengwen Feng wrote: >>> This patch introduce 'dmadevice' which is a generic type of DMA >>> device. >>> >>> The APIs of dmadev library exposes some generic operations which can >>> enable configuration and I/O with the DMA devices. >>> >>> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com> >>> --- >>> v10: >>> * fix rte_dmadev_completed_status comment. >> >> [snip] > > I'm still working through porting over our driver(s) to the latest revisions, > and digging into the details of the error handling and approaches, looking > for any issues. For now, a couple of small suggestions and ideas: > > * for the STATUS_UNKNOWN value, I think it should be renamed to > ERROR_UNKNOWN since this is an error value. Alternatively, add a new > "UNKNOWN_ERROR" entry in the list to cover this possibility i.e. we know > status is an error, just not exactly what the error is. > > * While we have errors for both invalid source or invalid destination > addresses, I think we also should add a slightly more general error code > for "INVALID_ADDR" to cover the case where one is bad but we are not sure > which. > > * Not sure exactly how to handle this, but I suspect we may need some sort > of capability flag to cover behaviour on hitting an error. For HW using > our original ioat driver, the jobs are done strictly in order and the HW > will halt on error, while with hardware using newer idxd driver, things are > done potentially out-of-order and other jobs continue after the failed > job. I will come back with a more concrete proposal on this later, once I > get both drivers up and working. I suspect we will encounter more > edge-cases like this as people work on drivers. > > Overall, functionally this patchset looks pretty good to me. One thing > that will be needed for merge into mainline is a chapter on dmadev for the > programmers guide document, plus any other necessary doc updates such as a > good release-note update for this new lib. > > For what is here now though, > > Acked-by: Bruce Richardson <bruce.richardson@intel.com> > > . >