From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 3CE7E1B8CD for ; Tue, 26 Jun 2018 17:40:24 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jun 2018 08:40:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,274,1526367600"; d="scan'208";a="235745243" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.83]) ([10.237.221.83]) by orsmga005.jf.intel.com with ESMTP; 26 Jun 2018 08:40:22 -0700 To: Shahaf Shuler , Pavan Nikhilesh , "jerin.jacob@caviumnetworks.com" , "gaetan.rivet@6wind.com" , Thomas Monjalon Cc: "dev@dpdk.org" References: <20180615044359.20692-1-pbhagavatula@caviumnetworks.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= xsFNBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABzSVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+wsF+BBMBAgAoAhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgAUCWZR3VQUJB33WBQAKCRD5M+tD3xNhH6DWEACVhEb8q1epPwZrUDoxzu7E TS1b8tmabOmnjXZRs6+EXgUVHkp2xxkCfDmL3pa5bC0G/74aJnWjNsdvE05V1cb4YK4kRQ62 FwDQ+hlrFrwFB3PtDZk1tpkzCRHvJgnIil+0MuEh32Y57ig6hy8yO8ql7Lohyrnpfk/nNpm4 jQGEF5qEeHcEFe1AZQlPHN/STno8NZSz2nl0b2cw+cujN1krmvB52Ah/2KugQ6pprVyrGrzB c34ZQO9OsmSjJlETCZk6EZzuhfe16iqBFbOSadi9sPcJRwaUQBid+xdFWl7GQ8qC3zNPibSF HmU43yBZUqJDZlhIcl6/cFpOSjv2sDWdtjEXTDn5y/0FsuY0mFE78ItC4kCTIVk17VZoywcd fmbbnwOSWzDq7hiUYuQGkIudJw5k/A1CMsyLkoUEGN3sLfsw6KASgS4XrrmPO4UVr3mH5bP1 yC7i1OVNpzvOxtahmzm481ID8sk72GC2RktTOHb0cX+qdoiMMfYgo3wRRDYCBt6YoGYUxF1p msjocXyqToKhhnFbXLaZlVfnQ9i2i8jsj9SKig+ewC2p3lkPj6ncye9q95bzhmUeJO6sFhJg Hiz6syOMg8yCcq60j07airybAuHIDNFWk0gaWAmtHZxLObZx2PVn2nv9kLYGohFekw0AOsIW ta++5m48dnCoAc7BTQRX1ky+ARAApzQNvXvE2q1LAS+Z+ni2R13Bb1cDS1ZYq1jgpR13+OKN ipzd8MPngRJilXxBaPTErhgzR0vGcNTYhjGMSyFIHVOoBq1VbP1a0Fi/NqWzJOowo/fDfgVy K4vuitc/gCJs+2se4hdZA4EQJxVlNM51lgYDNpjPGIA43MX15OLAip73+ho6NPBMuc5qse3X pAClNhBKfENRCWN428pi3WVkT+ABRTE0taxjJNP7bb+9TQYNRqGwnGzX5/XISv44asWIQCaq vOkXSUJLd//cdVNTqtL1wreCVVR5pMXj7VIrlk07fmmJVALCmGbFr53BMb8O+8dgK2A5mitM n44d+8KdJWOwziRxcaMk/LclmZS3Iv1TERtiWt98Y9AjeAtcgYPkA3ld0BcUKONogP8pHVz1 Ed3s5rDQ91yr1S0wuAzW91fxGUO4wY+uPmxCtFVuBgd9VT9NAKTUL0qHM7CDgCnZPe0TW6Zj 8OqtdCCyAfvU9cW5xWM7Icxhde6AtPxhDSBwE8fL2ZmrDmaA4jmUKXp3i4JxRPSX84S08b+s DWXHPxy10UFU5A7EK/BEbZAKBwn9ROfm+WK+6X5xOGLoRE++OqNuUudxC1GDyLOPaqCbBCS9 +P6HsTHzxsjyJa27n4jcrcuY3P9TEcFJYSZSeSDh8mVGvugi0exnSJrrBZDyVCcAEQEAAcLB ZQQYAQIADwIbDAUCWZR1ZwUJA59cIQAKCRD5M+tD3xNhH5b+D/9XG44Ci6STdcA5RO/ur05J EE3Ux1DCHZ5V7vNAtX/8Wg4l4GZfweauXwuJ1w7Sp7fklwcNC6wsceI+EmNjGMqfIaukGetG +jBGqsQ7moOZodfXUoCK98gblKgt/BPYMVidzlGC8Q/+lZg1+o29sPnwImW+MXt/Z5az/Z17 Qc265g+p5cqJHzq6bpQdnF7Fu6btKU/kv6wJghENvgMXBuyThqsyFReJWFh2wfaKyuix3Zyj ccq7/blkhzIKmtFWgDcgaSc2UAuJU+x9nuYjihW6WobpKP/nlUDu3BIsbIq09UEke+uE/QK+ FJ8PTJkAsXOf1Bc2C0XbW4Y2hf103+YY6L8weUCBsWC5VH5VtVmeuh26ENURclwfeXhWQ9Og 77yzpTXWr5g1Z0oLpYpWPv745J4bE7pv+dzxOrFdM1xNkzY2pvXph/A8OjxZNQklDkHQ7PIB Lki5L2F4XkEOddUUQchJwzMqTPsggPDmGjgLZrqgO+s4ECZK5+nLD3HEpAbPa3JLDaScy+90 Nu1lAqPUHSnP3vYZVw85ZYm6UCxHE4VLMnnJsN09ZhsOSVR+GyP5Nyw9rT1V3lcsuH7M5Naa 2Xobn9m7l9bRCD/Ji8kG15eV1WTxx1HXVQGjdUYDI7UwegBNbwMLh17XDy+3sn/6SgcqtECA Q6pZKA2mTQxEKMLBZQQYAQIADwIbDAUCWZR3hQUJA59eRwAKCRD5M+tD3xNhH4a/D/4jLAZu UhvU1swWcNEVVCELZ0D3LOV14XcY2MXa3QOpeZ9Bgq7YYJ4S5YXK+SBQS0FkRZdjGNvlGZoG ZdpU+NsQmQFhqHGwX0IT9MeTFM8uvKgxNKGwMVcV9g0IOqwBhGHne+BFboRA9362fgGW5AYQ zT0mzzRKEoOh4r3AQvbM6kLISxo0k1ujdYiI5nj/5WoKDqxTwwfuN1uDUHsWo3tzenRmpMyU NyW3Dc+1ajvXLyo09sRRq7BnM99Rix1EGL8Qhwy+j0YAv+FuspWxUX9FxXYho5PvGLHLsHfK FYQ7x/RRbpMjkJWVfIe/xVnfvn4kz+MTA5yhvsuNi678fLwY9hBP0y4lO8Ob2IhEPdfnTuIs tFVxXuelJ9xAe5TyqP0f+fQjf1ixsBZkqOohsBXDfje0iaUpYa/OQ/BBeej0dUdg2JEu4jAC x41HpVCnP9ipLpD0fYz1d/dX0F/VY2ovW6Eba/y/ngOSAR6C+u881m7oH2l0G47MTwkaQCBA bLGXPj4TCdX3lftqt4bcBPBJ+rFAnJmRHtUuyyaewBnZ81ZU2YAptqFM1kTh+aSvMvGhfVsQ qZL2rk2OPN1hg+KXhErlbTZ6oPtLCFhSHQmuxQ4oc4U147wBTUuOdwNjtnNatUhRCp8POc+3 XphVR5G70mnca1E2vzC77z+XSlTyRA== Message-ID: Date: Tue, 26 Jun 2018 16:40:21 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] eal/devargs: add option to supply PCI dev args X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jun 2018 15:40:25 -0000 On 6/26/2018 1:48 PM, Shahaf Shuler wrote: > Hi Pavan, > > Friday, June 15, 2018 7:44 AM, Pavan Nikhilesh: >> Subject: [dpdk-dev] [PATCH v2] eal/devargs: add option to supply PCI dev >> args >> >> Currently, the only way of supplying device argument to a pci device is to >> whitelist it i.e. -w 000X:00:0X.0,self_test=1. This is not a very feasible method >> as whitelisting a device has its own side effects i.e only the whitelisted pci >> devices are probed. >> >> Add a new eal command line option --pci-args to pass device args without the >> need to whitelist the devices. >> --pci-args 000X:00:0X.0,self_test=1 >> >> Signed-off-by: Pavan Nikhilesh > > Tested-by: Shahaf Shuler > > It seems to work. > Please see small comments below Isn't this conflict with Gaetan's devarg work which has wider scope? > >> --- >> v2 Changes: >> - Document the option usage in eal_common_usage. >> - Update commit log to be more informative. >> >> lib/librte_eal/common/eal_common_devargs.c | 3 +++ >> lib/librte_eal/common/eal_common_options.c | 9 +++++++++ >> lib/librte_eal/common/eal_options.h | 2 ++ >> lib/librte_eal/common/include/rte_dev.h | 1 + >> lib/librte_eal/common/include/rte_devargs.h | 1 + >> 5 files changed, 16 insertions(+) > > Should we also update the manual of testpmd (doc/guides/testpmd_app_ug/run_app.rst ) for the new eal arg? > >> >> diff --git a/lib/librte_eal/common/eal_common_devargs.c >> b/lib/librte_eal/common/eal_common_devargs.c >> index b0434158b..a56bfeea0 100644 >> --- a/lib/librte_eal/common/eal_common_devargs.c >> +++ b/lib/librte_eal/common/eal_common_devargs.c >> @@ -156,6 +156,9 @@ rte_devargs_add(enum rte_devtype devtype, const >> char *devargs_str) >> bus = devargs->bus; >> if (devargs->type == RTE_DEVTYPE_BLACKLISTED_PCI) >> devargs->policy = RTE_DEV_BLACKLISTED; >> + else if (devargs->type == RTE_DEVTYPE_WHITELISTED_PCI) >> + devargs->policy = RTE_DEV_WHITELISTED; >> + >> if (bus->conf.scan_mode == RTE_BUS_SCAN_UNDEFINED) { >> if (devargs->policy == RTE_DEV_WHITELISTED) >> bus->conf.scan_mode = RTE_BUS_SCAN_WHITELIST; >> diff --git a/lib/librte_eal/common/eal_common_options.c >> b/lib/librte_eal/common/eal_common_options.c >> index ecebb2923..31eebaa53 100644 >> --- a/lib/librte_eal/common/eal_common_options.c >> +++ b/lib/librte_eal/common/eal_common_options.c >> @@ -76,6 +76,7 @@ eal_long_options[] = { >> {OPT_VMWARE_TSC_MAP, 0, NULL, >> OPT_VMWARE_TSC_MAP_NUM }, >> {OPT_LEGACY_MEM, 0, NULL, OPT_LEGACY_MEM_NUM }, >> {OPT_SINGLE_FILE_SEGMENTS, 0, NULL, >> OPT_SINGLE_FILE_SEGMENTS_NUM}, >> + {OPT_PCI_DEVARGS, 1, NULL, OPT_PCI_DEVARGS_NUM}, >> {0, 0, NULL, 0 } >> }; >> >> @@ -1224,6 +1225,12 @@ eal_parse_common_option(int opt, const char >> *optarg, >> case OPT_SINGLE_FILE_SEGMENTS_NUM: >> conf->single_file_segments = 1; >> break; >> + case OPT_PCI_DEVARGS_NUM: >> + if (eal_option_device_add(RTE_DEVTYPE_NORMAL, >> + optarg) < 0) { >> + return -1; >> + } >> + break; >> >> /* don't know what to do, leave this to caller */ >> default: >> @@ -1360,6 +1367,8 @@ eal_common_usage(void) >> " --"OPT_VDEV" Add a virtual device.\n" >> " The argument format is [,key=val,...]\n" >> " (ex: --vdev=net_pcap0,iface=eth2).\n" >> + " --"OPT_PCI_DEVARGS" Pass key-value arguments to a pci >> device\n" >> + " The argument format is >> [,key=val,...]\n" >> " -d LIB.so|DIR Add a driver or driver directory\n" >> " (can be used multiple times)\n" >> " --"OPT_VMWARE_TSC_MAP" Use VMware TSC map instead >> of native RDTSC\n" >> diff --git a/lib/librte_eal/common/eal_options.h >> b/lib/librte_eal/common/eal_options.h >> index 211ae06ae..d52d38e32 100644 >> --- a/lib/librte_eal/common/eal_options.h >> +++ b/lib/librte_eal/common/eal_options.h >> @@ -59,6 +59,8 @@ enum { >> OPT_LEGACY_MEM_NUM, >> #define OPT_SINGLE_FILE_SEGMENTS "single-file-segments" >> OPT_SINGLE_FILE_SEGMENTS_NUM, >> +#define OPT_PCI_DEVARGS "pci-args" >> + OPT_PCI_DEVARGS_NUM, >> OPT_LONG_MAX_NUM >> }; >> >> diff --git a/lib/librte_eal/common/include/rte_dev.h >> b/lib/librte_eal/common/include/rte_dev.h >> index 3879ff3ca..fb3e5033f 100644 >> --- a/lib/librte_eal/common/include/rte_dev.h >> +++ b/lib/librte_eal/common/include/rte_dev.h >> @@ -124,6 +124,7 @@ enum rte_kernel_driver { >> * Device policies. >> */ >> enum rte_dev_policy { >> + RTE_DEV_NORMAL, >> RTE_DEV_WHITELISTED, >> RTE_DEV_BLACKLISTED, >> }; >> diff --git a/lib/librte_eal/common/include/rte_devargs.h >> b/lib/librte_eal/common/include/rte_devargs.h >> index 58fbd90a2..78c600bf2 100644 >> --- a/lib/librte_eal/common/include/rte_devargs.h >> +++ b/lib/librte_eal/common/include/rte_devargs.h >> @@ -29,6 +29,7 @@ extern "C" { >> * Type of generic device >> */ >> enum rte_devtype { >> + RTE_DEVTYPE_NORMAL, /* Normal dev with special pci args */ > > What is "Normal" device? Can we find a better name? > >> RTE_DEVTYPE_WHITELISTED_PCI, >> RTE_DEVTYPE_BLACKLISTED_PCI, >> RTE_DEVTYPE_VIRTUAL, >> -- >> 2.17.1 >