From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Zhao1, Wei" <wei.zhao1@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>, "Peng, Yuan" <yuan.peng@intel.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/i40e: fix queue region error in priority configuration
Date: Tue, 22 Jan 2019 16:33:48 +0000 [thread overview]
Message-ID: <cd678232-ca22-2682-9efe-0e2be233e670@intel.com> (raw)
In-Reply-To: <039ED4275CED7440929022BC67E7061153320452@SHSMSX103.ccr.corp.intel.com>
On 1/22/2019 12:48 PM, Zhang, Qi Z wrote:
>
>
>> -----Original Message-----
>> From: Zhao1, Wei
>> Sent: Tuesday, January 22, 2019 4:11 PM
>> To: dev@dpdk.org
>> Cc: stable@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Peng, Yuan
>> <yuan.peng@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
>> Subject: [PATCH] net/i40e: fix queue region error in priority configuration
>
> Change title to below since it's all about if we need to call i40e_set_dcb_config
>
> fix queue region dcb configure
>
>
>>
>> There is no need to set vlan priority realted resigsters when there is no
>> configuration about that in queue region.
>
> Reword to
>
> DCB is not necessary to be configured if no user priority of queue region is requested.
Extended description with provided information as below, please comment if
change required for this update.
"
DCB is not necessary to be configured if no user priority of
queue region is requested.
Unexpected configuration of DCB will cause unexpected behavior, like
FDIR does not work on those queues, but could cause more issues.
"
>>
>> Fixes: 7cbecc2f7424 ("net/i40e: support queue region set and flush")
>> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
>
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
>
> Applied to dpdk-next-net-intel with above change.
>
> Thanks
> Qi
>
next prev parent reply other threads:[~2019-01-22 16:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 8:11 [dpdk-dev] " Wei Zhao
2019-01-22 9:31 ` Zhao1, Wei
2019-01-22 12:48 ` Zhang, Qi Z
2019-01-22 16:33 ` Ferruh Yigit [this message]
2019-01-23 1:56 ` [dpdk-dev] [dpdk-stable] " Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd678232-ca22-2682-9efe-0e2be233e670@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=wei.zhao1@intel.com \
--cc=yuan.peng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).