From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 781ED69C3 for ; Wed, 8 Mar 2017 16:50:32 +0100 (CET) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Mar 2017 07:50:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,264,1486454400"; d="scan'208";a="74274029" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.254.185.68]) ([10.254.185.68]) by fmsmga006.fm.intel.com with ESMTP; 08 Mar 2017 07:50:28 -0800 To: Beilei Xing , jingjing.wu@intel.com References: <1488533497-27682-1-git-send-email-beilei.xing@intel.com> <1488533497-27682-4-git-send-email-beilei.xing@intel.com> Cc: helin.zhang@intel.com, dev@dpdk.org, Bernard Iremonger , Yong Liu From: Ferruh Yigit Message-ID: Date: Wed, 8 Mar 2017 15:50:28 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1488533497-27682-4-git-send-email-beilei.xing@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 3/4] net/i40e: support tunnel filter to VF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2017 15:50:32 -0000 On 3/3/2017 9:31 AM, Beilei Xing wrote: > This patch is to support tunnel filter to VF. > > Signed-off-by: Bernard Iremonger > Signed-off-by: Yong Liu > Signed-off-by: Beilei Xing > --- <...> > +/** > + * Tunneling Packet filter configuration. > + */ > +struct i40e_tunnel_filter_conf { There is already "rte_eth_tunnel_filter_conf", why driver is creating its own version of structure instead of using / updating public one? > + struct ether_addr outer_mac; /**< Outer MAC address to match. */ > + struct ether_addr inner_mac; /**< Inner MAC address to match. */ > + uint16_t inner_vlan; /**< Inner VLAN to match. */ > + uint32_t outer_vlan; /**< Outer VLAN to match */ > + enum rte_tunnel_iptype ip_type; /**< IP address type. */ > + /** > + * Outer destination IP address to match if ETH_TUNNEL_FILTER_OIP > + * is set in filter_type, or inner destination IP address to match > + * if ETH_TUNNEL_FILTER_IIP is set in filter_type. > + */ > + union { > + uint32_t ipv4_addr; /**< IPv4 address in big endian. */ > + uint32_t ipv6_addr[4]; /**< IPv6 address in big endian. */ > + } ip_addr; > + /** Flags from ETH_TUNNEL_FILTER_XX - see above. */ > + uint16_t filter_type; > + enum rte_eth_tunnel_type tunnel_type; /**< Tunnel Type. */ > + uint32_t tenant_id; /**< Tenant ID to match. VNI, GRE key... */ > + uint16_t queue_id; /**< Queue assigned to if match. */ > + uint8_t is_to_vf; /**< 0 - to PF, 1 - to VF */ > + uint16_t vf_id; /**< VF id for tunnel filter insertion. */ > +}; > + <...>