From: Pekka Riikonen <priikone@iki.fi>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org
Subject: Re: [PATCH] bus/pci: fix automatic interrupt type selection
Date: Fri, 27 Jun 2025 22:33:22 +0300 [thread overview]
Message-ID: <cdbd9d284dd174f99601f032ca6ee8fa@iki.fi> (raw)
In-Reply-To: <7218036.9CP3fYhb5E@thomas>
On 2025-06-27 19:00, Thomas Monjalon wrote:
> 20/06/2025 13:47, priikone@iki.fi:
>> Check if kernel returns 0 interrupt vectors and try another interrupt
>> type in that case. Failing to check the vector count can select an
>> interrupt type that's unusable.
>>
>> Signed-off-by: Pekka Riikonen <priikone@iki.fi>
>
> Please could you be explicit about the use case you are trying to fix?
This particular case was with e1000em that only supported INTx, but the
function selected MSI-X simply because it's the first one attempted,
even though it got 0 vectors. Enabling interrupts then failed. If the
function had checked the vector count it would have correctly selected
INTx. Now, my setup might have been quite old but it doesn't change
that it selected wrong interrupt type.
Pekka
next prev parent reply other threads:[~2025-06-27 19:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-20 11:47 priikone
2025-06-27 16:00 ` Thomas Monjalon
2025-06-27 19:33 ` Pekka Riikonen [this message]
2025-06-27 20:08 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cdbd9d284dd174f99601f032ca6ee8fa@iki.fi \
--to=priikone@iki.fi \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).