From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Pallavi Kadam <pallavi.kadam@intel.com>,
dev@dpdk.org, thomas@monjalon.net
Cc: dmitry.kozliuk@gmail.com, ranjit.menon@intel.com,
qiming.yang@intel.com, qi.z.zhang@intel.com
Subject: Re: [dpdk-dev] [PATCH v2 2/3] net/ice: build on Windows
Date: Fri, 26 Mar 2021 11:51:56 +0000 [thread overview]
Message-ID: <cdcced0c-0cad-86f4-08fc-229fb0c9d540@intel.com> (raw)
In-Reply-To: <20210311015848.4976-3-pallavi.kadam@intel.com>
On 3/11/2021 1:58 AM, Pallavi Kadam wrote:
> - Add Intel ice PMD support on Windows.
> - Remove #include sys/ioctl header file as it is not needed.
> - Replace x86intrin.h with rte_vect.h to avoid __m_prefetchw conflicting
> types.
> - Replace POSIX usleep() API with rte API.
> - Add a new macro for the access() API as the original function
> has been deprecated on Windows.
> - Add extra cflags '-fno-asynchronous-unwind-tables'
> to avoid MinGW build error:
> Error: invalid register for .seh_savexmm
> - Add documentation to support ice PMD on Windows.
> Update the release notes and features list for the same.
>
> Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
> Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
<...>
> --- a/drivers/net/ice/base/ice_switch.c
> +++ b/drivers/net/ice/base/ice_switch.c
> @@ -6684,7 +6684,7 @@ ice_fill_valid_words(struct ice_adv_lkup_elem *rule,
>
> for (j = 0; j < sizeof(rule->m_u) / sizeof(u16); j++)
> if (((u16 *)&rule->m_u)[j] &&
> - rule->type < ARRAY_SIZE(ice_prot_ext)) {
> + (unsigned long long)rule->type < ARRAY_SIZE(ice_prot_ext)) {
isn't 'ARRAY_SIZE' return type is 'size_t', if 'size_t' is supported in Windows
why not cast to it, instead of "unsigned long long".
<...>
> index b82d05fe7..01f8f409d 100644
> --- a/drivers/net/ice/base/meson.build
> +++ b/drivers/net/ice/base/meson.build
> @@ -29,6 +29,10 @@ foreach flag: error_cflags
> endif
> endforeach
>
> +if is_windows and cc.get_id() != 'clang'
> + cflags += ['-fno-asynchronous-unwind-tables']
> +endif
> +
This seems not having affect [1], may be because 'cflags' is not used for build
but 'c_args', moving the block above "c_args = cflags" assignment may work.
[1]
http://mails.dpdk.org/archives/test-report/2021-March/182218.html
next prev parent reply other threads:[~2021-03-26 11:52 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 21:59 [dpdk-dev] [PATCH 0/4] Support ice PMD " Pallavi Kadam
2021-03-03 21:59 ` [dpdk-dev] [PATCH 1/4] build: enable iavf driver " Pallavi Kadam
2021-03-03 21:59 ` [dpdk-dev] [PATCH 2/4] net/ice: build " Pallavi Kadam
2021-03-04 12:56 ` David Marchand
2021-03-08 23:30 ` Kadam, Pallavi
2021-03-03 21:59 ` [dpdk-dev] [PATCH 3/4] net/ice: disable ice DDP package " Pallavi Kadam
2021-03-03 23:12 ` Dmitry Kozlyuk
2021-03-05 0:31 ` Kadam, Pallavi
2021-03-03 21:59 ` [dpdk-dev] [PATCH 4/4] doc: update ice PMD and 21.05 release notes Pallavi Kadam
2021-03-03 23:13 ` Dmitry Kozlyuk
2021-03-05 0:25 ` Kadam, Pallavi
2021-03-11 1:58 ` [dpdk-dev] [PATCH v2 0/3] Support ice PMD on Windows Pallavi Kadam
2021-03-11 1:58 ` [dpdk-dev] [PATCH v2 1/3] build: enable iavf base code to build on windows Pallavi Kadam
2021-03-25 16:41 ` Jie Zhou
2021-03-26 11:41 ` Ferruh Yigit
2021-03-28 2:05 ` Kadam, Pallavi
2021-03-11 1:58 ` [dpdk-dev] [PATCH v2 2/3] net/ice: build on Windows Pallavi Kadam
2021-03-25 16:48 ` Jie Zhou
2021-03-26 11:51 ` Ferruh Yigit [this message]
2021-03-28 2:00 ` Kadam, Pallavi
2021-03-26 11:58 ` Ferruh Yigit
2021-03-28 2:04 ` Kadam, Pallavi
2021-03-11 1:58 ` [dpdk-dev] [PATCH v2 3/3] net/ice: disable ice DDP package " Pallavi Kadam
2021-03-25 16:55 ` Jie Zhou
2021-03-26 11:53 ` Ferruh Yigit
2021-03-28 2:02 ` Kadam, Pallavi
2021-04-02 1:26 ` [dpdk-dev] [PATCH v3 0/3] Support ice PMD " Pallavi Kadam
2021-04-02 1:26 ` [dpdk-dev] [PATCH v3 1/3] build: enable iavf base code to build on windows Pallavi Kadam
2021-04-02 1:26 ` [dpdk-dev] [PATCH v3 2/3] net/ice: build on Windows Pallavi Kadam
2021-04-02 1:26 ` [dpdk-dev] [PATCH v3 3/3] net/ice: disable ice DDP package " Pallavi Kadam
2021-04-06 16:40 ` [dpdk-dev] [PATCH v3 0/3] Support ice PMD " Ferruh Yigit
2021-04-06 17:22 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cdcced0c-0cad-86f4-08fc-229fb0c9d540@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=pallavi.kadam@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=ranjit.menon@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).