From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6334242D07; Tue, 20 Jun 2023 13:25:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3D0644068E; Tue, 20 Jun 2023 13:25:26 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2056.outbound.protection.outlook.com [40.107.243.56]) by mails.dpdk.org (Postfix) with ESMTP id 18651400D6 for ; Tue, 20 Jun 2023 13:25:25 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dOVQdqtrrB6QeGg4XLVqOu11WtZqMWZju3zuKR5NwkmwFBi9KdFVbwNjT++MHJCDeMot3vzbcapfbU5WKUWqeAGL5fhqFvwyWbeLs7UeaNRvbzEtVV2pATqwSSwZnmdkYkfw9Vm/DbW0dIsAyxBV9qQ/G1e/uWEkqLvYYr+9GG/hVKkYkscZF7kaAiAfEsAFka3oyd0tyROTYielw47GgW7h4M1ngSz1mTDSAxyS4f94Av2hn8OEbKs7YARxKPBf00Oi9Ja9CTh2jbvKUO9BpgFWnRIGtwalAHa7i9ttojQhDJ1uTaLQamqcZyq+kskMTLmSZNxAcznfEzEC8dXtyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Aoo7LNWuyeZV3hpw4g5sA9e8NYDmM6dMi9Utc+7+x3k=; b=oBJuByGNK8fVMhq1h7GN6B3uokAvGghF6LYGO2hNH2/C2UybWYx/a3kBNoRVQm4bh+jbcOLD29LECkHK6A78pGIpNQxtSKSckFjQMoLsBN1jBbjvXDchDBBqeteuRw4by/T5S/c5dkh4nSXF7YUOgXsWhftFWt76B0nRKP9vRTm2vOhLnRZdOnmxntWGJdnLOG5SBmW0RnB3T45WP5FUfMw62749AT4nJycgn9MKDVMHIN9teakeLsyodFZbFznXjBd7Fvg4HJQKMZGV2UonCx0g1S8gn6vWLScauzOR6VQf85Be4z1V9x95vSL75vCa4ta2Pi2B/WwgwBYO3Ide0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Aoo7LNWuyeZV3hpw4g5sA9e8NYDmM6dMi9Utc+7+x3k=; b=LYiLZH3/hXF8vkCP2OsZ+59Xp5jErjc/wB1hjwZPTsAfu38mZAhB0EfYrYpzFW9cnbMaWuJCk6up7jX6AGXe8b0EqbMEn83g/5xD5D6NJfPmp/cpYuV9Z5ZjcsH0KPI+y/fIzLCuxL1QXZ/lUThQksp1BAGo1Jr8ppTmDtjPCF4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CYYPR12MB8751.namprd12.prod.outlook.com (2603:10b6:930:ba::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.35; Tue, 20 Jun 2023 11:25:23 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42%3]) with mapi id 15.20.6500.036; Tue, 20 Jun 2023 11:25:22 +0000 Message-ID: Date: Tue, 20 Jun 2023 12:25:18 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 1/3] net/sfc: split link update function Content-Language: en-US To: Andrew Rybchenko , Denis Pryazhennikov , dev@dpdk.org Cc: Ivan Malov , Andy Moreton References: <20230601222349.28965-1-denis.pryazhennikov@arknetworks.am> <20230601222349.28965-2-denis.pryazhennikov@arknetworks.am> <620d7d0d-30d3-3f8e-5e0f-75d2df758507@oktetlabs.ru> From: Ferruh Yigit In-Reply-To: <620d7d0d-30d3-3f8e-5e0f-75d2df758507@oktetlabs.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0065.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:153::16) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CYYPR12MB8751:EE_ X-MS-Office365-Filtering-Correlation-Id: ce4fa828-c4ea-4875-604e-08db71810990 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fuDSc1X9w36biyJqdAxDHapEKO4JLaennGwW2ErxwggAzk4gyFEQZflMMS9Zw2mrjA3dGA6HWEt902QiTI6ZAsKYjB3XF9ud3E79QyiRD4/PYXTcDjHbthhLBnWcrk9T9h/Ihqs8Wkt763cDHQinXF0TWijQX0/PRqNaHHQjPgCkUaJiTZN2whYAlFVR9VXbWA8rlX6BWZGTygQo6N6vg+0P+ePG8Yqh0zJFnQ3jzYyeSzoY5c4mHj0iKsPPNc0ig6OQGmtArW0VL5+z3p1+XPJoxBi9Jew0BY9h+SGizKeHs24Kgt9COFkpPCzGlQxs6U4EqSe929s+JRMReaaLosDRUWHDwAlfFI8sclTnvc929Y+zVttGDeXuOkUtjlHFlU3t+LmJSCbH7H+FeFfRdXo80thvOft/xi9B2s/THMUoN3DWwk0jmCaHLKIM1hiQohq01ZSMJQtN7OIntUdtDq7ewcfaPaKxWE8haOlgBKoNKmDDaZO98uddLyk54xXERVjETLiAz/09xHq2VCmXWlN8wHKNc9WjN0u6FqxVk8SImNZE/oyTAWbdZovv+h4hYzGaiYxrQgnmof+zdO6OptKbZvEc0KCM5eqGFzIAyLKuG9EPr77cg1Z5Em3ZCpTwIFbGkqaaCTkvCMd8dLBkqQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(376002)(366004)(136003)(39860400002)(346002)(451199021)(38100700002)(36756003)(31696002)(86362001)(6666004)(6486002)(53546011)(6512007)(26005)(186003)(8936002)(8676002)(6506007)(15650500001)(5660300002)(44832011)(4744005)(478600001)(110136005)(54906003)(31686004)(316002)(41300700001)(66946007)(4326008)(66476007)(2906002)(66556008)(83380400001)(2616005)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SEdyOTNuK3gwS1Y1OWdmTWxweVdockU4ZzNaNUIxcWFnZS9lZGFkbHdacUpt?= =?utf-8?B?VU1FM2pHQndnVU52YWZialZGeUNBaE40cUE0TDhicVVWWXJrUUlWWE5VTTd4?= =?utf-8?B?bm5yQzlmdWdKMjZSYldFdmdBQUZ1bUhwNDk4TUZFaVdBdU1hRk1iT1AyaWNn?= =?utf-8?B?YVRUdHRWeGh3azBMZEhhY003bkxDZm9FK2JoY2hZU1JsUE5vaUUraVI2ODhO?= =?utf-8?B?SythUld5MEhxcksya3RqczhVTkllRDVMTFJxYXY1eUpBVUFtWVpyQUh6YmN4?= =?utf-8?B?VERVdk5KUG5mdVRxVmFRTnFGMmd0Mk5RcS9BNmRSWjQ2ZGJJZjFHbmFDVVFP?= =?utf-8?B?cDVOWFNPTXRabFZPa0ZBa3Z1UUxiOHgyN3V3MXNZRWNTdDRMQ2t5K0NMU3FY?= =?utf-8?B?dU5hQkFkRUtLTW93K1ZhOTU3dW13cnpqRU5vYXJaeVJ5R1lndG1JUHVBZzhn?= =?utf-8?B?eTVhZGNoZFlZZ0lsZzNTT3FjbjZ4WWFvLzBVeG1zVjFtOUJTMnU0djZJWndP?= =?utf-8?B?RGxXNXR1Mkc5Uk1sMnpucUJwU1NLOEpSZXZZRlJaK0pjaTI5Y1lxRzU5RHI0?= =?utf-8?B?eVJFQVlkanJ0UDA0dXlTdmNMRWYvZVJmR2dzQ0ZWYm5VSktEZytYSHJmbk9q?= =?utf-8?B?WnA5TDdjOXJ2aUZ6K1pmTVh2cXNjdU80NkV4RVR0aVA5KzRyODEyNmtTT2o0?= =?utf-8?B?UkZiaTNCWkJHWGFsRGQ2bmwrWVd5R21tR3NlMEF5dmxOSTNnOFUrTVB4ZDRG?= =?utf-8?B?QkxMUHNzY1hwU0JUV09CVGVZQ0Q3WEdLOVRnUWJ5Zk10cXVXVW5iNVhGODNu?= =?utf-8?B?ZTU5amR4Myt5ejlxcTFBUCtHa25xNXd6STFybnBqeXh2b0VmYVZIdkpLQUFy?= =?utf-8?B?RUd6Y1pzMXQ5SUp6RXU1WTE1bVhLb2tXRjIxeGV0bVU4eW1uQjhvQkJuREhK?= =?utf-8?B?aGZKOHRKZkRUdGx5WVB0eGhRTUFCcFFOc255UTRmZUIzMWl1dGdUZXZkVmlw?= =?utf-8?B?OVU1ZGY0a2dYSW5kL21nOUVqY3FsQUtkSDRmWGtiMnlyUU4rTlA1ajhhYU1K?= =?utf-8?B?eno2b0xvQmVpbG5PSUpScFB5Q1Y2VzhRV1N0allxbFNDdUJvUzdBelIxRW43?= =?utf-8?B?SFNQaUY0K1JhQjZkK25wZjFMNFVxZklGbmFMbEhua3lLaTk0UnhBNDc0V2ZK?= =?utf-8?B?aG4vUTViVUdyRk9maU5jNlJDamRTUjJzTzVkM0FRTkx2bGk2QW92NUVDT1R4?= =?utf-8?B?cEo5aXJra1FmVllnQndiYXo3bFJTS0JyMklROE9GbUxMNVczb0VGTkNGSFo2?= =?utf-8?B?WHRPZ2VDYjM5eVh1a3FHcEE3aXVXQWEvSWFKd1RwTzRwdkF4VjdTOCtKYnNO?= =?utf-8?B?dXZzWE9VMU84c0RLZFdkUXFPQVFvR0VHMHNaZ1ZpbVdsZmxoazE3NUtKNkpZ?= =?utf-8?B?YzVnMnFpa1lDU0YxVUVzZWFQcElTaW90ZWdiRzRzVVFCSXZjWnBFQ3ZmcjNr?= =?utf-8?B?L2E3SktsNkM1UldvVFFET2ZFczJJMGJYZ0Q1WXBkYmNXNDFrS3N6YVJFRm9G?= =?utf-8?B?WklXSGVqQ2hIZ0RvcHdSMzlVK1NGbitwdE1HZzRRNjdxVjY3MjYxZjVMOUYr?= =?utf-8?B?czUrczdoU2NCSkFuQkpUYTEwV2o1Zy9kc3dQZnk1dTdnaUJhQ09pUjdsaFNJ?= =?utf-8?B?N1NtM1U4Kzk3dXFybUNRTGRBaVNZUW5MMTRFSjdFMWV1R2tCYWQvcG1JeFds?= =?utf-8?B?U2wrZHRnV0JjWjUyWHpqQWdlcXIwZ2Z0VFBseHU1NEdXWkpuNzk5SXV4aWt5?= =?utf-8?B?dzhEd29MUTd4UWU4emMzVVhtUTlIem1OUGZoTjhTaXZjcWtlSzFtclpyTUVI?= =?utf-8?B?RGNacVBZZ2dDR09CWnM1cVZjSnNUYnNLVzVzWktBL2JuTlJlMlNZaklWbnF1?= =?utf-8?B?U21vZ05iRTBOZGQvREtvWW5DUDhhUzFjUHZRWHZyamZuZ29weTdtOHViakJL?= =?utf-8?B?WEpaeHlhc1FOazNVT3dESFp3a1VOKzRFK2RmQ0xneUJmaWFaUGk0dDBUNEZv?= =?utf-8?B?SXgvM2FPK0F5TmtNTzNSTjVDak80THRvQTRBR0d2dmlrZ0pFNjJ3ZlM1MVBv?= =?utf-8?Q?u2/mQ8hxFmbwQ/RuuLNWRHN87?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: ce4fa828-c4ea-4875-604e-08db71810990 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2023 11:25:22.9388 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1iaAoOoeuJUiMLOThTMNWp+rrD2aGUttKWhmqmHeuMVmuq7p73qIZcR4XnUcHpVH X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB8751 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/2/2023 9:52 AM, Andrew Rybchenko wrote: > On 6/2/23 01:23, Denis Pryazhennikov wrote: >> Separate the original link update function into >> two functions: state retrieval and update. >> This improves code clarity and maintainability. >> >> Signed-off-by: Denis Pryazhennikov >> Reviewed-by: Ivan Malov >> Reviewed-by: Andy Moreton > > Acked-by: Andrew Rybchenko > > Hi Andrew, You have other email address [1] recorded in .mailmap, I will keep using it, if this is new preferred address please update .mailmap [1] Andrew Rybchenko