From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id ECA212BA3 for ; Wed, 25 Jan 2017 13:17:33 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP; 25 Jan 2017 04:17:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,283,1477983600"; d="scan'208";a="926463209" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.38]) ([10.237.220.38]) by orsmga003.jf.intel.com with ESMTP; 25 Jan 2017 04:17:31 -0800 From: Ferruh Yigit To: "Zhao1, Wei" , Adrien Mazarguil References: <1484212665-1635-1-git-send-email-wei.zhao1@intel.com> <1484295192-34009-1-git-send-email-wei.zhao1@intel.com> <1484295192-34009-15-git-send-email-wei.zhao1@intel.com> <20170116130348.GA3779@6wind.com> <84768b60-d645-eb0b-37e4-4482cde4c68e@intel.com> Cc: "dev@dpdk.org" , "Lu, Wenzhuo" Message-ID: Date: Wed, 25 Jan 2017 12:17:31 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6 14/18] net/ixgbe: parse L2 tunnel filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jan 2017 12:17:34 -0000 On 1/18/2017 5:49 PM, Ferruh Yigit wrote: <...> >>>>>>> >>>>>> >>>>>> OK for these definitions, however API documentation >>>>>> (doc/guides/prog_guide/rte_flow.rst) must be kept up to date, and it >>>>>> would be great if testpmd support for these new items was added >>>>>> simultaneously (changes in app/test-pmd/cmdline.c, >>>>>> app/test-pmd/cmdline_flow.c and >>>>> doc/guides/testpmd_app_ug/testpmd_funcs.rst). >>>>>> >>>>>> How about putting all rte_flow changes (API & testpmd) in their own >>>>>> separate patch? >>>>> >>>>> I thought it can be more useful to have library and its user updated >>>>> in same patch, gives more context. But missed rte_flow documentation ... >>>>> >>>>>> >>>>>> You could use VLAN PCP/DEI/VID definitions as an example to expose >>>>>> partial bit-fields (e.g. epcp_edei_in_ecid_b) in testpmd, see: >>>>>> >>>>>> 1419fd5a6c9f ("app/testpmd: add protocol fields to flow command") >>>>>> >>>>>> Now if re-spinning this series yet again is too much work, you can >>>>>> go ahead with this commit as long as you do not forget to submit the >>>>>> rest later, thanks. >>>>>> >>>>> >>>>> Is following todo list complete: >>>>> 1- update rte_flow document, doc/guides/prog_guide/rte_flow.rst, >>>>> document two new item types: E_TAG & NVGRE. >>>>> >>>>> 2- Add testpmd sample implementation and documentation. >>>>> >>>> >>>> I am sorry for miss rte_flow.rst document update, I DON'T know there is >>> such a new file of rte_flow.rst. >>>> And also these two types of E_TAG & NVGRE are added into code after >>>> rte_flow patch, So testpmd implementation do not support for these type. >>>> Now, we have been work on task of 17.05. >>>> How about finish (1) first as one patch, then after busy work of 17.05 to >>> add (2) as another patch? >>>> OR, if these two work merge in to patch set, I will may be begin to do after >>> the 17.05 task finish? >>>> Which one is OK for you? >>> >>> Changes can be in two separate patches, and if possible, can this get priority >>> against 17.05 task? >>> This is for 17.02 feature and not completely finished, missing for last touches.. >>> >>> Thanks, >>> ferruh >>> >>>> >>>> Thank you. >>>>> >>>>> Hi Wei, >>>>> >>>>> Would you mind working on a patch to cover above items? >>>>> >>>>> Thanks, >>>>> ferruh >>>> >> >> Add testpmd implementation example is not in our plan from the begin of the task generic filter API by us, >> Because all this part is not covered by us(intel) when task allocation. > > Right, sample testpmd implementation is not directly related to the > adding rte_flow support to the driver. > > But for this, a rte_flow library update required, and sample testpmd > implementation is part of rte_flow update. > >> BUT if this component is need by community, I will report to my leader and add it into our next work plan and try to finish it ASAP. > > Yes please, I believe it is needed. Is there any update from this work? > > Thanks, > ferruh > >> >> Thank you. >> >