From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CA89FA0527; Mon, 9 Nov 2020 11:51:57 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9908E5946; Mon, 9 Nov 2020 11:51:55 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 5BFC45928 for ; Mon, 9 Nov 2020 11:51:53 +0100 (CET) IronPort-SDR: SlWJFu2Nv22wVxdcNtfHfFTiQi3Cv7TU84HjjLRKtmje2PsaSa1dAEZIoWWCS+T1MoPFiVRKOv 9UkXlnwucIcw== X-IronPort-AV: E=McAfee;i="6000,8403,9799"; a="167196064" X-IronPort-AV: E=Sophos;i="5.77,463,1596524400"; d="scan'208";a="167196064" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2020 02:51:51 -0800 IronPort-SDR: d+KRurXz3pHfbtdx8w7KmSrfCAlvXZylaHCBfW2hSn7f2Y9RPX6RMtPg8E0eVcQC7Yl8p6UYsC E9T81wWDBWug== X-IronPort-AV: E=Sophos;i="5.77,463,1596524400"; d="scan'208";a="530683931" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.193.177]) ([10.213.193.177]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2020 02:51:50 -0800 To: oulijun Cc: dev@dpdk.org, linuxarm@huawei.com References: <1604586194-29523-1-git-send-email-oulijun@huawei.com> <1604634716-43484-1-git-send-email-oulijun@huawei.com> <1604634716-43484-4-git-send-email-oulijun@huawei.com> <3cdc7009-177b-0323-4577-37c7fb2aa04f@intel.com> From: Ferruh Yigit Message-ID: Date: Mon, 9 Nov 2020 10:51:46 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 3/5] net/hns3: adjust some code style X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/9/2020 9:32 AM, oulijun wrote: > > > 在 2020/11/7 0:44, Ferruh Yigit 写道: >> On 11/6/2020 3:51 AM, Lijun Ou wrote: >>> From: Hongbo Zheng >>> >>> Here adjusts some code style for making the lines more >>> compact and removes some static check tool warnings. >>> >>> Signed-off-by: Hongbo Zheng >>> Signed-off-by: Lijun Ou >>> --- >>> V1->V2: >>> - fix checkpatch warning >>> --- >>>   drivers/net/hns3/hns3_cmd.c    |   1 - >>>   drivers/net/hns3/hns3_ethdev.c |   6 +- >>>   drivers/net/hns3/hns3_ethdev.h |   1 - >>>   drivers/net/hns3/hns3_flow.c   |  37 +- >>>   drivers/net/hns3/hns3_intr.c   | 873 +++++++++++++++++++++++++++-------------- >>>   drivers/net/hns3/hns3_rxtx.c   |   1 - >>>   drivers/net/hns3/hns3_stats.c  |   1 - >>>   7 files changed, 597 insertions(+), 323 deletions(-) >> >> This is a big(ish) patch with just whitespace changes, looks like related to >> the personal preferences. >> This will create noise in the git history, and unnecessary conflict in >> backporting patches. >> >> I know it is tempting to fix here or there :), but lets fix those when >> updating those lines for a functional change, and drop this patch. >> . > Requirements for some static check tools: > When struct and union members are initialized, each member is initialized on a > separate line. > We think this requirement can be a better code style. > We can split the just whitespace changes with the above requirements? > because the Redundant blank lines  alarms. > I see, so the changes in 'hns3_intr.c' is coming from that requirement, yes can you please separate each static analyzer warning into its patch with explanation in the commit log why the change is done. And I think can drop the just whitespace changes. Thanks, ferruh